From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07082C05027 for ; Mon, 20 Feb 2023 16:54:40 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3EA47858ED; Mon, 20 Feb 2023 17:54:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="pq3OIK2L"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 63A3A85905; Mon, 20 Feb 2023 17:54:35 +0100 (CET) Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B1271858D4 for ; Mon, 20 Feb 2023 17:54:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2d.google.com with SMTP id f1so2457609qvx.13 for ; Mon, 20 Feb 2023 08:54:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aYhmqg6N4+z1GPjOZzUFnSwtdAEPFh8TREvJlx/nyx8=; b=pq3OIK2LUYXzSRSFwNQExJWbvio31IshdL8OmiCBSBUnP4dIu0ok/WVbCgnwbynDSZ OBHhLasvApMSTrltSnrcoZwrf3a77V/tV5xNUBXzFYe2UoParQK7k4k+2PuKpMkkibdd mns80av8KgkynPK2cUrGckM/wodHkLo/UMBh8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aYhmqg6N4+z1GPjOZzUFnSwtdAEPFh8TREvJlx/nyx8=; b=WXzLkcYo9lSsicZvv4/2g3vtyhb3Oaz8Mc4nWYdDtWJQ2drEpJIrcNZ4RcXxsPPmFh EZUlD7Gm6YgX130GL2MZFXlowxmT4Ba6a6y/YoMlTJLToIKF56z1R4hnscKJZ+3peoV+ xNkSXr2gnhDrat6LgK4wAdNhVl7QOfFNtpVEl0SRxlxKHU0jKmAGI8Bu+h+Ui9l8FjUW GScri7bQhJpz1vsNKePJBoA0OS6aQPRewHiLLD/UjAJ3AhBgBUIK/Ox+nPijtqwkqybA dyXWflcetgrFz0YfkAKX/TtPanLzkNtQE/Oa1nGfDCUxgqIgEBeR0Iex/9PXI4Sn6vo8 QnzQ== X-Gm-Message-State: AO0yUKUWkKwgc429yPiF6YL5HsErge7kDj3aXuNppdUrliKV2tBeXf+l 20cAo2h6YWbJ+riA/bHWTSSzMA== X-Google-Smtp-Source: AK7set9r5JvDlFpIeEUd53I17Q/B4EYvL7veOcmQTkCtu+ePA29VXdWDfQYuGmavqCxH8d9uQH4avA== X-Received: by 2002:a05:6214:625:b0:56e:f9a2:1aff with SMTP id a5-20020a056214062500b0056ef9a21affmr2506398qvx.35.1676912070400; Mon, 20 Feb 2023 08:54:30 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-8f08-76c2-2eb2-d6bf.res6.spectrum.com. [2603:6081:7b00:6400:8f08:76c2:2eb2:d6bf]) by smtp.gmail.com with ESMTPSA id b187-20020ae9ebc4000000b0073ba44fd6a2sm946236qkg.1.2023.02.20.08.54.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 08:54:30 -0800 (PST) Date: Mon, 20 Feb 2023 11:54:28 -0500 From: Tom Rini To: Samuel Holland , nm@ti.com Cc: u-boot@lists.denx.de Subject: Re: [PATCH 2/3] remoteproc: Remove unused mem_type platform data Message-ID: References: <20230220061304.43198-1-samuel@sholland.org> <20230220061304.43198-3-samuel@sholland.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jCs4QidQakUnl8jW" Content-Disposition: inline In-Reply-To: <20230220061304.43198-3-samuel@sholland.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --jCs4QidQakUnl8jW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 20, 2023 at 12:13:02AM -0600, Samuel Holland wrote: > There is only one possible value for this field, it is unused except for > debugging, and the devicetree property is not documented. >=20 > Signed-off-by: Samuel Holland > --- >=20 > cmd/remoteproc.c | 12 +----------- > doc/develop/driver-model/remoteproc-framework.rst | 1 - > drivers/remoteproc/rproc-uclass.c | 7 ------- > drivers/remoteproc/sandbox_testproc.c | 1 - > include/remoteproc.h | 15 --------------- > 5 files changed, 1 insertion(+), 35 deletions(-) >=20 > diff --git a/cmd/remoteproc.c b/cmd/remoteproc.c > index ca3b436242a..2b2e52e7d3e 100644 > --- a/cmd/remoteproc.c > +++ b/cmd/remoteproc.c > @@ -20,7 +20,6 @@ static int print_remoteproc_list(void) > struct udevice *dev; > struct uclass *uc; > int ret; > - char *type; > =20 > ret =3D uclass_get(UCLASS_REMOTEPROC, &uc); > if (ret) { > @@ -38,18 +37,9 @@ static int print_remoteproc_list(void) > if (!(dev_get_flags(dev) & DM_FLAG_ACTIVATED)) > continue; > =20 > - switch (uc_pdata->mem_type) { > - case RPROC_INTERNAL_MEMORY_MAPPED: > - type =3D "internal memory mapped"; > - break; > - default: > - type =3D "unknown"; > - break; > - } > - printf("%d - Name:'%s' type:'%s' supports: %s%s%s%s%s%s\n", > + printf("%d - Name:'%s' supports: %s%s%s%s%s%s\n", > dev_seq(dev), > uc_pdata->name, > - type, > ops->load ? "load " : "", > ops->start ? "start " : "", > ops->stop ? "stop " : "", > diff --git a/doc/develop/driver-model/remoteproc-framework.rst b/doc/deve= lop/driver-model/remoteproc-framework.rst > index 566495a21c4..bdbbb8ab7be 100644 > --- a/doc/develop/driver-model/remoteproc-framework.rst > +++ b/doc/develop/driver-model/remoteproc-framework.rst > @@ -121,7 +121,6 @@ a simplified definition of a device is as follows: > =20 > struct dm_rproc_uclass_pdata proc_3_test =3D { > .name =3D "proc_3_legacy", > - .mem_type =3D RPROC_INTERNAL_MEMORY_MAPPED, > .driver_plat_data =3D &mydriver_data; > }; > =20 > diff --git a/drivers/remoteproc/rproc-uclass.c b/drivers/remoteproc/rproc= -uclass.c > index 50bcc9030e9..3eacd4a8d9b 100644 > --- a/drivers/remoteproc/rproc-uclass.c > +++ b/drivers/remoteproc/rproc-uclass.c > @@ -136,12 +136,6 @@ static int rproc_pre_probe(struct udevice *dev) > bool tmp; > debug("'%s': using fdt\n", dev->name); > uc_pdata->name =3D dev_read_string(dev, "remoteproc-name"); > - > - /* Default is internal memory mapped */ > - uc_pdata->mem_type =3D RPROC_INTERNAL_MEMORY_MAPPED; > - tmp =3D dev_read_bool(dev, "remoteproc-internal-memory-mapped"); > - if (tmp) > - uc_pdata->mem_type =3D RPROC_INTERNAL_MEMORY_MAPPED; > #else > /* Nothing much we can do about this, can we? */ > return -EINVAL; > @@ -153,7 +147,6 @@ static int rproc_pre_probe(struct udevice *dev) > debug("'%s': using legacy data\n", dev->name); > if (pdata->name) > uc_pdata->name =3D pdata->name; > - uc_pdata->mem_type =3D pdata->mem_type; > uc_pdata->driver_plat_data =3D pdata->driver_plat_data; > } > =20 > diff --git a/drivers/remoteproc/sandbox_testproc.c b/drivers/remoteproc/s= andbox_testproc.c > index 78b108184bb..4cb784ce32e 100644 > --- a/drivers/remoteproc/sandbox_testproc.c > +++ b/drivers/remoteproc/sandbox_testproc.c > @@ -349,7 +349,6 @@ U_BOOT_DRIVER(sandbox_testproc) =3D { > /* TODO(nm@ti.com): Remove this along with non-DT support */ > static struct dm_rproc_uclass_pdata proc_3_test =3D { > .name =3D "proc_3_legacy", > - .mem_type =3D RPROC_INTERNAL_MEMORY_MAPPED, > }; > =20 > U_BOOT_DRVINFO(proc_3_demo) =3D { > diff --git a/include/remoteproc.h b/include/remoteproc.h > index d8cde73748b..0c4d64706d9 100644 > --- a/include/remoteproc.h > +++ b/include/remoteproc.h > @@ -383,23 +383,9 @@ struct rproc { > u32 trace_len; > }; > =20 > -/** > - * enum rproc_mem_type - What type of memory model does the rproc use > - * @RPROC_INTERNAL_MEMORY_MAPPED: Remote processor uses own memory and i= s memory > - * mapped to the host processor over an address range. > - * > - * Please note that this is an enumeration of memory model of different = types > - * of remote processors. Few of the remote processors do have own intern= al > - * memories, while others use external memory for instruction and data. > - */ > -enum rproc_mem_type { > - RPROC_INTERNAL_MEMORY_MAPPED =3D 0, > -}; > - > /** > * struct dm_rproc_uclass_pdata - platform data for a CPU > * @name: Platform-specific way of naming the Remote proc > - * @mem_type: one of 'enum rproc_mem_type' > * @driver_plat_data: driver specific platform data that may be needed. > * > * This can be accessed with dev_get_uclass_plat() for any UCLASS_REMOTE= PROC > @@ -408,7 +394,6 @@ enum rproc_mem_type { > */ > struct dm_rproc_uclass_pdata { > const char *name; > - enum rproc_mem_type mem_type; > void *driver_plat_data; > }; > =20 Adding Nishanth, since he knows the TI remoteproc stuff. --=20 Tom --jCs4QidQakUnl8jW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPzpcEACgkQFHw5/5Y0 tyyNyAwAszIw3rwKEkTL6pnUNlONR1ZNX/kByVzu/4coN446sLvv1wWp2Hw+kjQD JvBy8IA0xOJfKfiOwc6j06svZDkLiggBRB6I/z0FQG2Ej/8P5sE8KrAPuXQd1iM/ pMtosL+v2qtrj2LeR3507CirRJSutGWgN2Gab230Ll/8YhyTg3TLGZDIsDCcbJg7 CwwqqxJRw9IsQfaDZv45JuQ+Cp4lpkR7bEbA924xlrUMbfbJNcSIdXI6ICW9JBmi /CMbEGFnU2bxaI6L7XZbjRT1VPpg5H1+rIADUHmMSXN9M2BxIXeumbPjFx3Bhhms 9leMXhiSrpjZ4/avK6QICWND1zqvn4zF+cmehyNQnDE1HTezWe7sratsEKMobEQI YmiV7SK95LuBFgdVXelP8QQfF8USoakVy3pk9gGYnAUMgaycWQd6LQrNuNMLSj/7 fjSLwGaH2HYDgIAtOVyPZkDgONsBcX6lVwkTPgHPOr+YBNF7DOgYnoFgofmImrB3 1B4LZPlp =wQaF -----END PGP SIGNATURE----- --jCs4QidQakUnl8jW--