From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1FB8C636D7 for ; Tue, 21 Feb 2023 23:02:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5D54D8590C; Wed, 22 Feb 2023 00:02:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="E49hBKMq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D151780AE2; Wed, 22 Feb 2023 00:02:37 +0100 (CET) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EB88C85A55 for ; Wed, 22 Feb 2023 00:02:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x830.google.com with SMTP id w42so6076320qtc.2 for ; Tue, 21 Feb 2023 15:02:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=80zKMvgXW9Z3FWvPX6H9ui/RSGZ3JzcD8wJy61nGOvY=; b=E49hBKMqlaFA7YrQktO7C/gNuL+PPsvdy+XjVnqxWjNqEmKI1gRCFPIE2BeDVO6gpK D08dWKgmwXZVAXk7vVrNs7FeoYUGk94lEPOijEE5IKocL4m76+y0NCrq9XQyuJoYl+sA IEy0CW2diB99J/hyAdIzP9KLQHBalnHTzZMv0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=80zKMvgXW9Z3FWvPX6H9ui/RSGZ3JzcD8wJy61nGOvY=; b=xvNbQIrxSB2lctQRK2r7CsVgYtVYW8nvphcLB3TeuSryqCKkA104zdbxTPOQXxG/Ef 4hlic7qT7cQIzBLZsnwgRqpSBlkDVARtNz4iNA4QQuV8vHyUfMSMwCSQlqgESreAvpZz HfhzmWLs9JtS2ahmmAkDM/S9noMERX7i1mrtnaomsrimVgBefYENhgYlXieG6U3vlCuk D3Ge0mpfc1Rq5PMlV8BuzOfHhVVtB9M+inmB7ctbhYV3sm1uX1OVXqZoXmcWKjPWhyXZ zJj4mx6vfwMbbX5lH8Jo7MWsoP450pPaNnerP+YMcoKUZf37LDHnRjCWP+m5lpNIJ9kS AP5g== X-Gm-Message-State: AO0yUKW+b9oMBiA3i3nqiP3mWVna9S9kmygiAfcsxAm1syx9x5yLaccN 9FTlv5ubGMYcyvDe8Dn9MnqvOP58i8lJI3xG1fw= X-Google-Smtp-Source: AK7set+IimbOD+nLedhCvttrDEv0vprrkMg/WHnuH9dzLERBRWS6/I4VOWm74mM6UV3iW8BU003YZA== X-Received: by 2002:ac8:57d2:0:b0:3b6:93fe:443c with SMTP id w18-20020ac857d2000000b003b693fe443cmr27444074qta.32.1677020553657; Tue, 21 Feb 2023 15:02:33 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0ab3-6707-0dcf-7989.res6.spectrum.com. [2603:6081:7b00:6400:ab3:6707:dcf:7989]) by smtp.gmail.com with ESMTPSA id s62-20020ae9de41000000b0074235386738sm204025qkf.37.2023.02.21.15.02.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 15:02:33 -0800 (PST) Date: Tue, 21 Feb 2023 18:02:31 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List Subject: Re: [PATCH v3 11/95] Correct SPL use of PHY_CADENCE_SIERRA Message-ID: References: <20230212231638.1134219-1-sjg@chromium.org> <20230212231638.1134219-12-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PPMRNribNend0vrM" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --PPMRNribNend0vrM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 21, 2023 at 12:35:41PM -0700, Simon Glass wrote: > Hi Tom, >=20 > On Tue, 14 Feb 2023 at 09:31, Tom Rini wrote: > > > > On Sun, Feb 12, 2023 at 04:15:14PM -0700, Simon Glass wrote: > > > This converts 1 usage of this option to the non-SPL form, since there= is > > > no SPL_PHY_CADENCE_SIERRA defined in Kconfig > > > > > > Signed-off-by: Simon Glass > > > --- > > > > > > (no changes since v1) > > > > > > drivers/phy/cadence/Makefile | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/phy/cadence/Makefile b/drivers/phy/cadence/Makef= ile > > > index af63b32d9f5..c247feb8262 100644 > > > --- a/drivers/phy/cadence/Makefile > > > +++ b/drivers/phy/cadence/Makefile > > > @@ -1,2 +1,2 @@ > > > -obj-$(CONFIG_$(SPL_)PHY_CADENCE_SIERRA) +=3D phy-cadence-sierra= =2Eo > > > +obj-$(CONFIG_PHY_CADENCE_SIERRA) +=3D phy-cadence-sierra.o > > > obj-$(CONFIG_$(SPL_)PHY_CADENCE_TORRENT) +=3D phy-cadence-torrent.o > > > > This, and then PHY_CADENCE_TORRENT take this the wrong direction, both > > symbols should be false for non-PPL builds. >=20 > This one is odd, since the board defines SPL_PHY, presumably for a > reason. It could always undefine that if needed. >=20 > I'll add some more notes in v5. The platforms in question are fairly complex and I want to say it needs a PHY for USB in SPL, but not a PHY for networking, in SPL. --=20 Tom --PPMRNribNend0vrM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmP1TX0ACgkQFHw5/5Y0 tyxFrAwAulcwpVACd6SKvDvj3Rhe42I0lpZrvNJrXESESF0yTb2SOE7TlaSOJlZH eZMuPP6mT2n+S9OLGR9x4dfkPuGoWa+jmky51cRFM2ig4we9ED98CvEczYsLiwjq fY7zlTY8Ahn3gM5d5vRSLtPw7HJUyLjguJ/mzV/a4vWixfkRaurdEUm3cfpYu0PD UodhZTVXnhsM51zxaQKUqziCEN8Pv4C+8NkerQt09ZwnM//qewY3EMBN854KmC5r 3dpIXo0StUGGMIOuZAj5TNA6QOIllV1k0OyiB75FtYn7nP2Uly4XwBt7cYboC7Fq cZEs6m7HnFoIZf47pF4TodO6cyRtIq88n9vGRKoPWj5HkFGMz1VToWh7TDQLJOHN D2w+xOWyL6Dd258yNOHBCqNrl8xEt7WWEZZMrjoGD4RNIzlWvDhvtJu5CrlEv/qs X8TqPpshGAW6og/VCdHHW2ZB/GYJfqZ1gT4R48Dxbz0G6UnejY0QNoRYK5XGc/dy wkbtowmy =AEgo -----END PGP SIGNATURE----- --PPMRNribNend0vrM--