From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC91FC61DA3 for ; Tue, 21 Feb 2023 23:09:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EC6A1859B3; Wed, 22 Feb 2023 00:09:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="G8VhzxBs"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 16497859FF; Wed, 22 Feb 2023 00:09:47 +0100 (CET) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 573B285917 for ; Wed, 22 Feb 2023 00:09:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82c.google.com with SMTP id x1so6791828qtw.3 for ; Tue, 21 Feb 2023 15:09:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9KZuMjYp36fL/3zjTSfb1waQf/ChrfibY3FbrUD4zjA=; b=G8VhzxBsamAYIyqZUxGdS5ByClyfDDJXbkzGU/G7ProPO0R5wzP5fMVrRUloG57d2n s0iBiHBbmv1owhnlWYHyoBgwDSnh2DDRpjgdgb7w+sa58Os+yd3jYPgxM9atxeD5FKg7 kstzDVAcWRCDMliYO2yrAXaGBxtIVPIu7XV04= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9KZuMjYp36fL/3zjTSfb1waQf/ChrfibY3FbrUD4zjA=; b=ZqS7P9IBxwsaOwmcigWS0Cz+FUAxGKjyxPxp1rlvRKsIcv9dDxeksxFMP3xmjQ6tIj bBlf5wnx1eNZ+w7DSJcW2QIhq5gzTQaJeJbTr1eymrCuaV2vDBF+XLwi3qTetAkPnOPp xB0OXXFYOvbcTH47X7q0DozkWgwYR7jjEkEExUyIcg0EHGMy0xVPFoRNhdkD2MCAsFOv nxyVMPM8SiwFODndYJ6hb4yC/pjxrLFK7l8dF4LXyWXIraj/Us9QRDi8+2Qq6VKG7Bd+ DsjqsdZUI51WLzV8FEFCSxv7GOQnljEl1mBkzGE2hpBqgcc9qVYkmKtnmcZckeELmamn t8Vw== X-Gm-Message-State: AO0yUKX0TWDfaP8JxKJuykIKzqbk60WR10z70rbiiyB0B1vW/Y4qhc4S 7VT8d6pCCJSpYQSLoZHq6fP8PQ== X-Google-Smtp-Source: AK7set+g2to/Z1FjJCCHfmoehx/omEhQNx4IncLhCn+PKdO6KeP4sM2CGOwWdy0rJLuQ9IoCj/0lwA== X-Received: by 2002:ac8:4e46:0:b0:3b8:6bef:61c5 with SMTP id e6-20020ac84e46000000b003b86bef61c5mr12458083qtw.63.1677020983073; Tue, 21 Feb 2023 15:09:43 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0ab3-6707-0dcf-7989.res6.spectrum.com. [2603:6081:7b00:6400:ab3:6707:dcf:7989]) by smtp.gmail.com with ESMTPSA id f13-20020ac87f0d000000b003bd0d04bf1esm3033025qtk.90.2023.02.21.15.09.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 15:09:42 -0800 (PST) Date: Tue, 21 Feb 2023 18:09:40 -0500 From: Tom Rini To: Simon Glass Cc: Jonas Karlman , Alper Nebi Yasak , Pali =?iso-8859-1?Q?Roh=E1r?= , Heinrich Schuchardt , Marek =?iso-8859-1?Q?Beh=FAn?= , Quentin Schulz , Stefan Herbrechtsmeier , u-boot@lists.denx.de Subject: Re: [PATCH 9/9] Makefile: Show binman missing blob message Message-ID: References: <20230219220158.4160763-1-jonas@kwiboo.se> <20230219220158.4160763-10-jonas@kwiboo.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bYxcLFYh6lmueu1f" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --bYxcLFYh6lmueu1f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 21, 2023 at 12:41:52PM -0700, Simon Glass wrote: > Hi Jonas >=20 > +Tom Rini >=20 > On Sun, 19 Feb 2023 at 15:02, Jonas Karlman wrote: > > > > When binman is invoked during a build of U-Boot and an external blob is > > missing, the user is usually presented with a generic file not found in > > input path message. > > > > Invoke binman with --allow-missing so that binman can show relevant > > missing blob help messages. Build continue to fail with missing blobs > > unless BINMAN_ALLOW_MISSING=3D1 is used. > > > > This changes the following error message: > > > > binman: Filename 'atf-bl31' not found in input path (...) > > > > to the following: > > > > Image 'itb' is missing external blobs and is non-functional: atf-blob > > > > /binman/itb/fit/images/atf/atf-blob (bl31.bin): > > See the documentation for your board. You may need to build ARM Tr= usted > > Firmware and build with BL31=3D/path/to/bl31.bin > > > > Signed-off-by: Jonas Karlman > > --- > > Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Makefile b/Makefile > > index 58f8c7a35335..c2860824f6f2 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -1326,7 +1326,7 @@ cmd_binman =3D $(srctree)/tools/binman/binman $(i= f $(BINMAN_DEBUG),-D) \ > > --toolpath $(objtree)/tools \ > > $(if $(BINMAN_VERBOSE),-v$(BINMAN_VERBOSE)) \ > > build -u -d u-boot.dtb -O . -m \ > > - $(if $(BINMAN_ALLOW_MISSING),--allow-missing --ignore-m= issing) \ > > + --allow-missing $(if $(BINMAN_ALLOW_MISSING),--ignore-m= issing) \ > > -I . -I $(srctree) -I $(srctree)/board/$(BOARDDIR) \ > > -I arch/$(ARCH)/dts -a of-list=3D$(CONFIG_OF_LIST) \ > > $(foreach f,$(BINMAN_INDIRS),-I $(f)) \ > > -- > > 2.39.2 > > >=20 > I agree this is better, but we should see what Tom thinks. >=20 > Reviewed-by: Simon Glass This sounds like a binman bug. We shouldn't need to say --allow-missing to then make use of the missing-msg node. --=20 Tom --bYxcLFYh6lmueu1f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmP1TzQACgkQFHw5/5Y0 tyxQYAv/c7x2PLUj8GdgUwnUU1bltRE2/1alF69JdtYaEn0WKof2gbGnBTIZkoYU 4zEmz/fOm/Oeu8jDVqZaUVHWpAHDmiRVMrdzbSmIxyPeDMEePAEqqVjf286irGzS rhcd6R97u3iEjqMIOALc3NsJkpv5iewWw9+visAKjqITuTlYLYiRQVRLnCP4JTBH mAyIKGnAdFkhJ1XFwH0LNQC0RMtxdlwkaca0tcyq6DIoea+HuToqBuwes1l3RHRq h01xq4F+EllEpZs/ZVu4mqhPLGDK1Ag9oT4leTxNz3xvhyOwYW01kmmKK67lE6xH bmPxv8yPf4wVfa+v0ne02I+YmXFQf57Qt0+AjewMwNiHwypGjxNrlnxEa/LCMHZP 6i+g4LFBoizVyh6fVS1v2nJHvxbDR4E+p/dW0fMDXsrlaGfwNawTZCyXLQ+ticQh MKbL5rJ3YI/gy5iUUDub2/5c3OOxiBkP5z8JmwiUNUks/XX1YJVnUCIYowjroisY pqy0HvZe =7pUO -----END PGP SIGNATURE----- --bYxcLFYh6lmueu1f--