Re: [PATCH 9/9] Makefile: Show binman missing blob message

Simon Glass
2023-02-21T19:42:50Z

Hi Jonas

+Tom Rini

On Sun, 19 Feb 2023 at 15:02, Jonas Karlman <jonas@kwiboo.se> wrote:
>
> When binman is invoked during a build of U-Boot and an external blob is
> missing, the user is usually presented with a generic file not found in
> input path message.
>
> Invoke binman with --allow-missing so that binman can show relevant
> missing blob help messages. Build continue to fail with missing blobs
> unless BINMAN_ALLOW_MISSING=1 is used.
>
> This changes the following error message:
>
> binman: Filename 'atf-bl31' not found in input path (...)
>
> to the following:
>
> Image 'itb' is missing external blobs and is non-functional: atf-blob
>
> /binman/itb/fit/images/atf/atf-blob (bl31.bin):
> See the documentation for your board. You may need to build ARM Trusted
> Firmware and build with BL31=/path/to/bl31.bin
>
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 58f8c7a35335..c2860824f6f2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1326,7 +1326,7 @@ cmd_binman = $(srctree)/tools/binman/binman $(if $(BINMAN_DEBUG),-D) \
> --toolpath $(objtree)/tools \
> $(if $(BINMAN_VERBOSE),-v$(BINMAN_VERBOSE)) \
> build -u -d u-boot.dtb -O . -m \
> - $(if $(BINMAN_ALLOW_MISSING),--allow-missing --ignore-missing) \
> + --allow-missing $(if $(BINMAN_ALLOW_MISSING),--ignore-missing) \
> -I . -I $(srctree) -I $(srctree)/board/$(BOARDDIR) \
> -I arch/$(ARCH)/dts -a of-list=$(CONFIG_OF_LIST) \
> $(foreach f,$(BINMAN_INDIRS),-I $(f)) \
> --
> 2.39.2
>

I agree this is better, but we should see what Tom thinks.

Reviewed-by: Simon Glass <sjg@chromium.org>

Regards,
Simon