Re: [PATCH 6/9] binman: Mark mkimage entry missing when its subnodes is missing

Simon Glass
2023-02-21T19:43:56Z

On Sun, 19 Feb 2023 at 15:02, Jonas Karlman <jonas@kwiboo.se> wrote:
>
> Using the mkimage entry with the multiple-data-files prop and having a
> missing external blob result in an unexpected ValueError exception using
> the --allow-missing flag.
>
> ValueError: Filename 'missing.bin' not found in input path (...)
>
> Fix this by using _pathname that is resolved by ObtainContents for blob
> entries, ObtainContents also handles allow missing for external blobs.
>
> Mark mkimage entry as missing and return without running mkimage when
> missing entries is reported by CheckMissing.
>
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> ---
> tools/binman/etype/mkimage.py | 10 +++++++++-
> tools/binman/ftest.py | 9 +++++++++
> .../test/278_mkimage_missing_multiple.dts | 19 +++++++++++++++++++
> 3 files changed, 37 insertions(+), 1 deletion(-)
> create mode 100644 tools/binman/test/278_mkimage_missing_multiple.dts
>

Reviewed-by: Simon Glass <sjg@chromium.org>