From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7AB70C61DA4 for ; Wed, 22 Feb 2023 21:45:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3E2A385630; Wed, 22 Feb 2023 22:45:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="KxOMEhw/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CE5E185630; Wed, 22 Feb 2023 22:45:17 +0100 (CET) Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8437A80ADF for ; Wed, 22 Feb 2023 22:45:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2e.google.com with SMTP id f1so10489722qvx.13 for ; Wed, 22 Feb 2023 13:45:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Npg7YI2tBrq7WVwkd1RGY4MCxR3jvWjn9cuQ0UgHrN0=; b=KxOMEhw/H4vRF8mIAH/JcBD3D79oJ8kYCVbDI1HqY9oJ3Xid63uQY1xiFSwZ0f6856 AYIZGkKBsXZubTYviNce4s30dOZnC8GlXLjDWjwDp3jgQ32LoXwIb4AriKylVHZCcaq3 Qd4X5bpkgSnD/VmglbyKhdnPF43dW74XLI7Sk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Npg7YI2tBrq7WVwkd1RGY4MCxR3jvWjn9cuQ0UgHrN0=; b=T2SzDvgMv3o3Ie+7sBO5agDb7e9LTFsgaDdZc/L7EEM5jsmWvS/LtaMJrOtDahOWsq MCAiqSQ87AxxFLW71j8LpSu2tnBQfU5Cn8i4+Hv99bP0EaM3fl8Kc+OHK4kB+bct3ZEQ /o8jQaihabsvZbYLv02x9tWinuXkcqR5YOBk/JIAdAInEgHjk9Brxm2NZf6SuYLZZEfh Gj5dOFccifIuTBztLL/aV8VmqJ3ojBjWeSKGDOdRb4tYLE/Uh1N57cL6JKXL3qRCbxfp 78PDWuGYy6dCRFvtUCoZgCvt6Tm5SX3z1s7KCHXVqtHZJDh3NSh1ukl8qbwO2X3l3eiR KpVA== X-Gm-Message-State: AO0yUKXwa4SJMALYM6O6ob9DmdC+Tu7kMYrYNiS0uawmQ0hlkBIaJ6AZ H2HXYrrKsEypW3bj7/LY0jbq2g== X-Google-Smtp-Source: AK7set+3VHz1IIA/z1xSkFepznn44ZBisgSM6or1W+HFzgbcswk9tOXCt8IVc455At58X7DNSD3/Rw== X-Received: by 2002:ad4:576a:0:b0:56f:5466:20d4 with SMTP id r10-20020ad4576a000000b0056f546620d4mr15083929qvx.16.1677102313272; Wed, 22 Feb 2023 13:45:13 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-b87e-a945-7631-50d9.res6.spectrum.com. [2603:6081:7b00:6400:b87e:a945:7631:50d9]) by smtp.gmail.com with ESMTPSA id 80-20020a370553000000b0074235745fdasm1966031qkf.58.2023.02.22.13.45.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 13:45:12 -0800 (PST) Date: Wed, 22 Feb 2023 16:45:10 -0500 From: Tom Rini To: Simon Glass Cc: Jonas Karlman , Alper Nebi Yasak , Pali =?iso-8859-1?Q?Roh=E1r?= , Heinrich Schuchardt , Marek =?iso-8859-1?Q?Beh=FAn?= , Quentin Schulz , Stefan Herbrechtsmeier , u-boot@lists.denx.de Subject: Re: [PATCH 9/9] Makefile: Show binman missing blob message Message-ID: References: <20230219220158.4160763-1-jonas@kwiboo.se> <20230219220158.4160763-10-jonas@kwiboo.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6BJ4ifzd9CV0ePop" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --6BJ4ifzd9CV0ePop Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 22, 2023 at 02:20:08PM -0700, Simon Glass wrote: > Hi Tom, >=20 > On Tue, 21 Feb 2023 at 16:09, Tom Rini wrote: > > > > On Tue, Feb 21, 2023 at 12:41:52PM -0700, Simon Glass wrote: > > > Hi Jonas > > > > > > +Tom Rini > > > > > > On Sun, 19 Feb 2023 at 15:02, Jonas Karlman wrote: > > > > > > > > When binman is invoked during a build of U-Boot and an external blo= b is > > > > missing, the user is usually presented with a generic file not foun= d in > > > > input path message. > > > > > > > > Invoke binman with --allow-missing so that binman can show relevant > > > > missing blob help messages. Build continue to fail with missing blo= bs > > > > unless BINMAN_ALLOW_MISSING=3D1 is used. > > > > > > > > This changes the following error message: > > > > > > > > binman: Filename 'atf-bl31' not found in input path (...) > > > > > > > > to the following: > > > > > > > > Image 'itb' is missing external blobs and is non-functional: atf-= blob > > > > > > > > /binman/itb/fit/images/atf/atf-blob (bl31.bin): > > > > See the documentation for your board. You may need to build AR= M Trusted > > > > Firmware and build with BL31=3D/path/to/bl31.bin > > > > > > > > Signed-off-by: Jonas Karlman > > > > --- > > > > Makefile | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/Makefile b/Makefile > > > > index 58f8c7a35335..c2860824f6f2 100644 > > > > --- a/Makefile > > > > +++ b/Makefile > > > > @@ -1326,7 +1326,7 @@ cmd_binman =3D $(srctree)/tools/binman/binman= $(if $(BINMAN_DEBUG),-D) \ > > > > --toolpath $(objtree)/tools \ > > > > $(if $(BINMAN_VERBOSE),-v$(BINMAN_VERBOSE)) \ > > > > build -u -d u-boot.dtb -O . -m \ > > > > - $(if $(BINMAN_ALLOW_MISSING),--allow-missing --igno= re-missing) \ > > > > + --allow-missing $(if $(BINMAN_ALLOW_MISSING),--igno= re-missing) \ > > > > -I . -I $(srctree) -I $(srctree)/board/$(BOARDDIR) \ > > > > -I arch/$(ARCH)/dts -a of-list=3D$(CONFIG_OF_LIST) \ > > > > $(foreach f,$(BINMAN_INDIRS),-I $(f)) \ > > > > -- > > > > 2.39.2 > > > > > > > > > > I agree this is better, but we should see what Tom thinks. > > > > > > Reviewed-by: Simon Glass > > > > This sounds like a binman bug. We shouldn't need to say --allow-missing > > to then make use of the missing-msg node. >=20 > Without --allow-missing binman just dies when it cannot find > something. This is useful because it allows debugging of problems. >=20 > I'm not sure how easy it would be to change this. The error is > reported by the tools module which has no knowledge of binman. We > could catch the exception, but again that makes things non-debuggable. Why wouldn't it be debuggable? Wouldn't it be more debuggable now that we're saying "You're missing foo.blob, this is typically provided by the foo project", which we can just say because the message has been filled out already in the etype. > At the moment we have two cases: > - normal: missing files cause an immediate abort > - --allow-missing: missing files are collected with a report at the end >=20 > Worse, we can have missing tools, not just missing blobs. The > complexity of this gets completely out of hand if we try to meld the > normal and --allow-missing cases together. >=20 > I actually don't see much of a downside to passing allow-missing > always. But perhaps the BINMAN_ALLOW_MISSING should be renamed to > BINMAN_IGNORE_MISSING (with a similar change in buildman). We could > actually keep BINMAN_ALLOW_MISSING to mean to pass --allow-missing, > pointing out in the docs that this is a bad idea as you won't see any > blob help? Maybe the problem is the flag is badly named? I still think this speaks to bugs in the tooling if we can't make use of the helpful error message that we have available without some special flags to be set. --=20 Tom --6BJ4ifzd9CV0ePop Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmP2jN8ACgkQFHw5/5Y0 tyyc8gv9EinDHSc2ZTgYBI4De2BKdJ7MeUZrlGq2jGJK04ZI/dMwfPNGtE2/M0GP xaXGUDqZgCupT/Tc+mRKE13xITUyh3TcWp1SpgTJxDWDUk7YUWaqhn/8KMtVxI8i uz8j2lRcHkUCcGAVAf+wGTkGAqsEgLMpkWMmUahcnSx0MfqZwCz97YNIZmiZX6iM LuBLopeFWz1003vW1rnO3/DvwNqjCkaGfUtTjRdkg/FL4501KYwjHgNRxbyZSnD2 gYRRHmMkwoDt65qu/8ODjQq/KdfjAQrqby6zCjkfM88k9wAmPUdMgtiKeM+GZyer t11J8QID/GhLMb+S5MVE7tXK5AoePnt+g7tUvJIyjaF4c4H5R3Ud4ah1N9juqO7R NFwtLszj8SecznoDE8EPAtqa9tIm2UmOGj+cuIRLQnr6EoFmzxdd7dtbcvSa0MIe LMw+TpneTqH2faj6+Ygs7fzU/Br3YRyb0Z3DI4Ay0uUbNOfJ1JFeOe93rn2WCLBN 0WQpWDGd =iiiE -----END PGP SIGNATURE----- --6BJ4ifzd9CV0ePop--