From: Tom Rini <trini@konsulko.com>
To: Troy Kisky <troykiskyboundary@gmail.com>
Cc: sjg@chromium.org, u-boot@lists.denx.de,
gary.bisson@lairdconnect.com, Fabio Estevam <festevam@gmail.com>,
"NXP i.MX U-Boot Team" <uboot-imx@nxp.com>,
Stefano Babic <sbabic@denx.de>
Subject: Re: [PATCH v1 19/24] arm: mach-imx: use CONFIG_$(SPL_)SATA instead of CONFIG_SATA
Date: Thu, 23 Feb 2023 17:20:05 -0500 [thread overview]
Message-ID: <Y/fmlffAqu63O8E2@bill-the-cat> (raw)
In-Reply-To: <CAO46J5Vwx9idwRacW8e+EvdTK9maZSuorWaqmo1w=Ts0xL27Nw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1761 bytes --]
On Thu, Feb 23, 2023 at 11:23:47AM -0800, Troy Kisky wrote:
> On Wed, Feb 22, 2023 at 7:05 AM Tom Rini <trini@konsulko.com> wrote:
>
> > On Tue, Feb 21, 2023 at 05:38:16PM -0800, Troy Kisky wrote:
> >
> > > This avoid an error with enable_sata_clock when
> > > defined(CONFIG_SATA) is changed to CONFIG_IS_ENABLED(SATA).
> > >
> > > Signed-off-by: Troy Kisky <troykiskyboundary@gmail.com>
> > > ---
> > >
> > > arch/arm/mach-imx/Makefile | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile
> > > index 4dfc60eedc4..50f26975eac 100644
> > > --- a/arch/arm/mach-imx/Makefile
> > > +++ b/arch/arm/mach-imx/Makefile
> > > @@ -54,7 +54,7 @@ obj-$(CONFIG_IMX_RDC) += rdc-sema.o
> > > ifneq ($(CONFIG_SPL_BUILD),y)
> > > obj-$(CONFIG_IMX_BOOTAUX) += imx_bootaux.o
> > > endif
> > > -obj-$(CONFIG_SATA) += sata.o
> > > +obj-$(CONFIG_$(SPL_)SATA) += sata.o
> > > obj-$(CONFIG_IMX_HAB) += hab.o
> > > obj-$(CONFIG_SYSCOUNTER_TIMER) += syscounter.o
> > > endif
> >
> > In that Simon thinks the $(SPL_) syntax here is ugly, lets just move
> > this line in to the existing guard for non-SPL builds, with
> > imx_bootaux.o.
> >
> > --
> > Tom
> >
>
> Hi Tom
>
> I don't think that does the same thing for mach-mvebu.
>
> arch/arm/mach-mvebu/Kconfig-config MVEBU_SPL_BOOT_DEVICE_SATA
> arch/arm/mach-mvebu/Kconfig- bool "SATA"
> arch/arm/mach-mvebu/Kconfig: imply SPL_SATA
>
> Shouldn't it be linked in SPL builds as well for that one?
Well, OK. I see there's not yet SPL_SATA functional on imx, but, when
the time comes, that file is likely to be used, so this change make
sense, thanks for explaining.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-02-23 22:20 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 1:37 [PATCH v1 00/24] CONFIG_IS_ENABLED vs IS_ENABLED Troy Kisky
2023-02-22 1:37 ` [PATCH v1 01/24] cmd: nvedit: check for ENV_SUPPORT Troy Kisky
2023-02-22 21:19 ` Simon Glass
2023-02-22 1:37 ` [PATCH v1 02/24] lib: crc32: prepare for CONFIG_IS_ENABLED changes Troy Kisky
2023-02-22 21:19 ` Simon Glass
2023-02-22 1:38 ` [PATCH v1 03/24] lib: md5: " Troy Kisky
2023-02-22 21:19 ` Simon Glass
2023-02-22 1:38 ` [PATCH v1 04/24] lib: sha1: " Troy Kisky
2023-02-22 21:19 ` Simon Glass
2023-02-22 1:38 ` [PATCH v1 05/24] lib: sha256: " Troy Kisky
2023-02-22 21:19 ` Simon Glass
2023-02-22 22:42 ` Troy Kisky
2023-02-22 1:38 ` [PATCH v1 06/24] lib: sha512: " Troy Kisky
2023-02-22 21:19 ` Simon Glass
2023-02-22 1:38 ` [PATCH v1 07/24] tools: prevent CONFIG_IS_ENABLED errors by including linux/kconfig.h Troy Kisky
2023-02-22 21:19 ` Simon Glass
2023-02-22 1:38 ` [PATCH v1 08/24] tools: Makefile: prepare for CONFIG_IS_ENABLED changes by adding CONFIG_TOOLS_xxx Troy Kisky
2023-02-22 21:20 ` Simon Glass
2023-02-22 1:38 ` [PATCH v1 09/24] x86: cpu: qemu: qemu: remove SPL use with CONFIG_IS_ENABLED Troy Kisky
2023-02-22 21:19 ` Simon Glass
2023-02-22 1:38 ` [PATCH v1 10/24] config_distro_bootcmd: remove booting environment variables from SPL environment Troy Kisky
2023-02-22 21:19 ` Simon Glass
2023-02-22 1:38 ` [PATCH v1 11/24] ofnode: fdt_support definitions needed if OF_CONTROL is enabled Troy Kisky
2023-02-22 21:19 ` Simon Glass
2023-02-22 1:38 ` [PATCH v1 12/24] ringneck-px30: remove check for ENV_IS_NOWHERE, it is an SPL config Troy Kisky
2023-02-22 14:45 ` Quentin Schulz
2023-02-22 15:03 ` Tom Rini
2023-02-22 1:38 ` [PATCH v1 13/24] puma-rk3399: " Troy Kisky
2023-02-22 21:19 ` Simon Glass
2023-02-22 1:38 ` [PATCH v1 14/24] fdt_support: always define fdt_fixup_mtdparts Troy Kisky
2023-02-22 21:20 ` Simon Glass
2023-02-22 1:38 ` [PATCH v1 15/24] m53menlo: define ft_board_setup only if CONFIG_IS_ENABLED(OF_LIBFDT) Troy Kisky
2023-02-22 21:20 ` Simon Glass
2023-02-22 1:38 ` [PATCH v1 16/24] freescale: common: pfuze: define pfuze_mode_init only if defined(CONFIG_DM_PMIC) Troy Kisky
2023-02-22 21:20 ` Simon Glass
2023-02-22 1:38 ` [PATCH v1 17/24] ns16550: match when to define bdf with uart code Troy Kisky
2023-02-22 18:18 ` Tom Rini
2023-02-22 18:42 ` Troy Kisky
2023-02-22 19:16 ` Simon Glass
2023-02-22 19:39 ` Troy Kisky
2023-02-22 20:41 ` Troy Kisky
2023-02-22 21:06 ` Troy Kisky
2023-02-22 21:16 ` Simon Glass
2023-02-22 20:56 ` Simon Glass
[not found] ` <CAO46J5WM4yLmbYesfXFeRVYU-7TC=KOPxpBte6=rt9Uh0qF3vw@mail.gmail.com>
[not found] ` <CAPnjgZ1jJuwwZ4FAspkhsxwK5RAQiDxtHDkygvwOOtHVFGFiJQ@mail.gmail.com>
[not found] ` <CAO46J5XsyQpR57-WA6Q==9wkQLsgwJ+qpsJQxnVt4=GZJ+Ysyg@mail.gmail.com>
2023-02-23 2:48 ` Simon Glass
2023-02-22 1:38 ` [PATCH v1 18/24] solidrun: mx6cuboxi: use CONFIG_IS_ENABLED(SATA) instead of CONFIG_CMD_SATA Troy Kisky
2023-02-22 16:59 ` Tom Rini
2023-02-22 18:13 ` Troy Kisky
2023-02-24 1:19 ` Troy Kisky
2023-02-22 1:38 ` [PATCH v1 19/24] arm: mach-imx: use CONFIG_$(SPL_)SATA instead of CONFIG_SATA Troy Kisky
2023-02-22 15:05 ` Tom Rini
2023-02-23 19:23 ` Troy Kisky
2023-02-23 22:20 ` Tom Rini [this message]
2023-02-23 23:07 ` Simon Glass
2023-02-22 1:38 ` [PATCH v1 20/24] x86: cpu: i386: cpu: only set pci_ram_top if CONFIG_IS_ENABLED(PCI) Troy Kisky
2023-02-22 21:20 ` Simon Glass
2023-02-22 1:38 ` [PATCH v1 21/24] gateworks: venice: surround call of setup_fec with if IS_ENABLED(CONFIG_NET) Troy Kisky
2023-02-22 15:07 ` Tom Rini
2023-02-22 1:38 ` [PATCH v1 22/24] power: pmic: add dm style definitions if not CONFIG_IS_ENABLED(POWER_LEGACY) Troy Kisky
2023-02-22 21:20 ` Simon Glass
2023-02-22 1:38 ` [PATCH v1 23/24] arm: cpu: armv7: ls102xa: fdt: remove eth_device support Troy Kisky
2023-02-22 21:20 ` Simon Glass
2023-02-22 1:38 ` [PATCH v1 24/24] CI: add test/usage_of_is_enabled_check.sh Troy Kisky
2023-02-22 21:20 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/fmlffAqu63O8E2@bill-the-cat \
--to=trini@konsulko.com \
--cc=festevam@gmail.com \
--cc=gary.bisson@lairdconnect.com \
--cc=sbabic@denx.de \
--cc=sjg@chromium.org \
--cc=troykiskyboundary@gmail.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox