From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5333C61DA4 for ; Thu, 23 Feb 2023 22:20:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 59BF98551C; Thu, 23 Feb 2023 23:20:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="uugj6y6c"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 472E585648; Thu, 23 Feb 2023 23:20:13 +0100 (CET) Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4D68884EEF for ; Thu, 23 Feb 2023 23:20:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82b.google.com with SMTP id cf14so2529384qtb.10 for ; Thu, 23 Feb 2023 14:20:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TdyoMKh+Sa90nSW5ktc79rJQogy8uFnp5YiN/WODqBg=; b=uugj6y6cUjIevcJpcEjxWCur92a87hd49QL+kvtmIbFQPEjGqdDs2jQ1LMpfnOq9r9 iib7Q+ifoU2NxmnMI3QL+xsglrglrjHv4ZSJS+QrFgRbGB5hV6mdLbOXerR0pSbkfnzp SB1Oln3gmpMa0aG8DuUvY1PIvnXnhMSPUXwK8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TdyoMKh+Sa90nSW5ktc79rJQogy8uFnp5YiN/WODqBg=; b=FfVhfZ4F+c3nE7oBSl61bAhEN5PluHIUhITTEzAhjO61BwBPFjg9YL4kN0IMsXptTO wjrh3IHEzSfYv4DAI1zKEN03/MEgkNzrqHQF7qf1Ht2zRhtN17yLwcCb8e6JC11xykLl 8V/6FRfCPWs1qAOARO3UdTn96veVfATcPdiHFbuhQt76ZRGPybgaf0SDbhYkvwjGfw5d tMuAsw2EGhbDYianQQ3YM6+fJLykQq99/4dploCzEEwZq9BxhcPAswQG6xXmUPzq9gv9 oMv86YdstfOM/AQ+ksh0knuaGNa3QfgSz7L7dy1N3kbYD99ifp/sujfrK3vq248C2Dc6 9y7g== X-Gm-Message-State: AO0yUKURgPZkhz+tsnku3+3xVCAx9+mxBLcB+WcMuoRSb8XgmWTWqler 9f7JVFtxwKE3ozSfGAaathhk4w== X-Google-Smtp-Source: AK7set9ShFX/4AtV+3J9t7LuqjegnCgo/AkJrfNlLQlSUOdZerVPM/qEuAm5W8nleB03maev3KFtPg== X-Received: by 2002:a05:622a:14d:b0:3af:4d45:b73 with SMTP id v13-20020a05622a014d00b003af4d450b73mr21424983qtw.33.1677190808114; Thu, 23 Feb 2023 14:20:08 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-7b76-35a4-b335-d04d.res6.spectrum.com. [2603:6081:7b00:6400:7b76:35a4:b335:d04d]) by smtp.gmail.com with ESMTPSA id z131-20020a376589000000b007186c9e167esm7035922qkb.52.2023.02.23.14.20.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 14:20:07 -0800 (PST) Date: Thu, 23 Feb 2023 17:20:05 -0500 From: Tom Rini To: Troy Kisky Cc: sjg@chromium.org, u-boot@lists.denx.de, gary.bisson@lairdconnect.com, Fabio Estevam , "NXP i.MX U-Boot Team" , Stefano Babic Subject: Re: [PATCH v1 19/24] arm: mach-imx: use CONFIG_$(SPL_)SATA instead of CONFIG_SATA Message-ID: References: <20230222013821.1144691-1-troykiskyboundary@gmail.com> <20230222013821.1144691-20-troykiskyboundary@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0FgcZESE1Jxj7ZXA" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --0FgcZESE1Jxj7ZXA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 23, 2023 at 11:23:47AM -0800, Troy Kisky wrote: > On Wed, Feb 22, 2023 at 7:05 AM Tom Rini wrote: >=20 > > On Tue, Feb 21, 2023 at 05:38:16PM -0800, Troy Kisky wrote: > > > > > This avoid an error with enable_sata_clock when > > > defined(CONFIG_SATA) is changed to CONFIG_IS_ENABLED(SATA). > > > > > > Signed-off-by: Troy Kisky > > > --- > > > > > > arch/arm/mach-imx/Makefile | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile > > > index 4dfc60eedc4..50f26975eac 100644 > > > --- a/arch/arm/mach-imx/Makefile > > > +++ b/arch/arm/mach-imx/Makefile > > > @@ -54,7 +54,7 @@ obj-$(CONFIG_IMX_RDC) +=3D rdc-sema.o > > > ifneq ($(CONFIG_SPL_BUILD),y) > > > obj-$(CONFIG_IMX_BOOTAUX) +=3D imx_bootaux.o > > > endif > > > -obj-$(CONFIG_SATA) +=3D sata.o > > > +obj-$(CONFIG_$(SPL_)SATA) +=3D sata.o > > > obj-$(CONFIG_IMX_HAB) +=3D hab.o > > > obj-$(CONFIG_SYSCOUNTER_TIMER) +=3D syscounter.o > > > endif > > > > In that Simon thinks the $(SPL_) syntax here is ugly, lets just move > > this line in to the existing guard for non-SPL builds, with > > imx_bootaux.o. > > > > -- > > Tom > > >=20 > Hi Tom >=20 > I don't think that does the same thing for mach-mvebu. >=20 > arch/arm/mach-mvebu/Kconfig-config MVEBU_SPL_BOOT_DEVICE_SATA > arch/arm/mach-mvebu/Kconfig- bool "SATA" > arch/arm/mach-mvebu/Kconfig: imply SPL_SATA >=20 > Shouldn't it be linked in SPL builds as well for that one? Well, OK. I see there's not yet SPL_SATA functional on imx, but, when the time comes, that file is likely to be used, so this change make sense, thanks for explaining. --=20 Tom --0FgcZESE1Jxj7ZXA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmP35o4ACgkQFHw5/5Y0 tyzhcQv/WIfWhfagF5+QxcCcuEhLUwEsJ+vKDuAOKy+zmAHiOUt5L3i5GTfPXkch WUqsEKvi1C9JBkvKHBTdZOPTCVSixFiLIOhL98tDN5CVpdfIdtyT2RzmQKAdyX1p J5sVWanO9YflW5KWmcDSbqWvYVkIFSoX1Yj/RClq4n9CB/F0hFtxCpdtK+7F5M0e 0hdoI9caNbMkbtzydCHOLW7QKoYkKOd8Q7VVynL6fGmMbNXtaKdkEFl2HhbCIrQV 17L9ITyvu6RBGGLMPq+AXXcW8mDs06pq9g79ZXjETG4GMZY5ji/s8FHRyYLhWpS+ Z7fzYEb3YTa0AimOuhTRVN+xWgsWuCcn5uJbeJS8UEiwutPp9gPQA2JdzcG0YP7w /Oq5SGQx4U7yDL3JdU66VwjH4pgfR1HcPFjYIqWtOKKEsMJdbnrrAcmDhRwsG+Iu 42GE7D7kb/GQ5Zy7NDM1t3ak45xB+4MNNn+wQdkQt1aOKYVuWHLK5wumUp4rZSiz 3guopT25 =wKvr -----END PGP SIGNATURE----- --0FgcZESE1Jxj7ZXA--