Re: [PATCH v1 18/24] solidrun: mx6cuboxi: use CONFIG_IS_ENABLED(SATA) instead of CONFIG_CMD_SATA

Troy Kisky
2023-02-22T18:14:37Z

On Wed, Feb 22, 2023 at 8:59 AM Tom Rini <trini@konsulko.com> wrote:

> On Tue, Feb 21, 2023 at 05:38:15PM -0800, Troy Kisky wrote:
>
> > setup_sata is linked with
> > obj-$(CONFIG_SATA) += sata.o
> >
> > So use SATA instead of CMD_SATA.
> >
> > Signed-off-by: Troy Kisky <troykiskyboundary@gmail.com>
> > ---
> >
> > board/solidrun/mx6cuboxi/mx6cuboxi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/board/solidrun/mx6cuboxi/mx6cuboxi.c
> b/board/solidrun/mx6cuboxi/mx6cuboxi.c
> > index 7c44379ec4a..e31a7e9552f 100644
> > --- a/board/solidrun/mx6cuboxi/mx6cuboxi.c
> > +++ b/board/solidrun/mx6cuboxi/mx6cuboxi.c
> > @@ -275,7 +275,7 @@ int board_early_init_f(void)
> > {
> > setup_iomux_uart();
> >
> > -#ifdef CONFIG_CMD_SATA
> > +#if CONFIG_IS_ENABLED(SATA)
> > setup_sata();
> > #endif
> > setup_fec();
>
> Note that wandboard needs a similar fix.
>
> --
> Tom
>

Hi Tom

The commit script will change
#ifdef CONFIG_SATA

to
#if CONFIG_IS_ENABLED(SATA)

This series only changes things that the commit script won't.

BR
Troy