Re: [PATCH v1 24/24] CI: add test/usage_of_is_enabled_check.sh

Simon Glass
2023-02-22T21:24:22Z

On Tue, 21 Feb 2023 at 18:39, Troy Kisky <troykiskyboundary@gmail.com> wrote:
>
> Add script usage_of_is_enabled_check to print any configs that
> use CONFIG_IS_ENABLED instead of IS_ENABLED and vice versa.
>
> Add usage_of_is_enabled_commit.sh to generate commits to fix the above
> issues.
>
> You can remove entries from test/usage_of_is_enabled_todo.txt
> or the entire file and then run
> test/usage_of_is_enabled_commit.sh
> to convert to suggested usage of CONFIG_IS_ENABLED/IS_ENABLED
>
> or run test/usage_of_is_enabled_check.sh to
> see which configs are still todo.
>
> Signed-off-by: Troy Kisky <troykiskyboundary@gmail.com>
> ---
>
> .azure-pipelines.yml | 11 ++
> .gitlab-ci.yml | 5 +
> test/usage_of_is_enabled_check.sh | 19 +++
> test/usage_of_is_enabled_commit.sh | 12 ++
> test/usage_of_is_enabled_correct.sh | 50 +++++++
> test/usage_of_is_enabled_exempt.txt | 9 ++
> test/usage_of_is_enabled_list.sh | 86 ++++++++++++
> test/usage_of_is_enabled_splcfg.txt | 21 +++
> test/usage_of_is_enabled_todo.txt | 210 ++++++++++++++++++++++++++++
> 9 files changed, 423 insertions(+)
> create mode 100755 test/usage_of_is_enabled_check.sh
> create mode 100755 test/usage_of_is_enabled_commit.sh
> create mode 100755 test/usage_of_is_enabled_correct.sh
> create mode 100644 test/usage_of_is_enabled_exempt.txt
> create mode 100755 test/usage_of_is_enabled_list.sh
> create mode 100644 test/usage_of_is_enabled_splcfg.txt
> create mode 100644 test/usage_of_is_enabled_todo.txt
>

Reviewed-by: Simon Glass <sjg@chromium.org>