Re: [PATCH v1 12/24] ringneck-px30: remove check for ENV_IS_NOWHERE, it is an SPL config

Quentin Schulz
2023-02-22T14:45:31Z

Hi Troy,

On 2/22/23 02:38, Troy Kisky wrote:
> When IS_ENABLED(CONFIG_ENV_IS_NOWHERE) is converted to
> CONFIG_IS_ENABLED(ENV_IS_NOWHERE) this will give unwanted errors
> on spl builds.
>
> Signed-off-by: Troy Kisky <troykiskyboundary@gmail.com>
> ---
>
> board/theobroma-systems/ringneck_px30/ringneck-px30.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/board/theobroma-systems/ringneck_px30/ringneck-px30.c b/board/theobroma-systems/ringneck_px30/ringneck-px30.c
> index 47d1a40ef7c..bb1bb4acf5c 100644
> --- a/board/theobroma-systems/ringneck_px30/ringneck-px30.c
> +++ b/board/theobroma-systems/ringneck_px30/ringneck-px30.c
> @@ -118,10 +118,6 @@ int mmc_get_env_dev(void)
> return CONFIG_SYS_MMC_ENV_DEV;
> }
>
> -#if !IS_ENABLED(CONFIG_ENV_IS_NOWHERE)
> -#error Please enable CONFIG_ENV_IS_NOWHERE
> -#endif
> -

NACK. We absolutely require CONFIG_ENV_IS_NOWHERE for our SoMs in U-Boot
proper. See the discussion here:
https://lore.kernel.org/u-boot/20220722160655.3904213-8-foss+uboot@0leil.net/,
specifically
https://lore.kernel.org/u-boot/4feb827e-3932-c8d6-120e-5465ad92eac2@theobroma-systems.com/.

We don't have support for SPL environment and don't plan to AFAIK, so I
believe the current implementation is correct and I'd very much like
this check to not be removed.

How are we supposed to handle symbols definition only in U-Boot proper
without this?

Same applies to Puma BTW.

Cheers,
Quentin