Re: [PATCH v1 08/24] tools: Makefile: prepare for CONFIG_IS_ENABLED changes by adding CONFIG_TOOLS_xxx

Simon Glass
2023-02-22T21:23:56Z

Hi Troy,

On Tue, 21 Feb 2023 at 18:38, Troy Kisky <troykiskyboundary@gmail.com> wrote:
>
> CONFIG_IS_ENABLED(FIT_SIGNATURE) will check for
> CONFIG_TOOLS_FIT_SIGNATURE. So define it now in preparation.
>
> Signed-off-by: Troy Kisky <troykiskyboundary@gmail.com>
> ---
>
> tools/Makefile | 2 ++
> 1 file changed, 2 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

>
> diff --git a/tools/Makefile b/tools/Makefile
> index e13effbb66a..2670c77b2cb 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -162,8 +162,10 @@ ifdef CONFIG_TOOLS_LIBCRYPTO
> # This affects include/image.h, but including the board config file
> # is tricky, so manually define this options here.
> HOST_EXTRACFLAGS += -DCONFIG_FIT_SIGNATURE
> +HOST_EXTRACFLAGS += -DCONFIG_TOOLS_FIT_SIGNATURE=1
> HOST_EXTRACFLAGS += -DCONFIG_FIT_SIGNATURE_MAX_SIZE=0xffffffff
> HOST_EXTRACFLAGS += -DCONFIG_FIT_CIPHER
> +HOST_EXTRACFLAGS += -DCONFIG_TOOLS_FIT_CIPHER=1

This makes me wonder whether we should avoid using linux/kconfig.h in
the tools builds? We normally want everything enabled in tools, except
when the host is missing a library iwc we want to avoid a build error.

> endif
>
> # MXSImage needs LibSSL
> --
> 2.34.1
>

Regards,
Simon