Re: [PATCH v1 12/24] ringneck-px30: remove check for ENV_IS_NOWHERE, it is an SPL config

Tom Rini
2023-02-22T15:03:34Z

[-- Attachment #1: Type: text/plain, Size: 1188 bytes --]

On Wed, Feb 22, 2023 at 03:45:17PM +0100, Quentin Schulz wrote:
> Hi Troy,
>
> On 2/22/23 02:38, Troy Kisky wrote:
> > When IS_ENABLED(CONFIG_ENV_IS_NOWHERE) is converted to
> > CONFIG_IS_ENABLED(ENV_IS_NOWHERE) this will give unwanted errors
> > on spl builds.
> >
> > Signed-off-by: Troy Kisky <troykiskyboundary@gmail.com>
> > ---
> >
> > board/theobroma-systems/ringneck_px30/ringneck-px30.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/board/theobroma-systems/ringneck_px30/ringneck-px30.c b/board/theobroma-systems/ringneck_px30/ringneck-px30.c
> > index 47d1a40ef7c..bb1bb4acf5c 100644
> > --- a/board/theobroma-systems/ringneck_px30/ringneck-px30.c
> > +++ b/board/theobroma-systems/ringneck_px30/ringneck-px30.c
> > @@ -118,10 +118,6 @@ int mmc_get_env_dev(void)
> > return CONFIG_SYS_MMC_ENV_DEV;
> > }
> > -#if !IS_ENABLED(CONFIG_ENV_IS_NOWHERE)
> > -#error Please enable CONFIG_ENV_IS_NOWHERE
> > -#endif
> > -
>
> NACK. We absolutely require CONFIG_ENV_IS_NOWHERE for our SoMs in U-Boot

OK, so please select it in the config TARGET_... stanza, and make sure
doc/board/... explains what's going on.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]