[PATCH v2] riscv: binman: Add help message for missing blobs

[PATCH v2] riscv: binman: Add help message for missing blobs

[Rick Chen]

Add the 'missing-msg' for more detailed output
on missing system firmware.

Signed-off-by: Rick Chen <rick@andestech.com>
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
---
Changes in v2
 - Add more descriptions about fw_dynamic.bin
---
 arch/riscv/dts/binman.dtsi     | 1 +
 tools/binman/missing-blob-help | 6 ++++++
 2 files changed, 7 insertions(+)

diff --git a/arch/riscv/dts/binman.dtsi b/arch/riscv/dts/binman.dtsi
index b8fc8f7f35..156cb00971 100644
--- a/arch/riscv/dts/binman.dtsi
+++ b/arch/riscv/dts/binman.dtsi
@@ -45,6 +45,7 @@
 
 					opensbi_blob: opensbi {
 						filename = "fw_dynamic.bin";
+						missing-msg = "opensbi";
 					};
 				};
 
diff --git a/tools/binman/missing-blob-help b/tools/binman/missing-blob-help
index c61ca02a35..4448ac9311 100644
--- a/tools/binman/missing-blob-help
+++ b/tools/binman/missing-blob-help
@@ -37,3 +37,9 @@ https://github.com/siemens/k3-rti-wdt.
 tee-os:
 See the documentation for your board. You may need to build Open Portable
 Trusted Execution Environment (OP-TEE) with TEE=/path/to/tee.bin
+
+opensbi:
+See the documentation for your board. The OpenSBI git repo is at
+https://github.com/riscv/opensbi.git
+You may need to build fw_dynamic.bin first and re-build u-boot with
+OPENSBI=/path/to/fw_dynamic.bin
-- 
2.17.1

Re: [PATCH v2] riscv: binman: Add help message for missing blobs

[Yu-Chien Peter Lin]

On Fri, Feb 17, 2023 at 04:57:01PM +0800, Rick Chen wrote:
> Add the 'missing-msg' for more detailed output
> on missing system firmware.
> 
> Signed-off-by: Rick Chen <rick@andestech.com>
> Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>

Reviewed-by: Yu Chien Peter Lin <peterlin@andestech.com>

> ---
> Changes in v2
>  - Add more descriptions about fw_dynamic.bin
> ---
>  arch/riscv/dts/binman.dtsi     | 1 +
>  tools/binman/missing-blob-help | 6 ++++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/arch/riscv/dts/binman.dtsi b/arch/riscv/dts/binman.dtsi
> index b8fc8f7f35..156cb00971 100644
> --- a/arch/riscv/dts/binman.dtsi
> +++ b/arch/riscv/dts/binman.dtsi
> @@ -45,6 +45,7 @@
>  
>  					opensbi_blob: opensbi {
>  						filename = "fw_dynamic.bin";
> +						missing-msg = "opensbi";
>  					};
>  				};
>  
> diff --git a/tools/binman/missing-blob-help b/tools/binman/missing-blob-help
> index c61ca02a35..4448ac9311 100644
> --- a/tools/binman/missing-blob-help
> +++ b/tools/binman/missing-blob-help
> @@ -37,3 +37,9 @@ https://github.com/siemens/k3-rti-wdt.
>  tee-os:
>  See the documentation for your board. You may need to build Open Portable
>  Trusted Execution Environment (OP-TEE) with TEE=/path/to/tee.bin
> +
> +opensbi:
> +See the documentation for your board. The OpenSBI git repo is at
> +https://github.com/riscv/opensbi.git
> +You may need to build fw_dynamic.bin first and re-build u-boot with
> +OPENSBI=/path/to/fw_dynamic.bin
> -- 
> 2.17.1
> 

Re: [PATCH v2] riscv: binman: Add help message for missing blobs

[Simon Glass]

On Fri, 17 Feb 2023 at 03:25, Yu-Chien Peter Lin <peterlin@andestech.com> wrote:
>
> On Fri, Feb 17, 2023 at 04:57:01PM +0800, Rick Chen wrote:
> > Add the 'missing-msg' for more detailed output
> > on missing system firmware.
> >
> > Signed-off-by: Rick Chen <rick@andestech.com>
> > Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
>
> Reviewed-by: Yu Chien Peter Lin <peterlin@andestech.com>
>
> > ---
> > Changes in v2
> >  - Add more descriptions about fw_dynamic.bin
> > ---
> >  arch/riscv/dts/binman.dtsi     | 1 +
> >  tools/binman/missing-blob-help | 6 ++++++
> >  2 files changed, 7 insertions(+)
> >

Reviewed-by: Simon Glass <sjg@chromium.org>

Thanks