From: Tom Rini <trini@konsulko.com>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Kever Yang <kever.yang@rock-chips.com>,
Simon Glass <sjg@chromium.org>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Jagan Teki <jagan@edgeble.ai>, YouMin Chen <cym@rock-chips.com>,
u-boot@lists.denx.de, Jonas Karlman <jonas@kwiboo.se>
Subject: Re: [PATCH] rockchip: dts: rk3328: fix sdram params
Date: Fri, 17 Feb 2023 13:30:42 -0500 [thread overview]
Message-ID: <Y+/H0jbQHO4dd7SA@bill-the-cat> (raw)
In-Reply-To: <CAMty3ZDPeB=7D1kTcx_iUc=VLmfKXwSohW-jXxs77=11-=3yZw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]
On Fri, Feb 17, 2023 at 11:39:35PM +0530, Jagan Teki wrote:
> Hi Kever and Tom,
>
> On Sat, Feb 11, 2023 at 12:00 AM Jonas Karlman <jonas@kwiboo.se> wrote:
> >
> > The rk3328 sdram driver read sdram parameters from the devicetree into a
> > struct rk3328_sdram_params using dev_read_u32_array.
> >
> > After commit 5ab30c3176bf ("ram: rockchip: Update ddr pctl regs for px30")
> > changed the size of struct ddr_pctl_regs, a member of struct
> > rk3328_sdram_params, U-Boot TPL can no longer initialize DRAM on RK3328.
> >
> > Add ten u32 to the sdram parameter array in devicetree to align with
> > this size change. This fixes DRAM initialization on RK3328.
> >
> > Fixes: 5ab30c3176bf ("ram: rockchip: Update ddr pctl regs for px30")
> > Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> > ---
>
> Can someone merge this soon, rk3328 platform has broken in the last two RCs.
I would really like to see a rockchip PR of fixes at this point, yes. I
believe we'll need one of the TPL/binary-blob related series as well?
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-02-17 18:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 18:30 [PATCH] rockchip: dts: rk3328: fix sdram params Jonas Karlman
2023-02-13 4:27 ` Simon Glass
2023-02-13 6:58 ` Kever Yang
2023-02-17 18:07 ` Jagan Teki
2023-02-17 18:09 ` Jagan Teki
2023-02-17 18:30 ` Tom Rini [this message]
2023-02-22 21:42 ` Vagrant Cascadian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+/H0jbQHO4dd7SA@bill-the-cat \
--to=trini@konsulko.com \
--cc=cym@rock-chips.com \
--cc=jagan@amarulasolutions.com \
--cc=jagan@edgeble.ai \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox