From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37191C636D6 for ; Fri, 17 Feb 2023 18:30:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AE47B85C48; Fri, 17 Feb 2023 19:30:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="bSW9q8uB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CB36985C48; Fri, 17 Feb 2023 19:30:49 +0100 (CET) Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9F97485C29 for ; Fri, 17 Feb 2023 19:30:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x829.google.com with SMTP id e26so1723625qtq.6 for ; Fri, 17 Feb 2023 10:30:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dcX21d4U8cuXvFmJaXIoClJMFvqpCWe5sx/Gkn8LtpY=; b=bSW9q8uBXr1FVXg7BtLoU/Q+e4EMGsxEi77blfglJE4xEs7iNzKpBHrowIvf3CpisJ tfjSoWvSgjzbPJsR8MP6NIqMgQrPRdDP+07wC1eccpsYnMsdo2Q2bV9I3HCA/odv8vc4 KVvKTHbERgFKXq2PyUV/2WLTSs9azFWQOtFqY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dcX21d4U8cuXvFmJaXIoClJMFvqpCWe5sx/Gkn8LtpY=; b=V9XgKb0VVCVFK5HH9oBM/7Uv9TOoiIKxAeMxHXelRTOhGXERNhpuWKoeEMixGp3IZO SzcQzSVo3HPgb0Ad2GUg5EciHrg5B7v156mSCzF7JseoCc46XFY1FyLWRBO/1H831OM0 lkeirhSZTXUkMOL0NVXcI0BF4gw9Bb3Lb0ERB0lCXxxjM/nF5fgjNdjtzGsdZi5UESN2 UwkNNlvd3nehK3UCviyCrbs+gAjO9k3zVyvlbl7mKl8+vNgVFTuMeeP2bNizvv1JhLzt tP/zWLKfBzOFd8qxSOOR6aPx37/KDEJOX2mZIPRYXzFOocVuMlOHkCF7qGXoEZ9y0+SW cflg== X-Gm-Message-State: AO0yUKW3fzEvNQ9/D3L3rXXY1uQOcwHEVb3Z5awJCbLEGKwfQAdN5J9p sBSp65GWOCCIIQqOhR06yui5sw== X-Google-Smtp-Source: AK7set89Iyz/e3jz0HRe4E9CcHWLRQfU7pagq1Xh6CZn7XYiS+ekWjE900rsTPVCCYLgoCwssX8tHw== X-Received: by 2002:ac8:5e0b:0:b0:3bb:7ff8:1977 with SMTP id h11-20020ac85e0b000000b003bb7ff81977mr17620800qtx.16.1676658645288; Fri, 17 Feb 2023 10:30:45 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-5ac5-8d1f-7f77-73e8.res6.spectrum.com. [2603:6081:7b00:6400:5ac5:8d1f:7f77:73e8]) by smtp.gmail.com with ESMTPSA id t190-20020a37aac7000000b0073b77063a12sm2489922qke.90.2023.02.17.10.30.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 10:30:44 -0800 (PST) Date: Fri, 17 Feb 2023 13:30:42 -0500 From: Tom Rini To: Jagan Teki Cc: Kever Yang , Simon Glass , Philipp Tomsich , Jagan Teki , YouMin Chen , u-boot@lists.denx.de, Jonas Karlman Subject: Re: [PATCH] rockchip: dts: rk3328: fix sdram params Message-ID: References: <20230210183002.114902-1-jonas@kwiboo.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="l677IxiL7d4+MKVb" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --l677IxiL7d4+MKVb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 17, 2023 at 11:39:35PM +0530, Jagan Teki wrote: > Hi Kever and Tom, >=20 > On Sat, Feb 11, 2023 at 12:00 AM Jonas Karlman wrote: > > > > The rk3328 sdram driver read sdram parameters from the devicetree into a > > struct rk3328_sdram_params using dev_read_u32_array. > > > > After commit 5ab30c3176bf ("ram: rockchip: Update ddr pctl regs for px3= 0") > > changed the size of struct ddr_pctl_regs, a member of struct > > rk3328_sdram_params, U-Boot TPL can no longer initialize DRAM on RK3328. > > > > Add ten u32 to the sdram parameter array in devicetree to align with > > this size change. This fixes DRAM initialization on RK3328. > > > > Fixes: 5ab30c3176bf ("ram: rockchip: Update ddr pctl regs for px30") > > Signed-off-by: Jonas Karlman > > --- >=20 > Can someone merge this soon, rk3328 platform has broken in the last two R= Cs. I would really like to see a rockchip PR of fixes at this point, yes. I believe we'll need one of the TPL/binary-blob related series as well? --=20 Tom --l677IxiL7d4+MKVb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPvx8wACgkQFHw5/5Y0 tyxw8wv+JQyt1ohOxB4HlbOfUIJqcK6CK2AJm6zaNZtAvI9DvhB+pIMXtI6csJBD emwc96O3lsryDO0CsUMBJibLKfpOULoV/+oKs/SVqBGXezq4ALgF95qMsHi7ufdE fG999MnpMB7sp6ua4xkg9YazmJA95RUbwBgXFJRYATwrYsFs5AhuN7W7Nw3EgMtg HFvjkGADBynFs9hye/OZniaS7NYsZvqAiZGufe2jGYDVGzj7qcjBtWVBogqMAlv2 YDtf1er2hkDg6EIypji1+dXEOy7tbsjoRhRAXkpXIGq903H/vn3QLyJq/um7nZIj Tx7+NjEGyN5QFSE8TTQUg2MPAp9888FhosUpka3s0SB6V/XZSo4h7E97hVc66we+ rxx1bJYVjaCR1zTM/wl0HpxB5VHCnluzsCVtqja8XW+U+T01RlInWx0IJ3Fbcqax y9qe9bWB78jQZ/gFnHeLCYT2RkU88PZzm+CCdrw5qRH1zFiAgkfmo0odIo3/PQTF aJFfKkBf =JHer -----END PGP SIGNATURE----- --l677IxiL7d4+MKVb--