From: Tom Rini <trini@konsulko.com>
To: Marek Vasut <marex@denx.de>
Cc: u-boot@lists.denx.de,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Olaf Mandel <o.mandel@menlosystems.com>,
Stefano Babic <sbabic@denx.de>,
Fabio Estevam <festevam@gmail.com>,
"NXP i . MX U-Boot Team" <uboot-imx@nxp.com>
Subject: Re: [PATCHv2 12/13] global: Add a select for ARCH_MISC_INIT where used
Date: Fri, 17 Feb 2023 09:42:57 -0500 [thread overview]
Message-ID: <Y++ScdKHchTwMPiU@bill-the-cat> (raw)
In-Reply-To: <b50db240-f829-09d0-e760-6d2e692fc489@denx.de>
[-- Attachment #1: Type: text/plain, Size: 1844 bytes --]
On Fri, Feb 17, 2023 at 03:40:28PM +0100, Marek Vasut wrote:
> On 2/17/23 15:00, Tom Rini wrote:
> > On Fri, Feb 17, 2023 at 02:33:28PM +0100, Marek Vasut wrote:
> > > On 2/17/23 13:50, Tom Rini wrote:
> > > > When we have an arch_misc_init function, we can select it to ensure it's
> > > > used.
> > > >
> > > > In that there is a functional change here, it's that on i.MX6 it's
> > > > always been possible to populate "serial#" with something meaningful,
> > > > but not every platform was taking the hook, and now it is.
> > > >
> > > > Signed-off-by: Tom Rini <trini@konsulko.com>
> > > > ---
> > > > Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > > > Cc: Marek Vasut <marex@denx.de>
> > > > Cc: Olaf Mandel <o.mandel@menlosystems.com>
> > > > Cc: Stefano Babic <sbabic@denx.de>
> > > > Cc: Fabio Estevam <festevam@gmail.com>
> > > > Cc: NXP i.MX U-Boot Team <uboot-imx@nxp.com>
> > > >
> > > > Changes in v2:
> > > > - Always select ARCH_MISC_INIT on IMX8M as dealing with FSL_CAAM or not
> > > > needs further SoC-specific clean up work. This replaces patches 10 and
> > > > 11 from before so that if the user enables FSL_CAAM then they will
> > > > continue to get the functionality they had before. As Marek noted in the
> > > > thread, further clean-up in this area would be good.
> > >
> > > The SPL code does not automatically call arch_misc_init() if ARCH_MISC_INIT
> > > is selected , so this won't work as-is. Is there another patch on which I
> > > wasn't CCed which deals with that ?
> >
> > This preserves the exiting behavior, nothing more.
>
> Where does the arch_misc_init() get called from in SPL ?
> If that remains in board code for now, then yeah, fine by me.
Yes, it's still on the board to call arch_misc_init() inside
spl_board_init().
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-02-17 14:43 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 3:36 [PATCH 01/13] common/Kconfig: Reword text for BOARD_TYPES Tom Rini
2023-02-16 3:36 ` [PATCH 02/13] arm: mvebu: Add select on ARCH_EARLY_INIT_R if ARM64 Tom Rini
2023-02-16 6:31 ` Stefan Roese
2023-03-03 23:40 ` Tom Rini
2023-02-16 3:36 ` [PATCH 03/13] arm: zynq: Move to select'ing ARCH_EARLY_INIT_R if we have FPGA Tom Rini
2023-02-16 9:53 ` Michal Simek
2023-02-16 20:17 ` Simon Glass
2023-03-03 23:40 ` Tom Rini
2023-02-16 3:36 ` [PATCH 04/13] arm: rk3368: Select ARCH_EARLY_INIT_R when used Tom Rini
2023-02-16 20:17 ` Simon Glass
2023-02-17 12:42 ` Quentin Schulz
2023-03-03 23:40 ` Tom Rini
2023-02-16 3:36 ` [PATCH 05/13] common: Make ARCH_EARLY_INIT_R be selected only Tom Rini
2023-02-16 20:17 ` Simon Glass
2023-03-03 23:40 ` Tom Rini
2023-02-16 3:36 ` [PATCH 06/13] imx9: Remove ARCH_MISC_INIT Tom Rini
2023-02-16 20:17 ` Simon Glass
2023-02-20 8:50 ` Peng Fan
2023-03-03 23:41 ` Tom Rini
2023-02-16 3:36 ` [PATCH 07/13] mvebe: Drop ARCH_MISC_INIT from alleycat 5 Tom Rini
2023-02-16 20:17 ` Simon Glass
2023-02-16 20:23 ` Chris Packham
2023-03-03 23:41 ` Tom Rini
2023-02-16 3:36 ` [PATCH 08/13] mvebu: Drop empty arch_misc_init Tom Rini
2023-02-16 6:31 ` Stefan Roese
2023-03-03 23:41 ` Tom Rini
2023-02-16 3:36 ` [PATCH 09/13] s5p: Remove " Tom Rini
2023-02-16 20:17 ` Simon Glass
2023-02-24 9:07 ` Minkyu Kang
2023-03-03 23:41 ` Tom Rini
2023-02-16 3:36 ` [PATCH 10/13] verdin-imx8mm: Remove unused SPL_BOARD_INIT Tom Rini
2023-02-16 12:37 ` Marcel Ziswiler
2023-02-17 13:18 ` Marcel Ziswiler
2023-02-17 14:03 ` Tom Rini
2023-02-17 16:14 ` Francesco Dolcini
2023-02-17 17:03 ` Tom Rini
2023-02-16 3:36 ` [PATCH 11/13] imx8mm-mx8menlo: Drop SPL_BOARD_INIT Tom Rini
2023-02-16 14:04 ` Marek Vasut
2023-02-16 14:13 ` Tom Rini
2023-02-16 14:21 ` Marek Vasut
2023-02-16 14:41 ` Tom Rini
2023-02-17 2:42 ` Marek Vasut
2023-02-16 3:36 ` [PATCH 12/13] global: Add a select for ARCH_MISC_INIT where used Tom Rini
2023-02-17 12:50 ` [PATCHv2 " Tom Rini
2023-02-17 13:33 ` Marek Vasut
2023-02-17 14:00 ` Tom Rini
2023-02-17 14:40 ` Marek Vasut
2023-02-17 14:42 ` Tom Rini [this message]
2023-02-16 3:36 ` [PATCH 13/13] common: Make ARCH_MISC_INIT be selected only Tom Rini
2023-02-17 23:49 ` Simon Glass
2023-02-17 23:49 ` [PATCH 01/13] common/Kconfig: Reword text for BOARD_TYPES Simon Glass
2023-03-03 23:40 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y++ScdKHchTwMPiU@bill-the-cat \
--to=trini@konsulko.com \
--cc=festevam@gmail.com \
--cc=marcel.ziswiler@toradex.com \
--cc=marex@denx.de \
--cc=o.mandel@menlosystems.com \
--cc=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox