From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5056CC6379F for ; Fri, 17 Feb 2023 16:14:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B186085C7A; Fri, 17 Feb 2023 17:14:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=dolcini.it Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=mailserver.it header.i=@mailserver.it header.b="LtN34P+Q"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3338885C88; Fri, 17 Feb 2023 17:14:22 +0100 (CET) Received: from smtp-out-03.comm2000.it (smtp-out-03.comm2000.it [212.97.32.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DA20585C79 for ; Fri, 17 Feb 2023 17:14:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=dolcini.it Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=francesco@dolcini.it Received: from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: francesco@dolcini.it) by smtp-out-03.comm2000.it (Postfix) with ESMTPSA id E9356B4BCBC; Fri, 17 Feb 2023 17:14:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailserver.it; s=mailsrv; t=1676650456; bh=MJs0lFBDATFk+SEmNPhkxvq/rvWVUjF+nPC3p5J8eq4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=LtN34P+Qr7zQyLNUMHoFYGhetgW/a50BTaBFZWHTfBErSmn980LpkMj3Wxvja80VX lCcL+he/wGH/g3IGhUm9las/+gM70vcT5BtZQXFRoNM25AUGvDTsLlAiHJjlNvWbfO vvLKW3OM1ja+FQPHJLCQ9vBqnxZmPP/opx+oltbUXghJT14BbmyJ7/whB/0v1wL4A2 VWxCqxNsblhECRSg13kvHwjGhkISIy1nVf5SBhl+o52N2+ASbRC34TAcM/JFBCV1TH OJFaas2uf6rfMQap70u+tguZiSCfd4P109Il80kjy24BmwD0MYq3O7l95L57IZvDI7 wBGws4JYZAfgg== Date: Fri, 17 Feb 2023 17:14:11 +0100 From: Francesco Dolcini To: Tom Rini Cc: Marcel Ziswiler , "u-boot@lists.denx.de" , "marex@denx.de" , Francesco Dolcini Subject: Re: [PATCH 10/13] verdin-imx8mm: Remove unused SPL_BOARD_INIT Message-ID: References: <20230216033659.3877684-1-trini@konsulko.com> <20230216033659.3877684-10-trini@konsulko.com> <0916ce5f76f74e88ba46e89d5bd51fc224f00cde.camel@toradex.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Fri, Feb 17, 2023 at 09:03:07AM -0500, Tom Rini wrote: > On Fri, Feb 17, 2023 at 01:18:34PM +0000, Marcel Ziswiler wrote: > > Hi Tom > > > > On Thu, 2023-02-16 at 13:37 +0100, Marcel Ziswiler wrote: > > > On Wed, 2023-02-15 at 22:36 -0500, Tom Rini wrote: > > > > On this platform SPL_BOARD_INIT is used to call arch_misc_init which is > > > > in turn empty, drop the call. > > > > > > > > Cc: Marcel Ziswiler > > > > Signed-off-by: Tom Rini > > > > > > Acked-by: Marcel Ziswiler > > > > Sorry, I have to take my ack back. Marek (and Francesco) are, of course, right and this is indeed needed for > > CAAM. Please see also [1] where it got changed/introduced in/to the current form. > > > > [1] https://lore.kernel.org/all/20220919194118.105820-1-marex@denx.de/ > > Alright, yeah. I've posted v2 which preserves the existing behavior, but > it could be improved further still by someone with the hardware to > confirm behavior on. [PATCHv2 12/13] global: Add a select for ARCH_MISC_INIT where used -- ? I would say that even with that patch in, this specific one should be dropped. At least this is what I understand from your comment here: > Yes, it's still on the board to call arch_misc_init() inside spl_board_init(). We can test your changes on the Verdin iMX8MM, even Marek should have one to my understanding, in case we are somehow late. Thanks, Francesco