From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5375C636D6 for ; Fri, 17 Feb 2023 17:03:51 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D977385C29; Fri, 17 Feb 2023 18:03:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="LBeZTc1I"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 967E785C94; Fri, 17 Feb 2023 18:03:47 +0100 (CET) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1BDD385C29 for ; Fri, 17 Feb 2023 18:03:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x832.google.com with SMTP id d10so1424136qtr.12 for ; Fri, 17 Feb 2023 09:03:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7r8ACgpJjvfL/kESmrQAm7HN8A29SPHLzWhoskMh6rI=; b=LBeZTc1IK5TovqiXkQtJ75agnxhw7bqjJSYwvlvXoG9lDKS75gpNrLA9zYkaEj/KEe GQ2/kmOITkiNuwzyYBIlqA99HkbmQxHGci8jVA/yoOIUHncGpM06gouS33gE6Awk7Ndx E1QQxwIjwRESVUzoc0C0mRaPaI+zucj0auPK0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7r8ACgpJjvfL/kESmrQAm7HN8A29SPHLzWhoskMh6rI=; b=l0TCTO+BaNkjaMvD03tfgdRm08xKOh1FoM+KpNbX8dOmYlaMXfv0gSKWj989HSac0e 9bgDFwqfSEah7oopqCP+VHsAjCBMZoZpU4g5du8EgH3HGofl2VUv4gglMm8ODoj4QNGB 1YCP9DgLUuJZNf0WxMR/oGwYLeQUqD7TWBa38BABhfSfDcyIrdxCqZXAZ/BdAOLWcTpU Hc3tIUK/8fMkSXl4z2itfcr3F2Hf/6Z3eogHIGEu17W2/G+HTeY+vbfKyDL+hR/Z3yR/ /xrcY3FTSrWySjp9hBtOuKW5H718kpxA4ocrdI+AvNWIfYlJYaa5LuR0EVY+o7pZ7Ww8 MrgQ== X-Gm-Message-State: AO0yUKU3gfieXIA9sBbjVdKahJ1qsnSr4IzwoC7bR1aiu8YTg8UoJz58 8RgnWOo49cVKucOQ6uPsJLU5pA== X-Google-Smtp-Source: AK7set9bJ8CY25yZI1B6yxAQ5R+mgp3UiLFHPqoxLryPcUX8zobLShmRAjeF9tCU4KoU+Yy1p4qilQ== X-Received: by 2002:a05:622a:387:b0:3b9:bc8c:c213 with SMTP id j7-20020a05622a038700b003b9bc8cc213mr9879586qtx.30.1676653422363; Fri, 17 Feb 2023 09:03:42 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-5ac5-8d1f-7f77-73e8.res6.spectrum.com. [2603:6081:7b00:6400:5ac5:8d1f:7f77:73e8]) by smtp.gmail.com with ESMTPSA id a4-20020ac84344000000b003b2957fb45bsm3639954qtn.8.2023.02.17.09.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 09:03:41 -0800 (PST) Date: Fri, 17 Feb 2023 12:03:40 -0500 From: Tom Rini To: Francesco Dolcini Cc: Marcel Ziswiler , "u-boot@lists.denx.de" , "marex@denx.de" , Francesco Dolcini Subject: Re: [PATCH 10/13] verdin-imx8mm: Remove unused SPL_BOARD_INIT Message-ID: References: <20230216033659.3877684-1-trini@konsulko.com> <20230216033659.3877684-10-trini@konsulko.com> <0916ce5f76f74e88ba46e89d5bd51fc224f00cde.camel@toradex.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="m0K9Xti7t38FShrP" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --m0K9Xti7t38FShrP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 17, 2023 at 05:14:11PM +0100, Francesco Dolcini wrote: > On Fri, Feb 17, 2023 at 09:03:07AM -0500, Tom Rini wrote: > > On Fri, Feb 17, 2023 at 01:18:34PM +0000, Marcel Ziswiler wrote: > > > Hi Tom > > >=20 > > > On Thu, 2023-02-16 at 13:37 +0100, Marcel Ziswiler wrote: > > > > On Wed, 2023-02-15 at 22:36 -0500, Tom Rini wrote: > > > > > On this platform SPL_BOARD_INIT is used to call arch_misc_init wh= ich is > > > > > in turn empty, drop the call. > > > > >=20 > > > > > Cc: Marcel Ziswiler > > > > > Signed-off-by: Tom Rini > > > >=20 > > > > Acked-by: Marcel Ziswiler > > >=20 > > > Sorry, I have to take my ack back. Marek (and Francesco) are, of cour= se, right and this is indeed needed for > > > CAAM. Please see also [1] where it got changed/introduced in/to the c= urrent form. > > >=20 > > > [1] https://lore.kernel.org/all/20220919194118.105820-1-marex@denx.de/ > >=20 > > Alright, yeah. I've posted v2 which preserves the existing behavior, but > > it could be improved further still by someone with the hardware to > > confirm behavior on. >=20 > [PATCHv2 12/13] global: Add a select for ARCH_MISC_INIT where used -- ? >=20 > I would say that even with that patch in, this specific one should be > dropped. Yes, with v2 of 12/13, patches 10 and 11 from v1 of the series are dropped, to be clear. > At least this is what I understand from your comment here: > > Yes, it's still on the board to call arch_misc_init() inside spl_board_= init(). >=20 > We can test your changes on the Verdin iMX8MM, even Marek should have > one to my understanding, in case we are somehow late. What I mean is that Marek has suggested a more specific fix to this problem (it should not be per-board to get the CAAM working for HAB here, it should be in the SoC code and hooks), and I would quite welcome the general clean-up but can't test it, so won't write it, right now. --=20 Tom --m0K9Xti7t38FShrP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPvs2kACgkQFHw5/5Y0 tyzE0wwAkpgdK0zpbj/Dp+X3HJezYPQGB/WIoynbIl2VXh1zXJ/Qa/8Nci1Ev0IG MOmTqYkKZ8ilF1nY9hOgT/JQ7WTc1++dENgD4p5dObA6s8yVxkfyXAdKnHilpMPV P6AXjgPdBGK7tZlgohVuGeE45aacVN9SjMNTEw8voX7d2xzocCcVQn37QK4N2Loq zc3Jk/WZB0jEKfWAMzKGThcQlL2yfS9pprZdaLDrT369/QxYUK6XQaiLGwYfFzQz 7eRPEWKOYeAg3bH/a/KC0wn4EU8eGz6eRoICVJJXwThQ12+EF0ZR+JDNvcX9kbDP Lr06KhktaGApH/KJwZQ+pP51/xzetPhviW09GbRpxRrKOglgeEnMi2uZ/YoUddYu iphyFxHslHENzlHDOWy3bps4QFulfkYAn1kwFRVewu77eXIhXZ0eKHxpI4SNOZRW X9MX8qcf9YLaSEb+LjlSrOrUy802ZOSSR20Iavp5+QP2VQH81Sn6Qs9hau4peiMU 0Rbn699n =DAfz -----END PGP SIGNATURE----- --m0K9Xti7t38FShrP--