From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D370C636CC for ; Thu, 16 Feb 2023 04:04:35 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 20F1F85A8E; Thu, 16 Feb 2023 05:04:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id E548A85A94; Thu, 16 Feb 2023 05:04:30 +0100 (CET) Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E6F7185A75 for ; Thu, 16 Feb 2023 05:04:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by Atcsqr.andestech.com with ESMTP id 31G44E99001018; Thu, 16 Feb 2023 12:04:14 +0800 (+08) (envelope-from ycliang@andestech.com) Received: from ubuntu01 (10.0.12.75) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Thu, 16 Feb 2023 12:04:14 +0800 Date: Thu, 16 Feb 2023 04:03:57 +0000 From: Leo Liang To: Rick Chen CC: , , , Subject: Re: [PATCH] riscv: binman: Add help message for missing blobs Message-ID: References: <20230216011945.4833-1-rick@andestech.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230216011945.4833-1-rick@andestech.com> User-Agent: Mutt/2.0.5 (2021-01-21) X-Originating-IP: [10.0.12.75] X-DNSRBL: X-MAIL: Atcsqr.andestech.com 31G44E99001018 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Rick, On Thu, Feb 16, 2023 at 09:19:45AM +0800, Rick Chen wrote: > Add the 'missing-msg' for more detailed output > on missing system firmware. > > Signed-off-by: Rick Chen > --- > arch/riscv/dts/binman.dtsi | 1 + > tools/binman/missing-blob-help | 4 ++++ > 2 files changed, 5 insertions(+) > > diff --git a/arch/riscv/dts/binman.dtsi b/arch/riscv/dts/binman.dtsi > index b8fc8f7f35..156cb00971 100644 > --- a/arch/riscv/dts/binman.dtsi > +++ b/arch/riscv/dts/binman.dtsi > @@ -45,6 +45,7 @@ > > opensbi_blob: opensbi { > filename = "fw_dynamic.bin"; > + missing-msg = "opensbi"; > }; > }; > > diff --git a/tools/binman/missing-blob-help b/tools/binman/missing-blob-help > index c61ca02a35..654ad642a3 100644 > --- a/tools/binman/missing-blob-help > +++ b/tools/binman/missing-blob-help > @@ -37,3 +37,7 @@ https://github.com/siemens/k3-rti-wdt. > tee-os: > See the documentation for your board. You may need to build Open Portable > Trusted Execution Environment (OP-TEE) with TEE=/path/to/tee.bin > + > +opensbi: > +See the documentation for your board. The OpenSBI git repo is at > +https://github.com/riscv/opensbi.git Hi Rick, Could we add something like "build fw_dynamic.bin first and re-build u-boot with OPENSBI=/path/to/fw_dynamic.bin" Other than that, Reviewed-by: Leo Yu-Chi Liang > -- > 2.17.1 >