From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CC8FC636CC for ; Thu, 16 Feb 2023 08:13:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 34A5F85A6A; Thu, 16 Feb 2023 09:13:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=grimler.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=grimler.se header.i=@grimler.se header.b="TvGwGgQw"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8EF6085A3A; Thu, 16 Feb 2023 09:13:28 +0100 (CET) Received: from out-97.mta0.migadu.com (out-97.mta0.migadu.com [IPv6:2001:41d0:1004:224b::61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2F376856C5 for ; Thu, 16 Feb 2023 09:13:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=grimler.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=henrik@grimler.se Date: Thu, 16 Feb 2023 09:13:23 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=grimler.se; s=key1; t=1676535204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AqVVYLQPig7i7fhOGDl7IZeUN2w7FnwdsJVe06QJn2U=; b=TvGwGgQwOzPFSKlEyf2CVyJTsriMPuJuBEYNkrVuOkfHwNZpSjGwYKYyvsthvxI83zmVGu ab2/PLqOLf6jblhKuneYtga/4lHWc4/FDUYr38jnZmj2qN1U1T1UvtsEXd+yYOwe9tcYES 8aBmkdodeVabAcVI/osjzeGjlqgIY8Y= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Henrik Grimler To: Stefan Agner Cc: u-boot@lists.denx.de, sjg@chromium.org Subject: Re: [PATCH] samsung: common: ignore if CROS EC is not supported Message-ID: References: <841fd733dfe500dee9b4f8354337135d4bc1de93.1676487760.git.stefan@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <841fd733dfe500dee9b4f8354337135d4bc1de93.1676487760.git.stefan@agner.ch> X-Migadu-Flow: FLOW_OUT X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Stefan, On Wed, Feb 15, 2023 at 08:03:14PM +0100, Stefan Agner wrote: > If the CROS device class is not compiled in, uclass returns not > supported. Ignore this case as well. > > This avoids boot failures on ODROID-XU4 without CONFIG_CROS_EC > ending with: > cros-ec communications failure -96 > Please reset with Power+Refresh > Cannot init cros-ec device Thanks, the same issue happens on odroid-u2 (and probably other devices as well), issue was reported in https://lists.denx.de/pipermail/u-boot/2023-January/504115.html, and I sent an identical patch in https://lists.denx.de/pipermail/u-boot/2023-February/508929.html. Best regards, Henrik Grimler > Signed-off-by: Stefan Agner > --- > board/samsung/common/board.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/samsung/common/board.c b/board/samsung/common/board.c > index 16ce5cb892..663d7ca991 100644 > --- a/board/samsung/common/board.c > +++ b/board/samsung/common/board.c > @@ -223,7 +223,7 @@ int board_late_init(void) > char mmcbootdev_str[16]; > > ret = uclass_first_device_err(UCLASS_CROS_EC, &dev); > - if (ret && ret != -ENODEV) { > + if (ret && ret != -ENODEV && ret != -EPFNOSUPPORT) { > /* Force console on */ > gd->flags &= ~GD_FLG_SILENT; > > -- > 2.39.1 >