From: Tom Rini <trini@konsulko.com>
To: Marek Vasut <marex@denx.de>
Cc: u-boot@lists.denx.de, Olaf Mandel <o.mandel@menlosystems.com>
Subject: Re: [PATCH 11/13] imx8mm-mx8menlo: Drop SPL_BOARD_INIT
Date: Thu, 16 Feb 2023 09:41:40 -0500 [thread overview]
Message-ID: <Y+5ApLOTK2AfYiNw@bill-the-cat> (raw)
In-Reply-To: <b21de157-4827-b630-ba88-1fedced1b6d8@denx.de>
[-- Attachment #1: Type: text/plain, Size: 1567 bytes --]
On Thu, Feb 16, 2023 at 03:21:43PM +0100, Marek Vasut wrote:
> On 2/16/23 15:13, Tom Rini wrote:
> > On Thu, Feb 16, 2023 at 03:04:35PM +0100, Marek Vasut wrote:
> > > On 2/16/23 04:36, Tom Rini wrote:
> > > > On this platform spl_board_init is a call to arch_misc_init which is a
> > > > no-op, so drop the CONFIG options.
> > > >
> > > > Cc: Marek Vasut <marex@denx.de>
> > > > Cc: Olaf Mandel <o.mandel@menlosystems.com>
> > >
> > > btw. put those under --- next time, that way they don't end up in commit
> > > message.
> >
> > Er, did the kernel change expected behavior here?
>
> Er ... wasn't that the case for like a year now ?
Is that a yes then?
> > > > Signed-off-by: Tom Rini <trini@konsulko.com>
> > >
> > > If CAAM is enabled, ARCH_MISC_INIT brings up the CAAM , and this is needed
> > > in SPL for U-Boot authentication using HABv4 . I believe that is why Verdin
> > > spl.c calls it.
> >
> > Then I'll put doing a follow-up on SPL_BOARD_INIT (which is another
> > option that shouldn't be directly asked, but select'd when used) for
> > that case. It fails to build in this series because CAAM isn't enabled
> > so there's no arch_misc_init.
>
> Just call the arch_board_init unconditionally, the CAAM inside of it is
> already conditional, so the compiler should inline the result if CAAM is
> disabled.
It doesn't, and only maybe does with LTO. But we also shouldn't be
enabling unused hooks. It sounds like imx8m should follow the other
platforms that have an spl_board_init under arch/ ?
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-02-16 14:41 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 3:36 [PATCH 01/13] common/Kconfig: Reword text for BOARD_TYPES Tom Rini
2023-02-16 3:36 ` [PATCH 02/13] arm: mvebu: Add select on ARCH_EARLY_INIT_R if ARM64 Tom Rini
2023-02-16 6:31 ` Stefan Roese
2023-03-03 23:40 ` Tom Rini
2023-02-16 3:36 ` [PATCH 03/13] arm: zynq: Move to select'ing ARCH_EARLY_INIT_R if we have FPGA Tom Rini
2023-02-16 9:53 ` Michal Simek
2023-02-16 20:17 ` Simon Glass
2023-03-03 23:40 ` Tom Rini
2023-02-16 3:36 ` [PATCH 04/13] arm: rk3368: Select ARCH_EARLY_INIT_R when used Tom Rini
2023-02-16 20:17 ` Simon Glass
2023-02-17 12:42 ` Quentin Schulz
2023-03-03 23:40 ` Tom Rini
2023-02-16 3:36 ` [PATCH 05/13] common: Make ARCH_EARLY_INIT_R be selected only Tom Rini
2023-02-16 20:17 ` Simon Glass
2023-03-03 23:40 ` Tom Rini
2023-02-16 3:36 ` [PATCH 06/13] imx9: Remove ARCH_MISC_INIT Tom Rini
2023-02-16 20:17 ` Simon Glass
2023-02-20 8:50 ` Peng Fan
2023-03-03 23:41 ` Tom Rini
2023-02-16 3:36 ` [PATCH 07/13] mvebe: Drop ARCH_MISC_INIT from alleycat 5 Tom Rini
2023-02-16 20:17 ` Simon Glass
2023-02-16 20:23 ` Chris Packham
2023-03-03 23:41 ` Tom Rini
2023-02-16 3:36 ` [PATCH 08/13] mvebu: Drop empty arch_misc_init Tom Rini
2023-02-16 6:31 ` Stefan Roese
2023-03-03 23:41 ` Tom Rini
2023-02-16 3:36 ` [PATCH 09/13] s5p: Remove " Tom Rini
2023-02-16 20:17 ` Simon Glass
2023-02-24 9:07 ` Minkyu Kang
2023-03-03 23:41 ` Tom Rini
2023-02-16 3:36 ` [PATCH 10/13] verdin-imx8mm: Remove unused SPL_BOARD_INIT Tom Rini
2023-02-16 12:37 ` Marcel Ziswiler
2023-02-17 13:18 ` Marcel Ziswiler
2023-02-17 14:03 ` Tom Rini
2023-02-17 16:14 ` Francesco Dolcini
2023-02-17 17:03 ` Tom Rini
2023-02-16 3:36 ` [PATCH 11/13] imx8mm-mx8menlo: Drop SPL_BOARD_INIT Tom Rini
2023-02-16 14:04 ` Marek Vasut
2023-02-16 14:13 ` Tom Rini
2023-02-16 14:21 ` Marek Vasut
2023-02-16 14:41 ` Tom Rini [this message]
2023-02-17 2:42 ` Marek Vasut
2023-02-16 3:36 ` [PATCH 12/13] global: Add a select for ARCH_MISC_INIT where used Tom Rini
2023-02-17 12:50 ` [PATCHv2 " Tom Rini
2023-02-17 13:33 ` Marek Vasut
2023-02-17 14:00 ` Tom Rini
2023-02-17 14:40 ` Marek Vasut
2023-02-17 14:42 ` Tom Rini
2023-02-16 3:36 ` [PATCH 13/13] common: Make ARCH_MISC_INIT be selected only Tom Rini
2023-02-17 23:49 ` Simon Glass
2023-02-17 23:49 ` [PATCH 01/13] common/Kconfig: Reword text for BOARD_TYPES Simon Glass
2023-03-03 23:40 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+5ApLOTK2AfYiNw@bill-the-cat \
--to=trini@konsulko.com \
--cc=marex@denx.de \
--cc=o.mandel@menlosystems.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox