Re: [PATCH v2 1/1] spl: allow loading via partition type GUID

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

On Thu, Feb 16, 2023 at 04:29:56PM +0100, Heinrich Schuchardt wrote:

> Some boards provide main U-Boot as a dedicated partition to SPL.
> Currently we can define either a fixed partition number or an MBR
> partition type to define which partition is to be used.
> 
> Partition numbers tend to conflict with established partitioning schemes
> of Linux distros. MBR partitioning is more and more replaced by GPT
> partitioning.
> 
> Allow defining a partition type GUID identifying the partition to load
> main U-Boot from.
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
[snip]
> +config SYS_MMCSD_RAW_MODE_U_BOOT_GPT_PARTITION_TYPE
> +	string "GPT Partition Type on the MMC to load U-Boot from"
> +	depends on SYS_MMCSD_RAW_MODE_U_BOOT_USE_GPT_PARTITION_TYPE
> +	default d2f002f8-e4e7-4269-b8ac-3bb6fabeaff6

Is there a reason to use any other GUID value here? If not, just define,
or use it directly with a comment.  If there is a reason for other
values to be used:

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]