Re: [PATCH 2/2 v3] efi_loader: use tpm_auto_start for the tpm device

Simon Glass
2023-01-28T22:04:31Z

On Thu, 26 Jan 2023 at 01:18, Ilias Apalodimas
<ilias.apalodimas@linaro.org> wrote:
>
> A previous commit is adding a new tpm startup functions which
> initializes the TPMv2 and performs all the needed selftests.
> Since the TPM selftests might be needed depending on the requested
> lgorithm or functional module use that instead.

spelling

>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> ---
> No changes since v1
>
> lib/efi_loader/efi_tcg2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

>
> diff --git a/lib/efi_loader/efi_tcg2.c b/lib/efi_loader/efi_tcg2.c
> index 918e9a268641..d035a00d98ac 100644
> --- a/lib/efi_loader/efi_tcg2.c
> +++ b/lib/efi_loader/efi_tcg2.c
> @@ -2422,7 +2422,7 @@ efi_status_t efi_tcg2_register(void)
> }
>
> /* initialize the TPM as early as possible. */
> - err = tpm_startup(dev, TPM_ST_CLEAR);
> + err = tpm_auto_start(dev);
> if (err) {
> log_err("TPM startup failed\n");
> goto fail;
> --
> 2.38.1
>