From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28E85C05027 for ; Mon, 6 Feb 2023 18:04:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B1E7485C18; Mon, 6 Feb 2023 19:04:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ZTUdUxtK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0FE6085C16; Mon, 6 Feb 2023 19:04:46 +0100 (CET) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B337385C07 for ; Mon, 6 Feb 2023 19:04:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x831.google.com with SMTP id m12so13815436qth.4 for ; Mon, 06 Feb 2023 10:04:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8LgQ0OjqaDQ/JLXAyCH5sxn1ooOlyAzpDCg5UT0M54U=; b=ZTUdUxtK9Opkzzj2wjiTcM3cNAK1DuSbvqVyxppA4gRF3BsmIhK6zmPLKuyKUL/548 UV1XXlnye9yRPTYAft5ocZKcEdY3+5dhHV4CRofEhCwEfBfvRYag9gbFXeNPZRdDK7m2 lYK8H82r/KNt978VzrjPATYKGjxwIa2rGRZFg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8LgQ0OjqaDQ/JLXAyCH5sxn1ooOlyAzpDCg5UT0M54U=; b=7fq70QGDHm0tUZe84lVU+PazPGDhK4XimmwICDmhFMInf2wE2slBuMEvrfrITiPctM 1Ul4aRmsZQpQ1jVmWXdW4We8iD0rkiAan3e+DyvkuoDhUGO+Swylxg3Ee+So0bSTefAQ m+3KpAUMhl+qz11dQLputupzB+LMBujjQdBzr5Uags8GJM9b2I65Xub5yfct/VvOHa4l mUPoWH9ve5fCTX1IIuJyZuCdTeXPqycACiEHbxomJcP/1BL8XlBUpoOaBOZsGPrrXAtq A7qwyX3oDWXG7qpMtsqdZTKAEteL6UVR5dMQaXOf3LpXNPyxPKlTOaMhvRPqyx+auwQb H+uQ== X-Gm-Message-State: AO0yUKV9c3HCJ21vM5bVyxD8jYFOhfnb9VIhSykesaRIDcdvBa/alt84 0AGRHBkoq+kBn7+X1hTZDyD9qw== X-Google-Smtp-Source: AK7set+baoLsntF0Wnk1CZlSl9M3waIS1vlAVCnlt6PxfbF05zyghmpNMh+8BJFQUb7ohSGFOQeJfw== X-Received: by 2002:a05:622a:54e:b0:3b8:1d89:e01b with SMTP id m14-20020a05622a054e00b003b81d89e01bmr447802qtx.23.1675706681505; Mon, 06 Feb 2023 10:04:41 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-7624-7f8a-2088-981c.res6.spectrum.com. [2603:6081:7b00:6400:7624:7f8a:2088:981c]) by smtp.gmail.com with ESMTPSA id u10-20020a05622a010a00b003b80fdaa14dsm7847057qtw.73.2023.02.06.10.04.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 10:04:41 -0800 (PST) Date: Mon, 6 Feb 2023 13:04:39 -0500 From: Tom Rini To: Sjoerd Simons Cc: u-boot@lists.denx.de, Ashok Reddy Soma , Heinrich Schuchardt , Michal Simek , Patrice Chotard Subject: Re: [PATCH 3/3] lmb: Treat a region which is a subset as equal Message-ID: References: <20230119083820.2656710-1-sjoerd@collabora.com> <20230119083820.2656710-4-sjoerd@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Uk2UE2pd7Rkq17gh" Content-Disposition: inline In-Reply-To: <20230119083820.2656710-4-sjoerd@collabora.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --Uk2UE2pd7Rkq17gh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 19, 2023 at 09:38:19AM +0100, Sjoerd Simons wrote: > In various cases logical memory blocks are coalesced; As a result doing > a strict check whether memory blocks are the same doesn't necessarily > work as a previous addition of a given block might have been merged into > a bigger block. >=20 > Fix this by considering a block is already registered if it's a pure > subset of one of the existing blocks. >=20 > Signed-off-by: Sjoerd Simons > --- >=20 > lib/lmb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/lmb.c b/lib/lmb.c > index f447c639a60..b09a043f4c2 100644 > --- a/lib/lmb.c > +++ b/lib/lmb.c > @@ -248,7 +248,7 @@ static long lmb_add_region_flags(struct lmb_region *r= gn, phys_addr_t base, > phys_size_t rgnsize =3D rgn->region[i].size; > phys_size_t rgnflags =3D rgn->region[i].flags; > =20 > - if (rgnbase =3D=3D base && rgnsize =3D=3D size) { > + if (rgnbase <=3D base && rgnbase + rgnsize >=3D base + size) { > if (flags =3D=3D rgnflags) > /* Already have this region, so we're done */ > return 0; This breaks lib_test_lmb_simple, lib_test_lmb_simple_x2 and lib_test_lmb_alloc_addr. --=20 Tom --Uk2UE2pd7Rkq17gh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPhQTAACgkQFHw5/5Y0 tywVGAwAi7bZLiZFmSiVNzGUoL99rOM0O6/Z+oMOk1Nc6KfPnAsKiXalmtvbp0+4 Tbjqs4JgaI/UDiFDhaxQbqZJf5CPs6Zc4EOwIsQmGxLtGWYcM1Fm0mjGSLl7sar7 H3/+sqz9MrPIvE/6+1l4FUo6+jFo0XIzLQaCO3Wcevb0AxIRy+JGvmya/wdzeq/Y PtcJa2qOQz5Gltb1lsZs7GAAM5owVXsURAqO/48/Wh8vCQCBTplae2VCm5e0FJiM YarXECPCzVmbr5OeKiu3x9TLWhKzQ3f1+UnEPGzw9yETcR1T78B4ubaba0kQO5WF SmexHH/Sa+BQSIMmVSUTsScKF5sdpWz99s/ungqRkZB6Ewr4t9DD/eKRLpeqdH2H yV2oBCIxHGXt11Zp5W5iG2Rq0dDfAZW+aJYT5gSH4WCJMqDQeV0/L0vktTkBCUGU rGbCUoCRX0gvHkAhy1MA7DsYDqTr2XelwjJuaFQiNyC6Uxmz4BSfD+Fuhpr9Bk0O ViECFmLh =SS/K -----END PGP SIGNATURE----- --Uk2UE2pd7Rkq17gh--