From: Tom Rini <trini@konsulko.com>
To: "Pali Rohár" <pali@kernel.org>,
"Matthias Winker" <matthias.winker@de.bosch.com>,
"Philip Oberfichtner" <pro@denx.de>,
"Jagan Teki" <jagan@amarulasolutions.com>,
"Raffaele RECALCATI" <raffaele.recalcati@bticino.it>,
"Simone CIANNI" <simone.cianni@bticino.it>
Cc: Simon Glass <sjg@chromium.org>, u-boot@lists.denx.de
Subject: Re: [PATCH u-boot 2/2] tools: default_image: Accept images with padding
Date: Mon, 6 Feb 2023 14:43:07 -0500 [thread overview]
Message-ID: <Y+FYS4fwaTtxuXMU@bill-the-cat> (raw)
In-Reply-To: <20230129164411.9795-2-pali@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
On Sun, Jan 29, 2023 at 05:44:11PM +0100, Pali Rohár wrote:
> If image file is stored on flash partition then it contains padding, which
> is not part of the image itself. Image data size is stored in the image
> header. So use image size from the header instead of expecting that total
> image file size is size of the header plus size of the image data. This
> allows dumpimage to parse image files with padding (e.g. dumped from flash
> partition).
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>
This breaks imx6q_bosch_acc imx6dl_mamoj as:
./tools/mkimage: Failed to verify header of u-boot-ivt.img
now happens.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-02-06 19:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 16:44 [PATCH u-boot 1/2] tools: default_image: Verify header size Pali Rohár
2023-01-29 16:44 ` [PATCH u-boot 2/2] tools: default_image: Accept images with padding Pali Rohár
2023-01-30 15:50 ` Simon Glass
2023-02-06 19:43 ` Tom Rini [this message]
2023-02-06 21:47 ` Pali Rohár
2023-02-07 16:53 ` Tom Rini
2023-02-06 22:00 ` Simon Glass
2023-01-30 15:50 ` [PATCH u-boot 1/2] tools: default_image: Verify header size Simon Glass
2023-02-07 16:52 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+FYS4fwaTtxuXMU@bill-the-cat \
--to=trini@konsulko.com \
--cc=jagan@amarulasolutions.com \
--cc=matthias.winker@de.bosch.com \
--cc=pali@kernel.org \
--cc=pro@denx.de \
--cc=raffaele.recalcati@bticino.it \
--cc=simone.cianni@bticino.it \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox