From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BD88C636D3 for ; Mon, 6 Feb 2023 19:43:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4ECAA85CEB; Mon, 6 Feb 2023 20:43:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="NBbRNMWo"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A4D0D860D9; Mon, 6 Feb 2023 20:43:14 +0100 (CET) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7D08D85CEB for ; Mon, 6 Feb 2023 20:43:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x834.google.com with SMTP id 5so4259323qtp.9 for ; Mon, 06 Feb 2023 11:43:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qOEYAETIPRfPPWSSSOblr52a0SK7zalgkBrPI7vnAQM=; b=NBbRNMWojLyhoZKqb+nOzCvoFpcAsu7lwW6v0JnKuRT72eBRZNhRa3ev238SfdXOdr es7qVgWoa76eyrKxx4ErCFOXXzUkwiv+BtuFTcsXD4/VIZjKmePDfdIRd5poaUWwIZvc O/o3LXnXCVpM/2Ig3PlrJ4hFChZG2Axk+Zkug= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qOEYAETIPRfPPWSSSOblr52a0SK7zalgkBrPI7vnAQM=; b=SWEzBKvv9ipqQPbLrZAT5oLReDZsvyihhf3+LOGu2DIA4BmL/HxAHADvel5ciA4Zgu L1DHXh9YZy0TYHpnvZ4petNi6x4TyvKTunOb+Tvc+/cv+W11m8pCSU0GP9nVx/Wy8xON 7A73uXjI5NQaIbZ49g/UWxxPWLn9ZbWlpCXcgf80dvfPY/8I8Ej2RinsQ7+ea4mhpoPo LaFImG1q0ugrFfEX+GI1cqPga/Gsx0hUZrcMSGgBCQTS2e7RFQI2VCvo+vX/3UpVG7Rt p/YsCsA9WKENvO8Hy/RI5HBh1Un31a6p3ZXGi5uU3/SewHe/g91rkoQ9Yl0gwRtxkzOx e5Bg== X-Gm-Message-State: AO0yUKWCK8RtNpcH9823AZgXMB+cLaxLQ2f3n76MGX0qnLRVn+3snRAJ FP+Dn5BHN4BoS6knK46KY6iNSQ== X-Google-Smtp-Source: AK7set9x3Pf4sZl2/xES9ZQszmeBO05xfqCMcZheGQT8KyHJ7GRYsuRNqhIfNcPdHCUUZY6lnpaZeA== X-Received: by 2002:a05:622a:50e:b0:3b8:57a7:7836 with SMTP id l14-20020a05622a050e00b003b857a77836mr878322qtx.46.1675712590202; Mon, 06 Feb 2023 11:43:10 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-7624-7f8a-2088-981c.res6.spectrum.com. [2603:6081:7b00:6400:7624:7f8a:2088:981c]) by smtp.gmail.com with ESMTPSA id b19-20020a05620a271300b0071a291f0a4asm8103106qkp.27.2023.02.06.11.43.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 11:43:09 -0800 (PST) Date: Mon, 6 Feb 2023 14:43:07 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= , Matthias Winker , Philip Oberfichtner , Jagan Teki , Raffaele RECALCATI , Simone CIANNI Cc: Simon Glass , u-boot@lists.denx.de Subject: Re: [PATCH u-boot 2/2] tools: default_image: Accept images with padding Message-ID: References: <20230129164411.9795-1-pali@kernel.org> <20230129164411.9795-2-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Mb6rp2RTJo+2Dwpb" Content-Disposition: inline In-Reply-To: <20230129164411.9795-2-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --Mb6rp2RTJo+2Dwpb Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 29, 2023 at 05:44:11PM +0100, Pali Roh=E1r wrote: > If image file is stored on flash partition then it contains padding, which > is not part of the image itself. Image data size is stored in the image > header. So use image size from the header instead of expecting that total > image file size is size of the header plus size of the image data. This > allows dumpimage to parse image files with padding (e.g. dumped from flash > partition). >=20 > Signed-off-by: Pali Roh=E1r > Reviewed-by: Simon Glass This breaks imx6q_bosch_acc imx6dl_mamoj as: =2E/tools/mkimage: Failed to verify header of u-boot-ivt.img now happens. --=20 Tom --Mb6rp2RTJo+2Dwpb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPhWEcACgkQFHw5/5Y0 tyy3gwv9G55wjR9qlQLHMrNEB678YiizwmSuTdSPjRhRVQouYJeucEje3csWyvhe rwlv7DGxzZmVuEz/XtpUFD72yskzqW9p0dB4NDoTfhiYx/rsXYhbtEalyfVok5ZM eMcrVzcWB/eu3/9IQU6/zVPijqfXx9c+Vsw+D/xSewTEnngd6/TRqFxBFSANMcLx Vscmr5FdHJwNGKQoASwFAWnfcRQ5cHqEqtgVCWtlib4uF4xY1e1XE/x78WCnESEs 5LFApLlVcpPlN9JKM3ne1H+TKo/ldq92OcZd7izWiQHEkGZ+c51goXqPP50zxS9g VPGZgYtd27BNDyljEi4Tq7VyWUUscnSdu0zHAUONoiW4Fc/IXK+Fo107BmoZbYfq ff62jZ9mRbedXLvr1huRYm3KOHmnbnL1u/n4s6/kScdP2PtQ/lqrgB23WgcdHcdf QGYjS31LNKoezvDo7vbqdKhbDzYSxbY3mS5HI09or8ZojdpZMhxNMv+g7OxxFnve lV9thP4B =6cd0 -----END PGP SIGNATURE----- --Mb6rp2RTJo+2Dwpb--