From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0CCDC61DA4 for ; Tue, 7 Feb 2023 01:36:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 482D185CFA; Tue, 7 Feb 2023 02:36:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="BEzox/uj"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1183B85CFF; Tue, 7 Feb 2023 02:36:11 +0100 (CET) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C608485CD0 for ; Tue, 7 Feb 2023 02:36:06 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82d.google.com with SMTP id c2so15198090qtw.5 for ; Mon, 06 Feb 2023 17:36:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bP+j+/EU2sTJFCb8w1TTfm6yPlaIkWdbpa5wxpcLwIw=; b=BEzox/ujfL/4FSXVQqZdEpaTQ0tr6r3x86HQxVVy/4Se1E3KKKpyGZk0Oh/POvAJPB wNIsAMIjfQGJrC31WHVYrND3u6bH0bxzfhMWz66jPZB/MDxSnDOSnJfAYvG9cqP8vPYD j0hkeiZKVLvd7XI4GDQoUOjFDvFohr4uqPQEg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bP+j+/EU2sTJFCb8w1TTfm6yPlaIkWdbpa5wxpcLwIw=; b=oLkdSClgDnbFVaiwlxYIFqviEex6GRFz8oJhVmBjatWm4teqpJPv1c+w0ZTIwoE0UV kB4gadpeIiFJcGc2lo5UpXBRMi4wEVXupLVrcpzdRPhDX9QydlfQAO0WZusJ4/d8Mjrf O+vnaMiYq75LIkhWy5hMCaB3zfnNbyO2/aJ+TKUxCTM+dpH/HET/wM1KRQTvEU0IoZZ4 Y9VCK8BlG0h9Izx9Kus8ONDbQZd14fJQYAjuX74IAf7ZkFF1cmfioV1z+BNUySfwyf9z MJBzH5CjJoMVu6YV/6lm0SvT0BHHmFatDwXLCH1wYgZSf5q+Mx7LvZtWfA9u3W7cfjcI t+fw== X-Gm-Message-State: AO0yUKWSh6cdO85GR1hwUAmTBhSiJNY8UEDDAdMracBmntE5LHHKXRZS bBlE/GIo6LoUMYm9TXeb5sve7g== X-Google-Smtp-Source: AK7set83dMisOyla5KR3OzQvFOrXGN4GtWhIxpA6jJGOjT3/oIhsqaxEvnlRcb7+WpBaW4cxxDDSiw== X-Received: by 2002:a05:622a:5ce:b0:3b7:ec70:30af with SMTP id d14-20020a05622a05ce00b003b7ec7030afmr2746722qtb.46.1675733765528; Mon, 06 Feb 2023 17:36:05 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-7494-fb31-9b5f-683c.res6.spectrum.com. [2603:6081:7b00:6400:7494:fb31:9b5f:683c]) by smtp.gmail.com with ESMTPSA id 17-20020ac85651000000b003b63a734434sm8308747qtt.52.2023.02.06.17.36.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 17:36:05 -0800 (PST) Date: Mon, 6 Feb 2023 20:36:02 -0500 From: Tom Rini To: Heinrich Schuchardt Cc: Simon Glass , U-Boot Mailing List Subject: Re: [PATCH v2 078/169] Correct SPL use of EFI_UNICODE_COLLATION_PROTOCOL2 Message-ID: References: <20230205224118.233425-63-sjg@chromium.org> <20230205224118.233425-79-sjg@chromium.org> <835558ba-c78f-f64a-3df5-4fffc2afa875@canonical.com> <38c821aa-b2c6-2bf3-d507-3928c4dc195b@canonical.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bpJXgn9k8HdQZmkX" Content-Disposition: inline In-Reply-To: <38c821aa-b2c6-2bf3-d507-3928c4dc195b@canonical.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --bpJXgn9k8HdQZmkX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 07, 2023 at 02:24:22AM +0100, Heinrich Schuchardt wrote: >=20 >=20 > On 2/7/23 00:38, Tom Rini wrote: > > On Tue, Feb 07, 2023 at 12:36:51AM +0100, Heinrich Schuchardt wrote: > > > On 2/5/23 23:39, Simon Glass wrote: > > > > This converts 1 usage of this option to the non-SPL form, since the= re is > > > > no SPL_EFI_UNICODE_COLLATION_PROTOCOL2 defined in Kconfig > > > >=20 > > > > Signed-off-by: Simon Glass > > > > --- > > > >=20 > > > > (no changes since v1) > > > >=20 > > > > lib/efi_loader/efi_root_node.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >=20 > > > > diff --git a/lib/efi_loader/efi_root_node.c b/lib/efi_loader/efi_ro= ot_node.c > > > > index 21a014d7c21..108c14b95bd 100644 > > > > --- a/lib/efi_loader/efi_root_node.c > > > > +++ b/lib/efi_loader/efi_root_node.c > > > > @@ -68,7 +68,7 @@ efi_status_t efi_root_node_register(void) > > > > &efi_guid_dt_fixup_protocol, > > > > &efi_dt_fixup_prot, > > > > #endif > > > > -#if CONFIG_IS_ENABLED(EFI_UNICODE_COLLATION_PROTOCOL2) > > > > +#if IS_ENABLED(CONFIG_EFI_UNICODE_COLLATION_PROTOCOL2) > > >=20 > > > I never received this patch in my inbox. Expect series with more than= 50 > > > mails not even to be copied to the spam folder. They are outright rej= ected > > > by my mail provider. > > >=20 > > > I cannot see any problem solved by this patch. Why did you send it? > >=20 > > You should look in to setting up lei to fetch the list then, as this is > > well explained in the cover letter. >=20 > lei =3D circle of flowers is what I find in a dictionary. Do I miss an > idiomatic expression? Yes, https://public-inbox.org/lei.html is a tool widely used in the kernel community, and also works for U-Boot as we're mirrored on lore.kernel.org. In short, it's what I'm using to download the mailing list now, without Google screwing up and putting some messages in the spam folder and then I miss them. Also nice when U-Boot gets cc'd on something later and it'll just pull the whole thread in from the other lists for me, for context. > The cover letter describes an observation but does not point out any prob= lem > relating to this observation. [snip to reorder] >=20 > Is anything wrong about this use of CONFIG_IS_ENABLED(EFI_LOADER)? >=20 > What is the reasoning behind wanting to use CONFIG_IS_ENABLED() only if an > SPL config option exists? We have two macros, IS_ENABLED(CONFIG_FOO) and CONFIG_IS_ENABLED(FOO). The case where we use CONFIG_IS_ENABLED(FOO) and CONFIG_SPL_FOO (or _TPL_ or _VPL_) is not a valid symbol AND it makes sense to use CONFIG_IS_ENABLED(FOO) because we need to have the test evaluate to false because IS_ENABLED(CONFIG_FOO) would be true but we can rely on CONFIG_SPL_FOO being false due to being undefined is, on the whole, very rare. In specifics however, code supporting the EFI loader subsystem makes use of this because as for example yes, we modify printf related code. So that needs to be tested with CONFIG_IS_ENABLED(). However, in the example here never will we ever build lib/efi_loader/efi_root_node.c outside of the main U-Boot case, so we should be testing via IS_ENABLED(). [paste to re-order] > We don't have a CONFIG_SPL_EFI_LOADER. In vsnprintf_internal() we use > CONFIG_IS_ENABLED(EFI_LOADER). The code inside the #if condition is not > compiled in SPL. This is the desired behavior. >=20 > How is moveconfig meant to accept this? [back in order] > Where is the documentation change describing that CONFIG_IS_ENABLED() sho= uld > only be used if an SPL config option exists? Yes, in the final related series that moves to a "split config" build. And if what's in there isn't enough, that series should get more. That's where CONFIG_IS_ENABLED(EFI_LOADER) in the vsprintf could would be handled because that series is where Simon removes CONFIG_IS_ENABLED(), adds more SPL_FOO def_bool n options, and moves to IS_ENABLED() for everything. And that series is still under discussion. However, the vast majority if CONFIG_IS_ENABLED(FOO) where SPL_FOO, etc, are never defined should be using IS_ENABLED(CONFIG_FOO). --=20 Tom --bpJXgn9k8HdQZmkX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPhqv8ACgkQFHw5/5Y0 tyzlDAv/QTbbwYvQ2gX8vyy51dXVzvQysZaAy/SO8fTv/ebl7ABa8U7S2NzaZpF9 iX0aF8lO1GiYgwTgbwDN3aLAn9bbWoHXWRKCS0hC0y7MFk9dGKh9E6h81CWu8Ryg 3TZkMEIEbBjISclDiVK+FQAu9J037QsmPk8vsJ4zYGIBNY07TOcZkhuro1sQSX/Q MOWU3KCZdtf5uy/3b9YIAwEaX2v2UrzGr9i3b7w2g1YTzIodUqso2VZIpczPtX8I za1reLFjmHDtTXxPGohuHs9ZUOSDnNUUubEIy+Lhq+eP5gQ46VJaQtFHJ3pAIg3a 2DArV3Zs+djCng166iXLiPbfGO473WmOWRSI/xOQ85oXg8jy4nlgZUyaZI7zW92U n3lIw7Twuq3iz9mQI3pT/t3+cgkqPk88VERaxPKFNd+467LMSrazWwu94qwy0ZPq eZD8Fjc+Fpwy6OVQdUdxkOqDejlScEa9tyfRs3mYJ0ql7Tb2JxJ8fsdEpa+/+Q6g hj0c2HIA =f8/h -----END PGP SIGNATURE----- --bpJXgn9k8HdQZmkX--