From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7757C636CC for ; Tue, 7 Feb 2023 16:30:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6B1D085E37; Tue, 7 Feb 2023 17:30:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="LJ3XUSsA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CC03D85E38; Tue, 7 Feb 2023 17:30:24 +0100 (CET) Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0002385E0A for ; Tue, 7 Feb 2023 17:30:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2e.google.com with SMTP id j9so9445795qvt.0 for ; Tue, 07 Feb 2023 08:30:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=StegFTXTsLrYcdkcBuAZL61KpqpKT6Gf/gBIqyj3zbk=; b=LJ3XUSsA1WRpjvf2dE/b0gvNjH0iB8n7iMTdFq8TnFkmxI3Ag2qLoJUc0xIKL8lhjP thbBCRhZP2TxX8JxRmuHxxgEUnr2SRJv9ajLgJMjNXplvsN2nj0BqCsjx8OZKuVATifN UmXjcBr8wWOFy23RrRXGTntW/RaoOMqsmdrBA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=StegFTXTsLrYcdkcBuAZL61KpqpKT6Gf/gBIqyj3zbk=; b=oDzyfNw2FAyDwbaU9+i9OPFyEGVyEjzrfuOnP2+sVlAu7bjfPFpQ6PzBkFZ6CkuP+l UDW5wUHoqUrakS1Qvg5o8++B7S/4HptnazVM8UgHYRXzFmmPpOxXmXzAkoInpWMPpzUu Q8eYdO62PUreh2bP2FOLlRPVg0HE/G9ykdcAyv7aBlAtdMUyZ3/Ouyq9cOxxsFkYRghx LlzQJ5eP/PrO/rRmvKqZ/+S77NDqQw/Cxtu1ABfxSawYSNHahKnnkqg/w3dtM4sftCF/ 1ByTuRR3nnE2f/Lrlb7rDecc/bnvgtbJMqU7t2i+/7TewgLBo3ae0dz/OfwVYtUuNcBT efWQ== X-Gm-Message-State: AO0yUKVbwJYHJniVdsajxkpMCax/inPvpnq6czJM353PPP9G41GwbDlp I3Xvqob6l5yRn8pi7hL4vaLkwA== X-Google-Smtp-Source: AK7set8TzIXpj2i5XQZz8OvDn7LDnx/2SOlH9B1IE2xhz7o9ZqWvYtthHvRF64ddFq5Xz5r+0Uzf3Q== X-Received: by 2002:ad4:5c67:0:b0:537:8d19:6b70 with SMTP id i7-20020ad45c67000000b005378d196b70mr7529112qvh.26.1675787420637; Tue, 07 Feb 2023 08:30:20 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-7494-fb31-9b5f-683c.res6.spectrum.com. [2603:6081:7b00:6400:7494:fb31:9b5f:683c]) by smtp.gmail.com with ESMTPSA id 190-20020a370bc7000000b0073513000ef2sm2007779qkl.29.2023.02.07.08.30.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 08:30:20 -0800 (PST) Date: Tue, 7 Feb 2023 11:30:18 -0500 From: Tom Rini To: Simon Glass Cc: abdellatif.elkhlifi@arm.com, u-boot@lists.denx.de, nd@arm.com Subject: Re: [PATCH v1 3/6] sandbox64: add support for NVMXIP QSPI Message-ID: References: <20230116172832.1946-1-abdellatif.elkhlifi@arm.com> <20230116172832.1946-4-abdellatif.elkhlifi@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wxrgexiuZqllcb24" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --wxrgexiuZqllcb24 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 06, 2023 at 09:02:38PM -0700, Simon Glass wrote: > On Mon, 16 Jan 2023 at 10:28, wrote: > > > > From: Abdellatif El Khlifi > > > > enable NVMXIP QSPI for sandbox 64-bit > > > > Adding two NVM XIP QSPI storage devices. > > > > Signed-off-by: Abdellatif El Khlifi > > --- > > arch/sandbox/dts/sandbox64.dts | 13 +++++++++++++ > > arch/sandbox/dts/test.dts | 14 ++++++++++++++ > > configs/sandbox64_defconfig | 1 + > > drivers/nvmxip/nvmxip.c | 4 ++++ > > drivers/nvmxip/nvmxip.h | 3 +++ > > 5 files changed, 35 insertions(+) >=20 > Reviewed-by: Simon Glass >=20 > Nit below >=20 > > > > diff --git a/arch/sandbox/dts/sandbox64.dts b/arch/sandbox/dts/sandbox6= 4.dts > > index a9cd7908f8..aed3801af8 100644 > > --- a/arch/sandbox/dts/sandbox64.dts > > +++ b/arch/sandbox/dts/sandbox64.dts > > @@ -89,6 +89,19 @@ > > cs-gpios =3D <0>, <&gpio_a 0>; > > }; > > > > + nvmxip-qspi1@08000000 { > > + compatible =3D "nvmxip,qspi"; > > + reg =3D <0x0 0x08000000 0x0 0x00200000>; > > + lba_shift =3D <9>; > > + lba =3D <4096>; > > + }; > > + > > + nvmxip-qspi2@08200000 { > > + compatible =3D "nvmxip,qspi"; > > + reg =3D <0x0 0x08200000 0x0 0x00100000>; > > + lba_shift =3D <9>; > > + lba =3D <2048>; > > + }; > > }; > > > > #include "sandbox.dtsi" > > diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts > > index dffe10adbf..c3ba0a225e 100644 > > --- a/arch/sandbox/dts/test.dts > > +++ b/arch/sandbox/dts/test.dts > > @@ -1745,6 +1745,20 @@ > > compatible =3D "u-boot,fwu-mdata-gpt"; > > fwu-mdata-store =3D <&mmc0>; > > }; > > + > > + nvmxip-qspi1@08000000 { > > + compatible =3D "nvmxip,qspi"; > > + reg =3D <0x08000000 0x00200000>; > > + lba_shift =3D <9>; > > + lba =3D <4096>; > > + }; > > + > > + nvmxip-qspi2@08200000 { > > + compatible =3D "nvmxip,qspi"; > > + reg =3D <0x08200000 0x00100000>; > > + lba_shift =3D <9>; > > + lba =3D <2048>; > > + }; > > }; > > > > #include "sandbox_pmic.dtsi" > > diff --git a/configs/sandbox64_defconfig b/configs/sandbox64_defconfig > > index ba45ac0b71..cd4dadb190 100644 > > --- a/configs/sandbox64_defconfig > > +++ b/configs/sandbox64_defconfig > > @@ -259,3 +259,4 @@ CONFIG_FWU_MULTI_BANK_UPDATE=3Dy > > CONFIG_UNIT_TEST=3Dy > > CONFIG_UT_TIME=3Dy > > CONFIG_UT_DM=3Dy > > +CONFIG_NVMXIP_QSPI=3Dy > > \ No newline at end of file > > diff --git a/drivers/nvmxip/nvmxip.c b/drivers/nvmxip/nvmxip.c > > index c276fb147e..ea9b9bfa48 100644 > > --- a/drivers/nvmxip/nvmxip.c > > +++ b/drivers/nvmxip/nvmxip.c > > @@ -87,6 +87,10 @@ int nvmxip_init(struct udevice *udev) > > priv_data->udev =3D udev; > > priv_data->plat_data =3D plat_data; > > > > +#if CONFIG_IS_ENABLED(SANDBOX64) >=20 > if (IS_ENABLED(CONFIG_SANDBOX64)) >=20 >=20 > > + sandbox_set_enable_memio(true); > > +#endif Isn't that just going to introduce a warning about undeclared function on non-sandbox64? --=20 Tom --wxrgexiuZqllcb24 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPifJoACgkQFHw5/5Y0 tyw4eQv/fcmWD6DLQC3rd7R4/SWoeGpx2ZL1+f3fGYLnGwyzmODJC7mhmEWGIHSH VStlYTKcS5hYaZbk3NQ+Chf2yIH2x+67Bgr5yBElI+SmVIFBpYRJjGM0rg5z31ar H9jdPGqdbQ3IZGjM7Mg+ctugHRXL6aUxXT/0CtS6Y22e38XAf6lJApL2yGqsWuYe xfBjHQRLS2qk7v7QMMkolFM2vMSxuGPTrN/KRZfdG0abU6WbGlbXQpYFlqO/isl8 FSyMzMNsmEbycf36GbH6Z/nj+tkO24icp9nZO2OR4NGldQhug/jcR1MK/Q/rzoId Cg0PgjkUvLzle7aFm5I0W8AMvC1YzOZjqAaMyCybohOUngMBU+WnB/JjjPkDtG8Q uGgsFzrEtm+7WGGmUmqfRa4Ahl/ZthCFmu7enWY+WzXm1mYmm0MfOLMoYUxCscGx g8TP/FT80e5xnUCBqssnYJ0qQ1OMFGBR6uuqJQawDKP3jA8D9y2Clfu0Vp2w31cv +OhGw75B =68Iz -----END PGP SIGNATURE----- --wxrgexiuZqllcb24--