From: Tom Rini <trini@konsulko.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: Simon Glass <sjg@chromium.org>, u-boot@lists.denx.de
Subject: Re: [PATCH u-boot 3/3] tools: imagetool: Skip autodetection of gpimage type
Date: Tue, 7 Feb 2023 11:53:15 -0500 [thread overview]
Message-ID: <Y+KB+64gUem3YblN@bill-the-cat> (raw)
In-Reply-To: <20230129164555.9940-3-pali@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 585 bytes --]
On Sun, Jan 29, 2023 at 05:45:55PM +0100, Pali Rohár wrote:
> gpimage type requires only that two first 32-bit words of data file are
> non-zero. So basically every random data file can be guessed and verified
> as gpimage. So completely skip gpimage type from image autodetection code
> to prevent lot of false positive results. Data file with gpimage type can
> be still verified and parsed by explicitly specifying -T gpimage.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-02-07 16:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 16:45 [PATCH u-boot 1/3] tools: imagetool: Fix error message when verify_header is undefined Pali Rohár
2023-01-29 16:45 ` [PATCH u-boot 2/3] tools: imagetool: Show error message when detecting image type failed Pali Rohár
2023-02-07 16:53 ` Tom Rini
2023-01-29 16:45 ` [PATCH u-boot 3/3] tools: imagetool: Skip autodetection of gpimage type Pali Rohár
2023-01-30 15:50 ` Simon Glass
2023-01-30 18:02 ` Tom Rini
2023-02-03 19:24 ` Pali Rohár
2023-02-03 20:23 ` Tom Rini
2023-02-07 16:53 ` Tom Rini [this message]
2023-01-30 15:50 ` [PATCH u-boot 1/3] tools: imagetool: Fix error message when verify_header is undefined Simon Glass
2023-02-07 16:53 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+KB+64gUem3YblN@bill-the-cat \
--to=trini@konsulko.com \
--cc=pali@kernel.org \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox