From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1256AC636CC for ; Tue, 7 Feb 2023 16:56:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DE47F85F17; Tue, 7 Feb 2023 17:52:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="bAMdDuaK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 10F0285E94; Tue, 7 Feb 2023 17:51:58 +0100 (CET) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1666C85F01 for ; Tue, 7 Feb 2023 17:51:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82f.google.com with SMTP id v17so17422862qto.3 for ; Tue, 07 Feb 2023 08:51:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=c+IXGwpHwWn/R4vXaEjQp4wwhLKns+ZV90raSKoFNE0=; b=bAMdDuaK8u/dAZpXkP4NaJIto3cdCU2R3DVMpvjVfh+rEBlquf2HRxXpohGYNQANq9 sVYLreil+5J9QymPbldSxFfxYVN9XcEqBjB3kjp/16v/oxc3C13Vw7TNwcBQW794o2Zq cj39c75nWlyaXE+ed29xb1EmaPRhPRsRR0lk0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=c+IXGwpHwWn/R4vXaEjQp4wwhLKns+ZV90raSKoFNE0=; b=WGPMj2bFauuhXCxmIs87KMEvVHkpp6v2CVKJ6YEk0F1vrZKJ5wlP5e2vpFEooS6H3E P2Ni0U8joHNpjSmB2OhPncTjUN50ntSJK9NlcdD/zIOKllr8BCnloes8GycHM4RXsRP0 R1EEMpxVWGfrz6/empmXi6+PUUK+YyD+8Z+quWubGIfCngjtN2Cwc3hKvCHKOTURQjHN 1JsAC+dVOEpYJFdI2zAwPdp3TVp7hXxxGUHYcg3ScnpNyydhlJ8e9W6Yv1cZfdttYr5y lRaWAp7zw11iD0IGQLKzqYuUFKWRJxuOwmBMLWSpsC/rchV7TO31YW780218mvBKf8cQ uA1Q== X-Gm-Message-State: AO0yUKUz6IJMTB1BtiSlB+GbdM+jd8j63S6oOhRAGZt/mOCZXwJ5LrIK RY3GFMg0gx4GcP5Wuoz2aaEowcTcJBXp90kzbpo= X-Google-Smtp-Source: AK7set+NvOpj1J1zBpnt2AuPOAxsxhdgNHEgEdmNJVeunCibgh4Fxu0CLnXMpIJZi4K/YFtJI3J8Sg== X-Received: by 2002:ac8:5c8a:0:b0:3b9:da90:ebee with SMTP id r10-20020ac85c8a000000b003b9da90ebeemr6762305qta.30.1675788712630; Tue, 07 Feb 2023 08:51:52 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-7494-fb31-9b5f-683c.res6.spectrum.com. [2603:6081:7b00:6400:7494:fb31:9b5f:683c]) by smtp.gmail.com with ESMTPSA id b24-20020a05620a0f9800b0071ba3799334sm9730051qkn.58.2023.02.07.08.51.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 08:51:52 -0800 (PST) Date: Tue, 7 Feb 2023 11:51:50 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Albert Aribaud , Ilias Apalodimas , Bin Meng Subject: Re: [PATCH 05/13] bootstd: Correct virtio block-device handling Message-ID: References: <20230128220028.53575-1-sjg@chromium.org> <20230128220028.53575-6-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="h1KP2DzhjKc0Sj8g" Content-Disposition: inline In-Reply-To: <20230128220028.53575-6-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --h1KP2DzhjKc0Sj8g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 28, 2023 at 03:00:20PM -0700, Simon Glass wrote: > At present virtio tries to attach QEMU services to a bootdev device, which > cannot work. Add a check for this. >=20 > Also use bootdev_setup_sibling_blk() to create the bootdev device, since > it allows the correct name to be used and bootdev_get_sibling_blk() to > work as expected. >=20 > The bootdev is not created on sandbox since it does have a real virtio > device and it is not possible to read blocks. >=20 > Signed-off-by: Simon Glass > Fixes: a60f7a3e35b ("bootstd: Add a virtio bootdev") > Reported-by: Ilias Apalodimas Applied to u-boot/master, thanks! --=20 Tom --h1KP2DzhjKc0Sj8g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPigaYACgkQFHw5/5Y0 tywFSwwAix3o93wZQ0kcrqXigUITjMevv+MhgQIlzKz16xH10wP5itbG79s4L9St LAF2ecXo8GZ1i+zAf2g0+yEbj387UIMwl0y/EnmkQmXaeDxpJ8fEE3B/kAwjEES6 naI+IANe5Sdi/0uCcRfHpF6TAENj1Af7Ji3o4axjQ5wn65Kx6O2YuZu+VPkdrIWJ 7HJLfYOM3g580HncdacsFHlQvBHerYnt/jbvDZp18ONS250bZ/VQSqkHK0dwRW3U KxYlfZ3dIwwvK/Seh0Tgd24CC3VbGiQNDSnMWb7knppZqVR7S4nx16Ukwtzr1U1X W3kOKaIQ8fNQaktWqkVnbFRir6IXq5rELqmCuoQ02Pvz8WQtM3lJNAHAjXgh/ocW Ck31WwPz3nLVbxzU6yxEAJKUAoL46+LRcdxwI7YbNF9m8A3tWBHSsFXab2swScDU +Iucm6GPPaNxZRuARQoLq1CGAwum5nj+3fsVuYyKjdZqY4TPdEQemzEFCff4D1YK KgJJbpW8 =JXvD -----END PGP SIGNATURE----- --h1KP2DzhjKc0Sj8g--