From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E7E8C61DA4 for ; Thu, 9 Feb 2023 15:55:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CB29E85B89; Thu, 9 Feb 2023 16:55:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="p8N2XKpH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7194085B89; Thu, 9 Feb 2023 16:55:21 +0100 (CET) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6725085F38 for ; Thu, 9 Feb 2023 16:55:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82a.google.com with SMTP id m12so2399442qth.4 for ; Thu, 09 Feb 2023 07:55:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Tczfxn40+uaZ2pd6uo3HuLMnj5OVSJOcqMlQApMCKZU=; b=p8N2XKpHwABpTJGgA2CLkTDw/JapOru59ftnxV64ZIncGRm9yRXTWHU8JC1tPV/xrz GcHaOzYTdGfbQIvGhI3J9/PQcKDg6766H5vaM5+9/9OW1SWjE1OYWss8ONtSdy3pnfrz K6k2zSQQeMOtjPHAsFy3cHfqtAp+r/c2UgZlU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Tczfxn40+uaZ2pd6uo3HuLMnj5OVSJOcqMlQApMCKZU=; b=KJoLBZexASpIGXv8DxxjnrKRj7VVBZg7dXTV/ryyxSAbURjjh0rMpARTdDMut/EPus 9Fk+sJaUULWGRTh93gmaewebncSeBVk+iaieVvWU/sDE05fZkjmzU8q3tXOofw+xmriy r17XZYOnMwvvlHfC+Qnze1sztuf7FbL/nLydNjSzd5qKpMENtiRGDvPMSmu+D6r2G2uU JY//zhcvD7ZDRg6lN3BFb40tS8ml8mCqqTLBv1qrRKAJu5geb1lZaF5gslHFVCtpBvp/ W2DyiWMmEfeUuUHZYGLBDOKoQOwVUmo2AsfDVd10UfnlXgcLURrjiG5Jvo8tQ4Epu8FP cSeA== X-Gm-Message-State: AO0yUKU6mfnYgBBL9x02QDE+6BqiQvM+s+3/94y10OaGKcNubHpkSPXg /qYptsLArGICyDeo8Mcw3pIOWH1XMsLjFAv4GEo= X-Google-Smtp-Source: AK7set8KLVnG6x8kLcbYVKxn4FUHvXlGL+eo9/OognT7g4NHnjXX6Gtio0SNXSP8WY8+INIcNYan2w== X-Received: by 2002:ac8:5b51:0:b0:3ae:2272:e43c with SMTP id n17-20020ac85b51000000b003ae2272e43cmr19253040qtw.29.1675958107148; Thu, 09 Feb 2023 07:55:07 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-538d-baa1-e57f-2a07.res6.spectrum.com. [2603:6081:7b00:6400:538d:baa1:e57f:2a07]) by smtp.gmail.com with ESMTPSA id m16-20020ac866d0000000b003b9bf862c04sm1500908qtp.55.2023.02.09.07.55.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 07:55:06 -0800 (PST) Date: Thu, 9 Feb 2023 10:55:05 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List Subject: Re: [PATCH v2 041/169] Correct SPL uses of CMD_DHCP Message-ID: References: <20230205223836.231657-1-sjg@chromium.org> <20230205223836.231657-42-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dWREJW8jmK0k/xgd" Content-Disposition: inline In-Reply-To: <20230205223836.231657-42-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --dWREJW8jmK0k/xgd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 05, 2023 at 03:36:27PM -0700, Simon Glass wrote: > This converts 7 usages of this option to the non-SPL form, since there is > no SPL_CMD_DHCP defined in Kconfig >=20 > Signed-off-by: Simon Glass > --- >=20 > (no changes since v1) >=20 > include/configs/am335x_evm.h | 2 +- > include/configs/imx8mm-cl-iot-gate.h | 2 +- > include/configs/imx8mp_rsb3720.h | 2 +- > include/configs/j721e_evm.h | 2 +- > include/configs/qemu-arm.h | 2 +- > include/configs/rockchip-common.h | 2 +- > include/configs/rpi.h | 2 +- > 7 files changed, 7 insertions(+), 7 deletions(-) So this, and a few other CMD cases are special. We have in SPL, ENV_NOWHERE for various good and valid use cases. So we want to limit the size of the default environment. We also use the generic distro bootcmd framework on these boards. So CONFIG_IS_ENABLED(CMD_FOO) gets used to nop out the boot targets we don't need taking up space. It's not a fatal problem to change these, but I'm not going to pick these changes up just yet. --=20 Tom --dWREJW8jmK0k/xgd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPlF08ACgkQFHw5/5Y0 tyw/bgwAumrVyGpzsHyfV23j7/GjBOmtZcxDJ2OTfVhT5Gc+wm9u6R2x8E+wZMDD hw4cliYmagU6RwNnHnLa+2qQAwHdD3Asfv0QMi+rJmWkNeLRZnhoMYGEyyGADUgC rIiotIrtUzpeRG29V2g4xJxwHaZIDL4O0d7+MQRnLX0vx3F3umvnwwtv2uMrDHKH d91AbVXzbIAMLmqrErrncDoVzIGpDC/g4LftLZpu4wx5nLt0YPcpaNNM6TETz9Bh cFtyHySvgKI/Wh36iz9YEHTwCL+oGO0lZjIjBHstaZQ+xmniXKBwPP6QHv5xLH2M zdwUklIirxYwjqQfQkVhZs6LBKw+h9PB0D/TqLo09tGRXwKrqG9V6yYxiAycidaF e3F9gLy1/33bjpOMX0jkIbyIkJ1fmcOPElsUjLyHiwlGSKo/qHYN2nzEOvzerb/c xtgqxnRwJ2K5vXBvzZnPMADzKwO+3F2Rl1MhQJi3990HK5oRtaizwgWIhePsE0K2 FeBXiwfk =P5ng -----END PGP SIGNATURE----- --dWREJW8jmK0k/xgd--