From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>, Stefan Roese <sr@denx.de>
Subject: Re: [PATCH v2 025/169] Correct SPL uses of ARCH_MVEBU
Date: Thu, 9 Feb 2023 12:23:22 -0500 [thread overview]
Message-ID: <Y+UsChVkoTDsmISA@bill-the-cat> (raw)
In-Reply-To: <20230205223836.231657-26-sjg@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 1415 bytes --]
On Sun, Feb 05, 2023 at 03:36:11PM -0700, Simon Glass wrote:
> This converts 2 usages of this option to the non-SPL form, since there is
> no SPL_ARCH_MVEBU defined in Kconfig
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> (no changes since v1)
>
> drivers/mmc/mv_sdhci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/mv_sdhci.c b/drivers/mmc/mv_sdhci.c
> index 336ebf14102..20049981473 100644
> --- a/drivers/mmc/mv_sdhci.c
> +++ b/drivers/mmc/mv_sdhci.c
> @@ -64,7 +64,7 @@ int mv_sdh_init(unsigned long regbase, u32 max_clk, u32 min_clk, u32 quirks)
> host->ops = &mv_ops;
> #endif
>
> - if (CONFIG_IS_ENABLED(ARCH_MVEBU)) {
> + if (IS_ENABLED(CONFIG_ARCH_MVEBU)) {
> /* Configure SDHCI MBUS mbus bridge windows */
> sdhci_mvebu_mbus_config((void __iomem *)regbase);
> }
> @@ -103,7 +103,7 @@ static int mv_sdhci_probe(struct udevice *dev)
> if (ret)
> return ret;
>
> - if (CONFIG_IS_ENABLED(ARCH_MVEBU)) {
> + if (IS_ENABLED(CONFIG_ARCH_MVEBU)) {
> /* Configure SDHCI MBUS mbus bridge windows */
> sdhci_mvebu_mbus_config(host->ioaddr);
> }
So, a number of mvebu platforms now grow their SPL here, which is (a) a
functional change and (b) implies it's intentional. I'm adding Stefan
here to start to get a better handle on if this really should be like
this, or not.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-02-09 17:23 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 22:35 [PATCH v2 000/169] Kconfig: More cleanup of CONFIG options Simon Glass
2023-02-05 22:35 ` [PATCH v2 001/169] moveconfig: Update to detect / correct missing SPL Kconfigs Simon Glass
2023-02-05 22:35 ` [PATCH v2 002/169] x86: Correct Chrromebook typo Simon Glass
2023-02-05 22:35 ` [PATCH v2 003/169] boot: Add a Kconfig for SPL_FIT_CIPHER Simon Glass
2023-02-05 22:35 ` [PATCH v2 004/169] boot: Add a Kconfig for SPL_BOOTSTD_FULL Simon Glass
2023-02-06 15:14 ` Tom Rini
2023-02-06 17:19 ` Simon Glass
2023-02-06 18:32 ` Tom Rini
2023-02-06 19:05 ` Simon Glass
2023-02-05 22:35 ` [PATCH v2 005/169] boot: Add Kconfigs for BOOTMETH_VBE_REQUEST Simon Glass
2023-02-05 22:35 ` [PATCH v2 006/169] boot: Add a Kconfig for SPL_BOOTDEV_SPI_FLASH Simon Glass
2023-02-05 22:35 ` [PATCH v2 007/169] boot: Add a Kconfig for SPL_BOOTDEV_ETH Simon Glass
2023-02-05 22:35 ` [PATCH v2 008/169] dm: Add a Kconfig for SPL_DEVRES Simon Glass
2023-02-05 22:35 ` [PATCH v2 009/169] dm: Add a Kconfig for SPL_DM_HWSPINLOCK Simon Glass
2023-02-05 22:35 ` [PATCH v2 010/169] boot: Add a Kconfig for SPL_OF_LIVE Simon Glass
2023-02-05 22:35 ` [PATCH v2 011/169] cmd: Add a Kconfig for SPL_CRC32_VERIFY Simon Glass
2023-02-05 22:35 ` [PATCH v2 012/169] console: Add a Kconfig for SPL_CONSOLE_MUX et al Simon Glass
2023-02-05 22:35 ` [PATCH v2 013/169] button: Add a Kconfig for SPL_BUTTON Simon Glass
2023-02-05 22:36 ` [PATCH v2 014/169] lib: Add a Kconfig for SPL_ERRNO_STR Simon Glass
2023-02-05 22:36 ` [PATCH v2 015/169] iommu: Add a Kconfig for SPL_IOMMU Simon Glass
2023-02-05 22:36 ` [PATCH v2 016/169] pinctrl: Add a Kconfig for SPL_PINCTRL_ARMADA_38X Simon Glass
2023-02-05 22:36 ` [PATCH v2 017/169] virtio: Add a Kconfig for SPL_VIRTIO Simon Glass
2023-02-05 22:36 ` [PATCH v2 018/169] lib: Add a Kconfig for SPL_BZIP2 Simon Glass
2023-02-05 22:36 ` [PATCH v2 019/169] acpi: Add a Kconfig for SPL_ACPIGEN Simon Glass
2023-02-05 22:36 ` [PATCH v2 020/169] rockchip: Add a Kconfig for SPL_RESET_ROCKCHIP Simon Glass
2023-02-05 22:36 ` [PATCH v2 021/169] mediatek: Add a Kconfig for SPL_RESET_MEDIATEK Simon Glass
2023-02-05 22:36 ` [PATCH v2 022/169] Correct SPL use of A003399_NOR_WORKAROUND Simon Glass
2023-02-05 22:36 ` [PATCH v2 023/169] Correct SPL use of AHCI Simon Glass
2023-02-05 22:36 ` [PATCH v2 024/169] Correct SPL uses of ALLEYCAT_5 Simon Glass
2023-02-05 22:36 ` [PATCH v2 025/169] Correct SPL uses of ARCH_MVEBU Simon Glass
2023-02-09 17:23 ` Tom Rini [this message]
2023-02-10 12:22 ` Stefan Roese
2023-02-05 22:36 ` [PATCH v2 027/169] Correct SPL use of ARCH_ZYNQ Simon Glass
2023-02-05 22:36 ` [PATCH v2 028/169] Correct SPL use of ARM64 Simon Glass
2023-02-05 22:36 ` [PATCH v2 029/169] Correct SPL uses of ARMADA_3700 Simon Glass
2023-02-05 22:36 ` [PATCH v2 030/169] Correct SPL uses of ARMADA_8K Simon Glass
2023-02-05 22:36 ` [PATCH v2 031/169] Correct SPL use of ATMEL_PIO4 Simon Glass
2023-02-09 17:36 ` Tom Rini
2023-02-10 7:25 ` Eugen Hristev
2023-02-10 12:41 ` Tom Rini
2023-02-10 12:47 ` Eugen Hristev
2023-02-05 22:36 ` [PATCH v2 032/169] Correct SPL use of BNXT_ETH Simon Glass
2023-02-05 22:36 ` [PATCH v2 033/169] Correct SPL use of BOOTSTAGE_FDT Simon Glass
2023-02-05 22:36 ` [PATCH v2 034/169] Correct SPL uses of BOOTSTAGE_REPORT Simon Glass
2023-02-05 22:36 ` [PATCH v2 035/169] Correct SPL use of CMD_BCB Simon Glass
2023-02-05 22:36 ` [PATCH v2 037/169] Correct SPL use of CMD_BOOTI Simon Glass
2023-02-05 22:36 ` [PATCH v2 038/169] Correct SPL uses of CMD_BOOTM_PRE_LOAD Simon Glass
2023-02-05 22:36 ` [PATCH v2 039/169] Correct SPL use of CMD_BOOTZ Simon Glass
2023-02-05 22:36 ` [PATCH v2 040/169] Correct SPL uses of CMD_CLK Simon Glass
2023-02-05 22:36 ` [PATCH v2 041/169] Correct SPL uses of CMD_DHCP Simon Glass
2023-02-09 15:55 ` Tom Rini
2023-02-05 22:36 ` [PATCH v2 042/169] Correct SPL uses of CMD_EFICONFIG Simon Glass
2023-02-05 22:36 ` [PATCH v2 043/169] Correct SPL use of CMD_ERASEENV Simon Glass
2023-02-05 22:36 ` [PATCH v2 044/169] Correct SPL uses of CMD_FDT Simon Glass
2023-02-05 22:36 ` [PATCH v2 045/169] Correct SPL use of CMD_FRU Simon Glass
2023-02-05 22:36 ` [PATCH v2 046/169] Correct SPL use of CMD_HASH Simon Glass
2023-02-05 22:36 ` [PATCH v2 047/169] Correct SPL use of CMD_MBR Simon Glass
2023-02-05 22:36 ` [PATCH v2 048/169] Correct SPL uses of CMD_MMC Simon Glass
2023-02-05 22:36 ` [PATCH v2 049/169] Correct SPL use of CMD_NET Simon Glass
2023-02-05 22:36 ` [PATCH v2 050/169] Correct SPL use of CMD_NVEDIT_EFI Simon Glass
2023-02-05 22:36 ` [PATCH v2 051/169] Correct SPL uses of CMD_NVME Simon Glass
2023-02-05 22:36 ` [PATCH v2 052/169] Correct SPL use of CMD_PSTORE Simon Glass
2023-02-05 22:36 ` [PATCH v2 053/169] Correct SPL uses of CMD_PXE Simon Glass
2023-02-05 22:36 ` [PATCH v2 054/169] Correct SPL uses of CMD_SCSI Simon Glass
2023-02-05 22:36 ` [PATCH v2 055/169] Correct SPL uses of CMD_SF Simon Glass
2023-02-05 22:36 ` [PATCH v2 056/169] Correct SPL use of CMD_SHA1SUM Simon Glass
2023-02-05 22:36 ` [PATCH v2 057/169] Correct SPL use of CMD_STBOARD Simon Glass
2023-02-05 22:36 ` [PATCH v2 058/169] Correct SPL use of CMD_STM32PROG Simon Glass
2023-02-05 22:36 ` [PATCH v2 059/169] Correct SPL uses of CMD_TFTPPUT Simon Glass
2023-02-05 22:36 ` [PATCH v2 060/169] Correct SPL uses of CMD_USB Simon Glass
2023-02-05 22:36 ` [PATCH v2 061/169] Correct SPL use of CMD_VIRTIO Simon Glass
2023-02-10 15:17 ` [PATCH v2 000/169] Kconfig: More cleanup of CONFIG options Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+UsChVkoTDsmISA@bill-the-cat \
--to=trini@konsulko.com \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox