From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBB3DC61DA4 for ; Thu, 9 Feb 2023 17:23:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 405FB85D58; Thu, 9 Feb 2023 18:23:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="RyuNoWYs"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E689485D56; Thu, 9 Feb 2023 18:23:28 +0100 (CET) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 46AC585D58 for ; Thu, 9 Feb 2023 18:23:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82c.google.com with SMTP id g18so2753355qtb.6 for ; Thu, 09 Feb 2023 09:23:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5jhf/Q/Zkgfxvz+T7PJTXKkjrtLXapR4EyNTAO8OCwk=; b=RyuNoWYskPxDCkWjzLbVN8ylGJXFJkBNOXMzT2A4LthXxO8Z30wp9ZoNk74ZSUeYtg DUJj2Cq7AlOUSHvEKxEsmu2ytU3LYncA9R1es3JiSs9GGdk3xnBshqCf23qspcbOR7r6 8U28aHaWpDhbrxDMTPUpjEXDi1eq5ihJSZvMM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5jhf/Q/Zkgfxvz+T7PJTXKkjrtLXapR4EyNTAO8OCwk=; b=SihrVChYop/JEzUaHrWTVJ/YjztqQ9yZ46MUzsw9QX8y9q5f9g4l6C+SpEjjDsolOQ t0oNidfcPfKfzRHb5YALomyALsqy1rJHaQ5hjZbU5lel06c39zLhRCp5NOhhIKhrKKZj IjcAy0qWTMRsJQQrDc8T9cYFXUURFcAx7x8mrCQeM4BPfS9vyIIktlvMQLb0u01hJJgi cQNrH/mnPH7pSbwItWE7xhdKVVOOLuzQ0iUUiqw1SUhLuLcH3dGY21jul/uCBa2i9mZn 4cYUKJUxm0TDwTgHzjVk9vRPjyUnJnPD2Dh4TUEcyOeGZ4FgFvTsCeSp2to4OtCeIgyH k/vQ== X-Gm-Message-State: AO0yUKWw9SC6iaBY9/p3krGIx5HpVDOVdFCHjsZzXyC/yDXxjZ2S+j2C 2YgkaxPaK523zedgZlzBPJGTDA== X-Google-Smtp-Source: AK7set98oUGZc8dofHa9FJFpWVoVhKQ5X1+QrQ2SGcqvuPa9EnGgkbhFZynBMvs5D36Xh35Wxu5qhA== X-Received: by 2002:ac8:5350:0:b0:3b9:bd8d:bb22 with SMTP id d16-20020ac85350000000b003b9bd8dbb22mr4311270qto.14.1675963404998; Thu, 09 Feb 2023 09:23:24 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-538d-baa1-e57f-2a07.res6.spectrum.com. [2603:6081:7b00:6400:538d:baa1:e57f:2a07]) by smtp.gmail.com with ESMTPSA id c193-20020ae9edca000000b007389403f7e6sm1799223qkg.9.2023.02.09.09.23.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 09:23:24 -0800 (PST) Date: Thu, 9 Feb 2023 12:23:22 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Stefan Roese Subject: Re: [PATCH v2 025/169] Correct SPL uses of ARCH_MVEBU Message-ID: References: <20230205223836.231657-1-sjg@chromium.org> <20230205223836.231657-26-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XSz3mxmzTAIV7ZWD" Content-Disposition: inline In-Reply-To: <20230205223836.231657-26-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --XSz3mxmzTAIV7ZWD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 05, 2023 at 03:36:11PM -0700, Simon Glass wrote: > This converts 2 usages of this option to the non-SPL form, since there is > no SPL_ARCH_MVEBU defined in Kconfig >=20 > Signed-off-by: Simon Glass > --- >=20 > (no changes since v1) >=20 > drivers/mmc/mv_sdhci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/mmc/mv_sdhci.c b/drivers/mmc/mv_sdhci.c > index 336ebf14102..20049981473 100644 > --- a/drivers/mmc/mv_sdhci.c > +++ b/drivers/mmc/mv_sdhci.c > @@ -64,7 +64,7 @@ int mv_sdh_init(unsigned long regbase, u32 max_clk, u32= min_clk, u32 quirks) > host->ops =3D &mv_ops; > #endif > =20 > - if (CONFIG_IS_ENABLED(ARCH_MVEBU)) { > + if (IS_ENABLED(CONFIG_ARCH_MVEBU)) { > /* Configure SDHCI MBUS mbus bridge windows */ > sdhci_mvebu_mbus_config((void __iomem *)regbase); > } > @@ -103,7 +103,7 @@ static int mv_sdhci_probe(struct udevice *dev) > if (ret) > return ret; > =20 > - if (CONFIG_IS_ENABLED(ARCH_MVEBU)) { > + if (IS_ENABLED(CONFIG_ARCH_MVEBU)) { > /* Configure SDHCI MBUS mbus bridge windows */ > sdhci_mvebu_mbus_config(host->ioaddr); > } So, a number of mvebu platforms now grow their SPL here, which is (a) a functional change and (b) implies it's intentional. I'm adding Stefan here to start to get a better handle on if this really should be like this, or not. --=20 Tom --XSz3mxmzTAIV7ZWD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPlLAcACgkQFHw5/5Y0 tyz8gQv9HOTzBSWCtmaFIihUViHJ7ndbUO34NHYYLTWvRwQ1Dpx/Gq9s/9U7XnjL hWCYV3bmW0HJ/1N6kHZ85ItwxwtUdelvukUHOpO10aBPH1Go8PO/34UlQaQFjr7w EKspp0Pp/4yNWjgqXUkPg4XvVwxyDGJe0xSRf9vs9lSWrms2X0yToO941UPYoJ6U MrxJwZ9QiFYfnMcWjjpDFzRS5wWH7RooU9Cb1tsQetZtqQ9bW0/XahtGy7khxwRF eim9XStoan5nfFc/9V83jCHoZEiBPvooF/tdSj2BLZIqc+si7FzMeencoDpW5AcE wX37SYPsOA1XRFeTCn/uISlQRGevHD5NXIWdMWK0xrnSgCiOxczTOkxYuaQJ6qaz ipc4tugfKNXqAAu/Z9ISV6Lzk0mSetPZGskbMRmGMMFdJlfP8EKOWdc83TpWOLKJ JWrHBxO45CxtPBrJWyL+WaDS1Rcn3tfUrKETCs//nP+TtU/R84UgSc8pwoeSzDXn yeFbmBO2 =4Cqg -----END PGP SIGNATURE----- --XSz3mxmzTAIV7ZWD--