From: Tom Rini <trini@konsulko.com>
To: Samuel Holland <samuel@sholland.org>
Cc: Simon Glass <sjg@chromium.org>, Marek Vasut <marex@denx.de>,
u-boot@lists.denx.de
Subject: Re: [PATCH v3 68/76] usb: Drop unused fotg210 gadget
Date: Fri, 10 Feb 2023 20:06:14 -0500 [thread overview]
Message-ID: <Y+bqBtcpMdmHiIvr@bill-the-cat> (raw)
In-Reply-To: <a2b6a8b4-38b7-2673-a5f0-5c605621e681@sholland.org>
[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]
On Fri, Feb 10, 2023 at 05:33:13PM -0600, Samuel Holland wrote:
> On 2/1/23 14:20, Simon Glass wrote:
> > This is not used and appears to be associated with the faraday board which
> > has been removed. Drop the driver and Kconfig options.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> >
> > (no changes since v1)
> >
> > drivers/usb/gadget/Makefile | 3 +-
> > drivers/usb/gadget/fotg210.c | 964 ------------------------------
> > drivers/usb/gadget/gadget_chips.h | 8 -
> > include/usb/fotg210.h | 362 -----------
> > 4 files changed, 1 insertion(+), 1336 deletions(-)
> > delete mode 100644 drivers/usb/gadget/fotg210.c
> > delete mode 100644 include/usb/fotg210.h
> >
> > diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile
> > index 9c04403da30..b04b6bcd779 100644
> > --- a/drivers/usb/gadget/Makefile
> > +++ b/drivers/usb/gadget/Makefile
> > @@ -19,8 +19,7 @@ obj-$(CONFIG_USB_GADGET_ATMEL_USBA) += atmel_usba_udc.o
> > obj-$(CONFIG_USB_GADGET_BCM_UDC_OTG_PHY) += bcm_udc_otg_phy.o
> > obj-$(CONFIG_USB_GADGET_DWC2_OTG) += dwc2_udc_otg.o
> > obj-$(CONFIG_USB_GADGET_DWC2_OTG_PHY) += dwc2_udc_otg_phy.o
> > -obj-$(CONFIG_USB_GADGET_FOTG210) += fotg210.o
> > -obj-$(CONFIG_USB_GADGET_MAX3420) += max3420_udc.o
> > +0obj-$(CONFIG_USB_GADGET_MAX3420) += max3420_udc.o
>
> This stray 0 breaks the next line of the Makefile.
Little worried that didn't cause some failure to build elsewhere,
honestly, I guess because USB_GADGET_MAX3420 isn't used either? But I'll
push a fix with a Reported-by soon, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-02-11 1:06 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 20:19 [PATCH v3 00/76] Clean up of bad Kconfig options Simon Glass
2023-02-01 20:19 ` [PATCH v3 01/76] moveconfig: Add an option to compare Kconfig against source Simon Glass
2023-02-08 1:37 ` Tom Rini
2023-02-08 18:28 ` Simon Glass
2023-02-08 18:35 ` Tom Rini
2023-02-08 19:06 ` Simon Glass
2023-02-01 20:19 ` [PATCH v3 02/76] power: Drop fg_max77693 Simon Glass
2023-02-01 20:19 ` [PATCH v3 03/76] nand: Drop CONFIG_NAND_SPEAR Simon Glass
2023-02-01 20:19 ` [PATCH v3 04/76] power: Drop pmic_max77693.c Simon Glass
2023-02-01 20:19 ` [PATCH v3 05/76] gpio: Drop adi_gpio2 Simon Glass
2023-02-01 20:19 ` [PATCH v3 06/76] Makefile: Drop CONFIG_AIS_CONFIG_FILE Simon Glass
2023-02-01 20:19 ` [PATCH v3 07/76] misc: Drop ali512x Simon Glass
2023-02-01 20:19 ` [PATCH v3 08/76] sandbox: Drop reference to CONFIG_ARCH_DEVICE_TREE Simon Glass
2023-02-01 20:19 ` [PATCH v3 09/76] arm: mvebu: Remove reference to ARMADA_370 Simon Glass
2023-02-01 20:19 ` [PATCH v3 10/76] arm: mvebu: Drop reference to CONFIG_ARMADA_39X Simon Glass
2023-02-01 20:19 ` [PATCH v3 11/76] ppc: Drop bat_rw Simon Glass
2023-02-01 20:19 ` [PATCH v3 12/76] rockchip: Correct a reference to CONFIG_BOOT_MODE_REG Simon Glass
2023-02-01 20:19 ` [PATCH v3 13/76] cmd: Add an option to enable the ini command Simon Glass
2023-02-01 20:19 ` [PATCH v3 14/76] cmd: Drop mfsl command Simon Glass
2023-02-01 20:19 ` [PATCH v3 15/76] Correct CONFIG_CONTROLCENTERDC Simon Glass
2023-02-01 20:19 ` [PATCH v3 16/76] Drop dataflash_mmc_mux command Simon Glass
2023-02-06 0:29 ` Jaehoon Chung
2023-02-01 20:19 ` [PATCH v3 17/76] Drop CONFIG_DM644X_GPIO Simon Glass
2023-02-01 20:19 ` [PATCH v3 18/76] Makefile: Avoid use of invalid CONFIG_ option Simon Glass
2023-02-01 20:19 ` [PATCH v3 19/76] env: Drop ENV_IS_IN_SATA Simon Glass
2023-02-01 20:19 ` [PATCH v3 20/76] samsung: Drop CONFIG_EXYNOS_PWM_BL Simon Glass
2023-02-03 6:05 ` Minkyu Kang
2023-02-01 20:19 ` [PATCH v3 21/76] fpga: Add a LATTICE option Simon Glass
2023-02-01 20:19 ` [PATCH v3 22/76] fpga: Add a FPGA_STRATIX_II option Simon Glass
2023-02-01 20:19 ` [PATCH v3 23/76] misc: Drop mc9sdz60 driver Simon Glass
2023-02-01 20:19 ` [PATCH v3 24/76] freescale: Drop unused pixis code Simon Glass
2023-02-01 20:19 ` [PATCH v3 25/76] freescale: Drop unused ftpmu010 driver Simon Glass
2023-02-01 20:19 ` [PATCH v3 26/76] rcar: Drop timer Simon Glass
2023-02-01 20:19 ` [PATCH v3 27/76] imx: Drop unused CONFIG_IMX Simon Glass
2023-02-01 20:19 ` [PATCH v3 28/76] arm: Drop old kona code Simon Glass
2023-02-01 20:19 ` [PATCH v3 29/76] video: Drop unused lg4573 driver Simon Glass
2023-02-01 20:19 ` [PATCH v3 30/76] m68k: Drop unused CONFIG_M52277 Simon Glass
2023-02-01 20:19 ` [PATCH v3 31/76] m68k: Drop unused CONFIG_MACH_DAVINCI_DA830_EVM Simon Glass
2023-02-01 20:19 ` [PATCH v3 32/76] arm: Drop CONFIG_MMU Simon Glass
2023-02-01 20:19 ` [PATCH v3 33/76] arc: " Simon Glass
2023-02-01 20:19 ` [PATCH v3 34/76] gpio: Drop unused mpc83xx_gpio driver Simon Glass
2023-02-01 20:19 ` [PATCH v3 35/76] imx: Rename CONFIG_MXS to CFG_MXS Simon Glass
2023-02-01 20:19 ` [PATCH v3 36/76] nand: Drop unused actl_nand driver Simon Glass
2023-02-01 20:19 ` [PATCH v3 37/76] mtd: Drop unused fsl_upm driver Simon Glass
2023-02-01 20:19 ` [PATCH v3 38/76] mtd: Drop unused fsmc_nand driver Simon Glass
2023-02-01 20:19 ` [PATCH v3 40/76] mtd: Drop unused nand_plat driver Simon Glass
2023-02-01 20:19 ` [PATCH v3 41/76] Makefile: Drop CONFIG_OF_EARLY_FLATTREE Simon Glass
2023-02-01 20:19 ` [PATCH v3 42/76] omap: Drop unused CONFIG_OMAP_USB_PHY Simon Glass
2023-02-01 20:19 ` [PATCH v3 44/76] ppc: Drop unused CONFIG_P2020DS Simon Glass
2023-02-01 20:19 ` [PATCH v3 45/76] gpio: Drop unused pca9698 driver Simon Glass
2023-02-01 20:19 ` [PATCH v3 46/76] samsung: Rename PINCTRL_EXYNOS78x0 Simon Glass
2023-02-03 6:04 ` Minkyu Kang
2023-02-01 20:19 ` [PATCH v3 47/76] power: Drop unused bat_trats driver and battery code Simon Glass
2023-02-01 20:19 ` [PATCH v3 48/76] power: Drop unused fg_max17042 driver and fuel gauge code Simon Glass
2023-02-01 20:20 ` [PATCH v3 49/76] power: Drop unused muic_max77693 driver and mfd code Simon Glass
2023-02-01 20:20 ` [PATCH v3 50/76] power: Drop unused muic_max8997 driver Simon Glass
2023-02-01 20:20 ` [PATCH v3 51/76] freescale: Drop unused pq-mds-pib driver Simon Glass
2023-02-01 20:20 ` [PATCH v3 52/76] rmobile: Drop CONFIG_RMOBILE Simon Glass
2023-02-01 20:20 ` [PATCH v3 53/76] rtc: Drop old and unused drivers Simon Glass
2023-02-01 20:20 ` [PATCH v3 54/76] mtd: Drop unused CONFIG_S32V234 Simon Glass
2023-02-01 20:20 ` [PATCH v3 55/76] mtd: Drop unused scf0403_lcd driver Simon Glass
2023-02-01 20:20 ` [PATCH v3 56/76] rmobile: Drop CONFIG_SH73A0 and associated code Simon Glass
2023-02-01 20:20 ` [PATCH v3 57/76] sh4: Drop unused pci_sh7780 driver Simon Glass
2023-02-01 20:20 ` [PATCH v3 58/76] Drop ubsha1 tool Simon Glass
2023-02-20 10:16 ` Peter Robinson
2023-02-21 19:41 ` Simon Glass
2023-02-22 8:08 ` Peter Robinson
2023-02-22 21:20 ` Simon Glass
2023-02-01 20:20 ` [PATCH v3 59/76] sysreset: at91: Correct Makefile rule for SYSRESET_AT91 Simon Glass
2023-02-01 20:20 ` [PATCH v3 60/76] gdsys: Drop unused fpga file Simon Glass
2023-02-01 20:20 ` [PATCH v3 61/76] sh4: Drop unused kona_i2c driver Simon Glass
2023-02-01 20:20 ` [PATCH v3 62/76] compulab: Drop CONFIG_TARGET_MCM_IMX8M_MINI Simon Glass
2023-02-01 20:20 ` [PATCH v3 63/76] freescale: Drop CONFIG_TARGET_MPC8536DS et al Simon Glass
2023-02-01 20:20 ` [PATCH v3 65/76] ppc: Makefile: Drop unused ppc4xx code Simon Glass
2023-02-01 20:20 ` [PATCH v3 66/76] armada: usb: net: Drop unused USB drivers Simon Glass
2023-02-01 20:20 ` [PATCH v3 67/76] usb: Drop unused ehci-faraday driver Simon Glass
2023-02-01 20:20 ` [PATCH v3 68/76] usb: Drop unused fotg210 gadget Simon Glass
2023-02-10 23:33 ` Samuel Holland
2023-02-11 1:06 ` Tom Rini [this message]
2023-02-01 20:20 ` [PATCH v3 69/76] rmobile: Drop unused ehci-rmobile driver Simon Glass
2023-02-01 20:20 ` [PATCH v3 70/76] usb: Drop unused ehci-vct driver Simon Glass
2023-02-01 20:20 ` [PATCH v3 71/76] usb: Drop unused sl811-hcd driver Simon Glass
2023-02-01 20:20 ` [PATCH v3 72/76] imx: Drop CONFIG_USE_PLUGIN Simon Glass
2023-02-01 20:20 ` [PATCH v3 73/76] freescale: Drop unused vsc3316_3308 driver Simon Glass
2023-02-01 20:20 ` [PATCH v3 74/76] tools: Drop xway-swap-bytes tool Simon Glass
2023-02-01 20:20 ` [PATCH v3 75/76] freescale: Drop unused zm7300 driver Simon Glass
2023-02-01 20:20 ` [PATCH v3 76/76] fdt: Drop use of non-existent OF_PLATDATA option Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+bqBtcpMdmHiIvr@bill-the-cat \
--to=trini@konsulko.com \
--cc=marex@denx.de \
--cc=samuel@sholland.org \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox