From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 1/1] efi_loader: avoid EFI_CALL() when draining console
Date: Sat, 15 Oct 2022 22:31:47 +0300 [thread overview]
Message-ID: <Y0sKo1r8wmcMjFIX@hera> (raw)
In-Reply-To: <20221015104339.13039-1-heinrich.schuchardt@canonical.com>
On Sat, Oct 15, 2022 at 12:43:39PM +0200, Heinrich Schuchardt wrote:
> Use internal function.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> lib/efi_loader/efi_console.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/lib/efi_loader/efi_console.c b/lib/efi_loader/efi_console.c
> index 6d4784e140..ab83f8bf82 100644
> --- a/lib/efi_loader/efi_console.c
> +++ b/lib/efi_loader/efi_console.c
> @@ -1359,9 +1359,7 @@ efi_status_t efi_console_get_u16_string(struct efi_simple_text_input_protocol *c
> ANSI_CLEAR_LINE_TO_END
> ANSI_CURSOR_SHOW, row, col);
>
> - ret = EFI_CALL(cin->reset(cin, false));
> - if (ret != EFI_SUCCESS)
> - return ret;
> + efi_cin_empty_buffer();
>
> for (;;) {
> do {
> --
> 2.37.2
>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
prev parent reply other threads:[~2022-10-15 19:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 10:43 [PATCH 1/1] efi_loader: avoid EFI_CALL() when draining console Heinrich Schuchardt
2022-10-15 19:31 ` Ilias Apalodimas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0sKo1r8wmcMjFIX@hera \
--to=ilias.apalodimas@linaro.org \
--cc=heinrich.schuchardt@canonical.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox