public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH 1/1] efi_loader: avoid EFI_CALL() when draining console
@ 2022-10-15 10:43 Heinrich Schuchardt
  2022-10-15 19:31 ` Ilias Apalodimas
  0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2022-10-15 10:43 UTC (permalink / raw)
  To: Ilias Apalodimas; +Cc: u-boot, Heinrich Schuchardt

Use internal function.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 lib/efi_loader/efi_console.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/efi_loader/efi_console.c b/lib/efi_loader/efi_console.c
index 6d4784e140..ab83f8bf82 100644
--- a/lib/efi_loader/efi_console.c
+++ b/lib/efi_loader/efi_console.c
@@ -1359,9 +1359,7 @@ efi_status_t efi_console_get_u16_string(struct efi_simple_text_input_protocol *c
 	       ANSI_CLEAR_LINE_TO_END
 	       ANSI_CURSOR_SHOW, row, col);
 
-	ret = EFI_CALL(cin->reset(cin, false));
-	if (ret != EFI_SUCCESS)
-		return ret;
+	efi_cin_empty_buffer();
 
 	for (;;) {
 		do {
-- 
2.37.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] efi_loader: avoid EFI_CALL() when draining console
  2022-10-15 10:43 [PATCH 1/1] efi_loader: avoid EFI_CALL() when draining console Heinrich Schuchardt
@ 2022-10-15 19:31 ` Ilias Apalodimas
  0 siblings, 0 replies; 2+ messages in thread
From: Ilias Apalodimas @ 2022-10-15 19:31 UTC (permalink / raw)
  To: Heinrich Schuchardt; +Cc: u-boot

On Sat, Oct 15, 2022 at 12:43:39PM +0200, Heinrich Schuchardt wrote:
> Use internal function.
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  lib/efi_loader/efi_console.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/lib/efi_loader/efi_console.c b/lib/efi_loader/efi_console.c
> index 6d4784e140..ab83f8bf82 100644
> --- a/lib/efi_loader/efi_console.c
> +++ b/lib/efi_loader/efi_console.c
> @@ -1359,9 +1359,7 @@ efi_status_t efi_console_get_u16_string(struct efi_simple_text_input_protocol *c
>  	       ANSI_CLEAR_LINE_TO_END
>  	       ANSI_CURSOR_SHOW, row, col);
>  
> -	ret = EFI_CALL(cin->reset(cin, false));
> -	if (ret != EFI_SUCCESS)
> -		return ret;
> +	efi_cin_empty_buffer();
>  
>  	for (;;) {
>  		do {
> -- 
> 2.37.2
> 

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-15 19:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-15 10:43 [PATCH 1/1] efi_loader: avoid EFI_CALL() when draining console Heinrich Schuchardt
2022-10-15 19:31 ` Ilias Apalodimas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox