From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15922C433FE for ; Sat, 15 Oct 2022 19:31:57 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 020BD84ED0; Sat, 15 Oct 2022 21:31:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="LfD2/zdq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8A58184ED6; Sat, 15 Oct 2022 21:31:52 +0200 (CEST) Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 12EE484E22 for ; Sat, 15 Oct 2022 21:31:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wr1-x42b.google.com with SMTP id bu30so12455945wrb.8 for ; Sat, 15 Oct 2022 12:31:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qt6lof21PIsao0C+qOwPQIxizj+Gyci2DekXNcfXu4E=; b=LfD2/zdqTQvVMD6a1m25bIPiTcHZWNzImOx0dwaB4zdm1jKbKMqt2UlvA4ccxQ+Z/q FnwvEIviNnTCcX3MF9Ct9atERWRYyzPdMcRrBc8j5D98u83DP4u2xR0jaw3E7onTo3WJ UVYKZKGxqTlZ8exls4SxRRc5i6livD6vXegT/lGlj2cpkcszJdJStztxY5Rj2pbBpBvf v2z6dA+J1Y+ssYxfQnKbpajUnP/TuvBsNPvRT0Yby0/RmLYGKe6Vi7MUutGCvQXRvM7S pZ8kd4U5pXEycZNrruNuK2knThYueofjO0rStlmi/28zZ2qQDgS7dehyAIU74OXVTgzR TWvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qt6lof21PIsao0C+qOwPQIxizj+Gyci2DekXNcfXu4E=; b=n2LXLhqfzNyrk5aTgKik6IrktGEoKWir1ZucDr4AHwb64Lss7pRzmsE+RavflvJa+3 erpsBEQqwtO9QvigguKX/jN/gQWzwIDE1q0fjVu4QND/Xyc9TcsnUEKj2OYTSAFuXXzZ Bw6KE+z4UTk/mVxFAshTRCp2cA160/vvfPKHmu3uLNY6nmJ+xesQZvvXf/jBgdwM6Nnj skwC8d1gEr/uhMdZU+NUTwSp01oUXwuQ+qmYJjaUJHmt7UaD1WyuGY+CJvGv7KTw2Svk vugqL0lEnF0uIhdT8Q6VxJKzm+htkYKsxysIr0uqGGM1cHkdNTtkDMjtN7z3Iui+2J3U xvPg== X-Gm-Message-State: ACrzQf16CsWqiyJqpiPcqusmnKpf4rBpOsPNmOqFj/jHa90NgaUYTTVl m/BzgWyr+HUA600E5PC+JoM1m9p9/2AWjQ== X-Google-Smtp-Source: AMsMyM6w6sbRiIzOizITF1UaPULfa/oU0HYCc/MivRkxsWw3ukSbhPyKBzp4G5fCLSs9ofiAzrgMjQ== X-Received: by 2002:a5d:668f:0:b0:22e:47be:3fa7 with SMTP id l15-20020a5d668f000000b0022e47be3fa7mr2123809wru.200.1665862309631; Sat, 15 Oct 2022 12:31:49 -0700 (PDT) Received: from hera (ppp046103015185.access.hol.gr. [46.103.15.185]) by smtp.gmail.com with ESMTPSA id b9-20020a056000054900b0022ac672654dsm4773807wrf.58.2022.10.15.12.31.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Oct 2022 12:31:49 -0700 (PDT) Date: Sat, 15 Oct 2022 22:31:47 +0300 From: Ilias Apalodimas To: Heinrich Schuchardt Cc: u-boot@lists.denx.de Subject: Re: [PATCH 1/1] efi_loader: avoid EFI_CALL() when draining console Message-ID: References: <20221015104339.13039-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221015104339.13039-1-heinrich.schuchardt@canonical.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Sat, Oct 15, 2022 at 12:43:39PM +0200, Heinrich Schuchardt wrote: > Use internal function. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_console.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/lib/efi_loader/efi_console.c b/lib/efi_loader/efi_console.c > index 6d4784e140..ab83f8bf82 100644 > --- a/lib/efi_loader/efi_console.c > +++ b/lib/efi_loader/efi_console.c > @@ -1359,9 +1359,7 @@ efi_status_t efi_console_get_u16_string(struct efi_simple_text_input_protocol *c > ANSI_CLEAR_LINE_TO_END > ANSI_CURSOR_SHOW, row, col); > > - ret = EFI_CALL(cin->reset(cin, false)); > - if (ret != EFI_SUCCESS) > - return ret; > + efi_cin_empty_buffer(); > > for (;;) { > do { > -- > 2.37.2 > Reviewed-by: Ilias Apalodimas