From: Conor Dooley <conor@kernel.org>
To: Tudor.Ambarus@microchip.com
Cc: Padmarao.Begari@microchip.com, u-boot@lists.denx.de,
jagan@amarulasolutions.com, rick@andestech.com,
ycliang@andestech.com, bmeng.cn@gmail.com,
Cyril.Jean@microchip.com, Conor.Dooley@microchip.com,
Valentina.FernandezAlanis@microchip.com,
Nagasuresh.Relli@microchip.com
Subject: Re: [PATCH 4/4] spi: Add Microchip PolarFire SoC QSPI driver
Date: Wed, 19 Oct 2022 16:47:53 +0100 [thread overview]
Message-ID: <Y1AcKfYiyfTxJkYy@spud> (raw)
In-Reply-To: <b3661175-888e-c2da-c1aa-d15b60d9c50e@microchip.com>
On Wed, Oct 19, 2022 at 03:16:01PM +0000, Tudor.Ambarus@microchip.com wrote:
> Hi!
>
> On 10/19/22 17:53, Padmarao Begari wrote:
> > drivers/spi/microchip_qspi.c | 504 +++++++++++++++++++++++++++++++++++
>
> The name is too generic, there are multiple QSPI IPs inside mchp.
> I would suggest to create an mchp directory and rename your c file to
> maybe something like mpfs-qspi?
The (linux) driver works for both the "hard" peripheral on mpfs & for
the core in FPGA fabric. I would wouldn't mind copying the linux naming
and using "microchip-corespi" & "microchip-coreqspi" as the underlying
IPs are called CoreSPI and CoreQSPI respectively.
next prev parent reply other threads:[~2022-10-19 15:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 14:53 [PATCH 0/4] Update Microchip PolarFire SoC Padmarao Begari
2022-10-19 14:53 ` [PATCH 1/4] riscv: dts: update memory configuration Padmarao Begari
2022-10-19 15:57 ` Conor Dooley
2022-10-20 5:20 ` Padmarao.Begari
2022-10-19 14:53 ` [PATCH 2/4] riscv: dts: Add QSPI NAND device node Padmarao Begari
2022-10-19 15:28 ` Tudor.Ambarus
2022-10-20 5:22 ` Padmarao.Begari
2022-10-19 15:59 ` Conor Dooley
2022-10-20 5:24 ` Padmarao.Begari
2022-10-19 14:53 ` [PATCH 3/4] riscv: Update Microchip MPFS Icicle Kit support Padmarao Begari
2022-10-19 16:09 ` Conor Dooley
2022-10-19 14:53 ` [PATCH 4/4] spi: Add Microchip PolarFire SoC QSPI driver Padmarao Begari
2022-10-19 15:16 ` Tudor.Ambarus
2022-10-19 15:47 ` Conor Dooley [this message]
2022-10-20 5:27 ` Padmarao.Begari
2022-10-19 16:20 ` Conor Dooley
2022-10-20 5:28 ` Padmarao.Begari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1AcKfYiyfTxJkYy@spud \
--to=conor@kernel.org \
--cc=Conor.Dooley@microchip.com \
--cc=Cyril.Jean@microchip.com \
--cc=Nagasuresh.Relli@microchip.com \
--cc=Padmarao.Begari@microchip.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=Valentina.FernandezAlanis@microchip.com \
--cc=bmeng.cn@gmail.com \
--cc=jagan@amarulasolutions.com \
--cc=rick@andestech.com \
--cc=u-boot@lists.denx.de \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox