From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 046DDC4332F for ; Wed, 19 Oct 2022 15:48:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9FB2B84DD3; Wed, 19 Oct 2022 17:48:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="cmdbGMlV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F3D0484DD3; Wed, 19 Oct 2022 17:48:03 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4C6EE8491C for ; Wed, 19 Oct 2022 17:48:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=conor@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DF82B61846; Wed, 19 Oct 2022 15:47:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64DEEC433D6; Wed, 19 Oct 2022 15:47:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666194478; bh=ZY1npaUyNkhBr327uXWGo1zNgmw2dAsGZKWdiThzu9k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cmdbGMlVyNdQ8bb8bBEB35kd9VKGaa1w+ikzlM3I6JmZTca2Rn1FqLySli5pnAS2W DfBvG2YGo9x+dpGzTM9UKtigTGGl7kXJTXG+aiUhDIEyWX9j1YGmVWyIEk5cKtWFtN wnOLACeHmylGJSNFsqbvvOwMLc7a7PszymFCyk+AfhHVV+p5M+jIO9XOe3nHvE3c7B CxIvoodu7nhIsiVArA0GFMiafF5XJo2IouJpTbARIVxy/w9Q6erJ1xSlvOtL4nD/JK Nixhp8MP3noFWrA7g1ra6EeD9rh74rw80SDkSziQpBJ9rblVXNFfeQp+x1MNWpABoj H0am4WOs/tDBg== Date: Wed, 19 Oct 2022 16:47:53 +0100 From: Conor Dooley To: Tudor.Ambarus@microchip.com Cc: Padmarao.Begari@microchip.com, u-boot@lists.denx.de, jagan@amarulasolutions.com, rick@andestech.com, ycliang@andestech.com, bmeng.cn@gmail.com, Cyril.Jean@microchip.com, Conor.Dooley@microchip.com, Valentina.FernandezAlanis@microchip.com, Nagasuresh.Relli@microchip.com Subject: Re: [PATCH 4/4] spi: Add Microchip PolarFire SoC QSPI driver Message-ID: References: <20221019145322.2274420-1-padmarao.begari@microchip.com> <20221019145322.2274420-5-padmarao.begari@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Wed, 19 Oct 2022 17:48:43 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Wed, Oct 19, 2022 at 03:16:01PM +0000, Tudor.Ambarus@microchip.com wrote: > Hi! > > On 10/19/22 17:53, Padmarao Begari wrote: > > drivers/spi/microchip_qspi.c | 504 +++++++++++++++++++++++++++++++++++ > > The name is too generic, there are multiple QSPI IPs inside mchp. > I would suggest to create an mchp directory and rename your c file to > maybe something like mpfs-qspi? The (linux) driver works for both the "hard" peripheral on mpfs & for the core in FPGA fabric. I would wouldn't mind copying the linux naming and using "microchip-corespi" & "microchip-coreqspi" as the underlying IPs are called CoreSPI and CoreQSPI respectively.