From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B52AC4332F for ; Wed, 19 Oct 2022 16:09:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5BCF584F88; Wed, 19 Oct 2022 18:09:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="GbMm5SlZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0476884F90; Wed, 19 Oct 2022 18:09:48 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8DF4484F87 for ; Wed, 19 Oct 2022 18:09:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=conor@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0F24A61932; Wed, 19 Oct 2022 16:09:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F999C433C1; Wed, 19 Oct 2022 16:09:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666195783; bh=r7CYhZ+tPjsUKXu6MEspdaJZE0ZTkruHzJeR0T88h/Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GbMm5SlZZEANSgOCdqcaJ23M9yi9aDI8H2AzxgyB+KJaK4yUxHQXUdILySU828L4Z +85yOS4gAt5JZvoxObzU2WbVMeaqUfHdmOJca4m+LafQXvigsqkl8j9PdL8Ok8Sg/k cioMKATzeOGgq3LpDyhcBmh9f4M2x1ARI/A7rktr2NgfrwfLUKbCagvfJfIRTUEf20 IdRLYWuOc06ZmSHuonF8g3ka8sT//Zwo3X1mYuOm1POIRD2K/HF5b14sovJIV90f3l ycz60sAXbQsVszj1B1V4CsdS65Ap0T3EguHo0CM6Dwz2SsQQ5ovb+OeOrr7t6vq29F Bjkkin3o+7lSw== Date: Wed, 19 Oct 2022 17:09:38 +0100 From: Conor Dooley To: Padmarao Begari Cc: u-boot@lists.denx.de, jagan@amarulasolutions.com, rick@andestech.com, ycliang@andestech.com, bmeng.cn@gmail.com, cyril.jean@microchip.com, conor.dooley@microchip.com, valentina.fernandezalanis@microchip.com, nagasuresh.relli@microchip.com Subject: Re: [PATCH 3/4] riscv: Update Microchip MPFS Icicle Kit support Message-ID: References: <20221019145322.2274420-1-padmarao.begari@microchip.com> <20221019145322.2274420-4-padmarao.begari@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221019145322.2274420-4-padmarao.begari@microchip.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Wed, Oct 19, 2022 at 08:23:21PM +0530, Padmarao Begari wrote: > This patch updates Microchip MPFS Icicle Kit support. For now, > add Microchip QSPI driver and a small 4MB reservation is > made at the end of 32-bit DDR to provide some memory for > the HSS to use. > > Signed-off-by: Padmarao Begari > --- > board/microchip/mpfs_icicle/Kconfig | 7 +++++++ > configs/microchip_mpfs_icicle_defconfig | 1 + > 2 files changed, 8 insertions(+) > > diff --git a/board/microchip/mpfs_icicle/Kconfig b/board/microchip/mpfs_icicle/Kconfig > index 092e411215..230f96b033 100644 > --- a/board/microchip/mpfs_icicle/Kconfig > +++ b/board/microchip/mpfs_icicle/Kconfig > @@ -50,5 +50,12 @@ config BOARD_SPECIFIC_OPTIONS # dummy > imply CMD_I2C > imply DM_I2C > imply SYS_I2C_MICROCHIP > + imply SPI > + imply DM_SPI > + imply MICROCHIP_QSPI > + imply MTD_SPI_NAND > + imply CMD_MTD > + imply MTD_PARTITIONS > + imply CMD_MTDPARTS > > endif > diff --git a/configs/microchip_mpfs_icicle_defconfig b/configs/microchip_mpfs_icicle_defconfig > index 6113c5be80..c295b9bad3 100644 > --- a/configs/microchip_mpfs_icicle_defconfig > +++ b/configs/microchip_mpfs_icicle_defconfig > @@ -17,6 +17,7 @@ CONFIG_DISPLAY_BOARDINFO=y > CONFIG_SYS_CBSIZE=256 > CONFIG_SYS_PBSIZE=282 > CONFIG_SYS_BOOTM_LEN=0x4000000 > +CONFIG_SYS_MEM_TOP_HIDE=0x400000 Ah cool, I'd done my patch for our stuff against v2022.01 and this IIRC was not a "real" config option then. Nice to see that it got "promoted" to a kconfig option :) Stuff here LGTM so: Reviewed-by: Conor Dooley Thanks, Conor. > CONFIG_SYS_RELOC_GD_ENV_ADDR=y > CONFIG_BOOTP_SEND_HOSTNAME=y > CONFIG_DM_MTD=y > -- > 2.25.1 >