Re: [PATCH 4/4] spi: Add Microchip PolarFire SoC QSPI driver

[Conor Dooley <conor@kernel.org>]

On Wed, Oct 19, 2022 at 08:23:22PM +0530, Padmarao Begari wrote:
> Add QSPI driver code for the Microchip PolarFire SoC.
> This driver supports the qspi standard, dual and quad
> mode interfaces.
> 
> Signed-off-by: Padmarao Begari <padmarao.begari@microchip.com>
> Signed-off-by: Naga Sureshkumar Relli <nagasuresh.relli@microchip.com>
> ---
>  drivers/spi/Kconfig          |   6 +
>  drivers/spi/Makefile         |   1 +
>  drivers/spi/microchip_qspi.c | 504 +++++++++++++++++++++++++++++++++++
>  3 files changed, 511 insertions(+)
>  create mode 100644 drivers/spi/microchip_qspi.c
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 2f12081f88..690306309a 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -237,6 +237,12 @@ config MESON_SPIFC
>  	  This driver can be used to access the SPI NOR flash chips on
>  	  Amlogic Meson SoCs.
>  
> +config MICROCHIP_QSPI

Can this be MICROCHIP_COREQSPI to match my proposed name of the driver
and the function/structure names in the driver?

> diff --git a/drivers/spi/Makefile b/drivers/spi/Makefile
> +
> +static const struct udevice_id mchp_coreqspi_ids[] = {
> +	{ .compatible = "microchip,mpfs-qspi" },

Could we add microchip,coreqspi-rtl-v2 to the compatible list here
please to match the linux driver? The linux driver works perfectly well
with the fabric core and I assume that's the case for the the U-Boot
driver too?

Thanks,
Conor.

> +	{ }
> +};
> +
> +U_BOOT_DRIVER(mchp_coreqspi) = {
> +	.name   = "mchp_coreqspi",
> +	.id     = UCLASS_SPI,
> +	.of_match = mchp_coreqspi_ids,
> +	.ops    = &mchp_coreqspi_ops,
> +	.priv_auto = sizeof(struct mchp_coreqspi),
> +	.probe  = mchp_coreqspi_probe,
> +};
> -- 
> 2.25.1
>