From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03ADCC04A95 for ; Sat, 22 Oct 2022 11:47:05 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 363D784F39; Sat, 22 Oct 2022 13:47:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="RkYMtnSs"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8752484F45; Sat, 22 Oct 2022 13:47:01 +0200 (CEST) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1BFA484F11 for ; Sat, 22 Oct 2022 13:46:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=conor@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9CC6FB811D9; Sat, 22 Oct 2022 11:46:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31609C433C1; Sat, 22 Oct 2022 11:46:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666439217; bh=GxJ+p8ZcZV41QwRMo4KGBqT+93f0l6GXSHTa7iVcHqY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RkYMtnSsCQxLRyk4id54TwPsiExzO012niZ9+h6/pEvGMMm2LabkRfZXy4NH17/l/ MIhuDzrrinb7sPenzXfkbMS5kpqn/B9Sy6Jc2iPLeXgDEQuI2kHikICgteMOZ08tab mibvZ9tbepV63TavOtf7oYR8U2DCsuzVmp3z2iJTER4QwHgVujIK9PdjhIeSZgFxzi BZOoJdVasuA0O/Vh6SEQMIZbGWD9ePzxW+K76IKoTS1rgoY5ctFSoQoQdMq5I7kSgY DmzPcoX8DPInt+QQAgnfQJB3cW3zekaOKwbySwZ9hbuWTclE83irhj/cvkzzpKDH1F cHF6aeiEOEm2w== Date: Sat, 22 Oct 2022 12:46:52 +0100 From: Conor Dooley To: Padmarao Begari Cc: u-boot@lists.denx.de, jagan@amarulasolutions.com, rick@andestech.com, ycliang@andestech.com, bmeng.cn@gmail.com, cyril.jean@microchip.com, conor.dooley@microchip.com, valentina.fernandezalanis@microchip.com, nagasuresh.relli@microchip.com Subject: Re: [PATCH v2 3/4] spi: Add Microchip PolarFire SoC QSPI driver Message-ID: References: <20221021065922.2327875-1-padmarao.begari@microchip.com> <20221021065922.2327875-4-padmarao.begari@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221021065922.2327875-4-padmarao.begari@microchip.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Fri, Oct 21, 2022 at 12:29:21PM +0530, Padmarao Begari wrote: > Add QSPI driver code for the Microchip PolarFire SoC. > This driver supports the QSPI standard, dual and quad > mode interfaces. > > Co-developed-by: Naga Sureshkumar Relli > Signed-off-by: Naga Sureshkumar Relli > Signed-off-by: Padmarao Begari > --- > drivers/spi/Kconfig | 6 + > drivers/spi/Makefile | 1 + > drivers/spi/microchip_coreqspi.c | 505 +++++++++++++++++++++++++++++++ > 3 files changed, 512 insertions(+) > create mode 100644 drivers/spi/microchip_coreqspi.c > > +/* QSPI ready time out value */ > +#define TIMEOUT_MS (1000 * 60) Hey Padmarao, just zipping through and cross referencing against the linux driver.. Why's this a 60 * 1000 when linux times out after 500 ms? Other than that, things look identical modulo the required interrupt and clocking changes for U-Boot. Reviewed-by: Conor Dooley Thanks, Conor.