From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBCFEFA373E for ; Mon, 24 Oct 2022 12:13:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AAE19806ED; Mon, 24 Oct 2022 14:13:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="wkvqJfXZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 46C82806F4; Mon, 24 Oct 2022 14:13:15 +0200 (CEST) Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 04EDC806EB for ; Mon, 24 Oct 2022 14:13:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ed1-x52d.google.com with SMTP id i21so9364640edj.10 for ; Mon, 24 Oct 2022 05:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NEPULsnqoW8zIZSArXQErbrIHqNCsNjmLnj21HQWKNI=; b=wkvqJfXZQ2Ea+WSERuxR8Y9kU1/trTylCJoZjR+5YguYMKqLPQ2dN7PPHwCKNYUkP7 Dy7qx5V9dei/hOHXFvuBzdAfGM5RPY7wrSkMb+c8nwG57yybybTI+SRkhiW0zRDS7dGH 1hRdNz7P6uaUtj2V3vs/uTBsEiTTlU1KgPeSBdnVL3RgxmB1sBhPCD02mxMBCNTiGtRt zVRjSQmjg6JmUBXS/lkzBNID2DjEyp4yZpRajRfqtcmoBmQmbQsPE0fetGD6xCjR7CpF ZwFGqXpTUIg+Ce27oWB6KP9PNCV2EiaMZpVVv7kzxmW+GKjb8sJnKulX4sVCDElsB1A0 v91g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NEPULsnqoW8zIZSArXQErbrIHqNCsNjmLnj21HQWKNI=; b=H9OtpKmJrlETWuqmPrqRTO70A0cqXRW/H4eIGHnis/RoY2l7LSTECTxILz2Wy78Xmr griwIWCCvYia4LT+a/j26TgOzGQ/Ik3MSlBgNgExVYC47mGpXKlvoDqd9uOGdzm7NvsQ 3LBZKEJIOasjjk+jQqD3ttvDSApsFZgHMlPeyeBX78ryCMZQAFASgT2+lu2xDUGJVcJn ZEKIREE3ANhxk98vxqbWve6Pq7T09a7BrQg3PgEqwsyNjICpW3eBnxDkUg/XH/pMz0iL lZ/YaYu/Las3KeJ0iuFRW1ZNXhykL1f+5jvF0pE+OUEhUG/XU52baCXwNz57ik69ZXkJ Zp8A== X-Gm-Message-State: ACrzQf0YQfWj77xXqpBD9/lNBvZPrI3XGzBFBsRGznwgbgGRtJj6X6yR ZRMHLeYHwhL6R5lTPqi+mNm/HQ== X-Google-Smtp-Source: AMsMyM7NR5RKYo7zEFcKpX+apmgVPnnDkX8N/NxRWt+ODGZQ2Y4sUbvA/Np/YPxRwQxtBbReLi8Baw== X-Received: by 2002:a05:6402:d06:b0:45a:3ac6:ad26 with SMTP id eb6-20020a0564020d0600b0045a3ac6ad26mr30721655edb.195.1666613591557; Mon, 24 Oct 2022 05:13:11 -0700 (PDT) Received: from hera (ppp046103015185.access.hol.gr. [46.103.15.185]) by smtp.gmail.com with ESMTPSA id 23-20020a170906311700b0073d8ad7feeasm15459746ejx.213.2022.10.24.05.13.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 05:13:11 -0700 (PDT) Date: Mon, 24 Oct 2022 15:13:08 +0300 From: Ilias Apalodimas To: Abdellatif El Khlifi Cc: achin.gupta@arm.com, jens.wiklander@linaro.org, nd@arm.com, sjg@chromium.org, trini@konsulko.com, u-boot@lists.denx.de, vishnu.banavath@arm.com, xueliang.zhong@arm.com, Drew.Reed@arm.com Subject: Re: [PATCH v6 10/10] arm_ffa: efi: corstone1000: enable MM communication Message-ID: References: <20220926140827.15125-1-abdellatif.elkhlifi@arm.com> <20221013103857.614-1-abdellatif.elkhlifi@arm.com> <20221013103857.614-11-abdellatif.elkhlifi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221013103857.614-11-abdellatif.elkhlifi@arm.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Thu, Oct 13, 2022 at 11:38:57AM +0100, Abdellatif El Khlifi wrote: > turn on EFI MM communication > > On corstone1000 platform MM communication between u-boot > and the secure world (Optee) is done using the FF-A bus. > > Signed-off-by: Abdellatif El Khlifi > Cc: Tom Rini > Cc: Simon Glass > Cc: Ilias Apalodimas > Cc: Jens Wiklander > > --- > > Changelog: > =============== > > v6: > > * corstone-1000: enable optee driver > * corstone-1000: remove CONFIG_ARM_FFA_EFI_RUNTIME_MODE from the defconfig > > v4: > > * corstone-1000: turn on EFI MM communication > > configs/corstone1000_defconfig | 4 ++++ > include/configs/corstone1000.h | 9 +++++++++ > 2 files changed, 13 insertions(+) > > diff --git a/configs/corstone1000_defconfig b/configs/corstone1000_defconfig > index ed2e0fe70a..4c9ed9fb71 100644 > --- a/configs/corstone1000_defconfig > +++ b/configs/corstone1000_defconfig > @@ -52,3 +52,7 @@ CONFIG_DM_SERIAL=y > CONFIG_USB=y > CONFIG_USB_ISP1760=y > CONFIG_ERRNO_STR=y > +CONFIG_EFI_MM_COMM_TEE=y > +CONFIG_TEE=y > +CONFIG_OPTEE=y > +CONFIG_ARM_FFA_TRANSPORT=y > diff --git a/include/configs/corstone1000.h b/include/configs/corstone1000.h > index 8e0230c135..997d0bebaf 100644 > --- a/include/configs/corstone1000.h > +++ b/include/configs/corstone1000.h > @@ -14,6 +14,15 @@ > > #include > > +#define FFA_SHARED_MM_BUFFER_SIZE SZ_4K /* 4 KB */ > + > +/* > + * shared buffer physical address used for communication between > + * u-boot and the MM SP > + */ > +#define FFA_SHARED_MM_BUFFER_ADDR (0x023F8000) > +#define FFA_SHARED_MM_BUFFER_OFFSET (0) The rest of the declarations on this file don't have () so please remove them. Also is FFA_SHARED_MM_BUFFER_ADDR used anywhere that would justify UL in the suffix? Thanks /Ilias > + > #define V2M_BASE 0x80000000 > > #define CONFIG_PL011_CLOCK 50000000 > -- > 2.17.1 >