From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3A5CC4332F for ; Wed, 2 Nov 2022 11:20:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 80BBF8505E; Wed, 2 Nov 2022 12:20:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id B7A0E85072; Wed, 2 Nov 2022 12:20:43 +0100 (CET) Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E965785038 for ; Wed, 2 Nov 2022 12:20:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by Atcsqr.andestech.com with ESMTP id 2A2BKVWs002668; Wed, 2 Nov 2022 19:20:31 +0800 (+08) (envelope-from ycliang@andestech.com) Received: from ubuntu01 (10.0.12.75) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Wed, 2 Nov 2022 19:20:27 +0800 Date: Wed, 2 Nov 2022 11:20:26 +0000 From: Leo Liang To: Conor Dooley CC: Rick Chen , Lukasz Majewski , "Sean Anderson" , Padmarao Begari , Subject: Re: [PATCH v1 2/6] clk: microchip: mpfs: convert parent rate acquistion to get_get_rate() Message-ID: References: <20221025075848.110754-1-conor.dooley@microchip.com> <20221025075848.110754-3-conor.dooley@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20221025075848.110754-3-conor.dooley@microchip.com> User-Agent: Mutt/2.0.5 (2021-01-21) X-Originating-IP: [10.0.12.75] X-DNSRBL: X-MAIL: Atcsqr.andestech.com 2A2BKVWs002668 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, Oct 25, 2022 at 08:58:45AM +0100, Conor Dooley wrote: > Currently the clock driver for PolarFire SoC takes a very naive approach > to the relationship between clocks. It reads the dt to get an input > clock, assumes that that is fixed frequency, reads the "clock-frequency" > property & uses that to set up both the "cfg" and "periph" clocks. > > Simplifying for the sake of incremental fixes, the "correct" parentage for > the clocks currently supported in U-Boot is that the "cfg" clocks should > be children of the fixed frequency clock in the dt. The AHB clock is one > of these "cfg" clocks and is the parent of the "periph" clocks. > > Instead of passing the clock rate of the fixed-frequency clock to the > "cfg" and "periph" registration functions and the name of the parents, > pass their actual parents & use clk_get_rate() to determine their parents > rates. > > The "periph" clocks are purely gate clocks and should not be reading the > AHB clocks registers to determine their rates, as they can simply report > the output of clk_get_rate() on their parent. > > Signed-off-by: Conor Dooley > --- > drivers/clk/microchip/Makefile | 2 +- > drivers/clk/microchip/mpfs_clk.c | 18 ++++++++---------- > drivers/clk/microchip/mpfs_clk.h | 12 ++++-------- > drivers/clk/microchip/mpfs_clk_cfg.c | 7 +++---- > drivers/clk/microchip/mpfs_clk_periph.c | 16 ++++------------ > 5 files changed, 20 insertions(+), 35 deletions(-) Reviewed-by: Leo Yu-Chi Liang