From: Leo Liang <ycliang@andestech.com>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: Rick Chen <rick@andestech.com>, Lukasz Majewski <lukma@denx.de>,
"Sean Anderson" <seanga2@gmail.com>,
Padmarao Begari <padmarao.begari@microchip.com>,
<u-boot@lists.denx.de>
Subject: Re: [PATCH v1 4/6] clk: microchip: mpfs: fix periph clk parentage
Date: Wed, 2 Nov 2022 11:21:40 +0000 [thread overview]
Message-ID: <Y2JSxFZTV6Mr9g9P@ubuntu01> (raw)
In-Reply-To: <20221025075848.110754-5-conor.dooley@microchip.com>
On Tue, Oct 25, 2022 at 08:58:47AM +0100, Conor Dooley wrote:
> Not all "periph" clocks are children of the AHB clock, some have the AXI
> clock as their parent & the mtimer clock is derived from the external
> reference clock directly. Stop assuming the AHB clock to be the parent
> of all "periph" clocks and define their correct parents instead.
>
> Fixes: 2f27c9219e ("clk: Add Microchip PolarFire SoC clock driver")
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> drivers/clk/microchip/mpfs_clk.c | 4 +-
> drivers/clk/microchip/mpfs_clk.h | 4 +-
> drivers/clk/microchip/mpfs_clk_periph.c | 72 +++++++++++++------------
> 3 files changed, 42 insertions(+), 38 deletions(-)
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
next prev parent reply other threads:[~2022-11-02 11:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 7:58 [PATCH v1 0/6] clk: microchip: mpfs: incremental fixes Conor Dooley
2022-10-25 7:58 ` [PATCH v1 1/6] dt-bindings: clk: add missing clk ids for microchip mpfs Conor Dooley
2022-11-02 11:19 ` Leo Liang
2022-11-02 13:20 ` Padmarao.Begari
2022-10-25 7:58 ` [PATCH v1 2/6] clk: microchip: mpfs: convert parent rate acquistion to get_get_rate() Conor Dooley
2022-11-02 11:20 ` Leo Liang
2022-11-02 13:20 ` Padmarao.Begari
2022-11-02 16:41 ` Conor Dooley
2022-10-25 7:58 ` [PATCH v1 3/6] clk: microchip: mpfs: fix reference clock handling Conor Dooley
2022-11-02 11:21 ` Leo Liang
2022-11-02 13:20 ` Padmarao.Begari
2022-10-25 7:58 ` [PATCH v1 4/6] clk: microchip: mpfs: fix periph clk parentage Conor Dooley
2022-11-02 11:21 ` Leo Liang [this message]
2022-11-02 13:20 ` Padmarao.Begari
2022-10-25 7:58 ` [PATCH v1 5/6] clk: microchip: mpfs: fix criticality of peripheral clocks Conor Dooley
2022-11-02 11:22 ` Leo Liang
2022-11-02 13:20 ` Padmarao.Begari
2022-10-25 7:58 ` [PATCH v1 6/6] riscv: dts: fix the mpfs's reference clock frequency Conor Dooley
2022-11-02 11:22 ` Leo Liang
2022-11-02 13:21 ` Padmarao.Begari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2JSxFZTV6Mr9g9P@ubuntu01 \
--to=ycliang@andestech.com \
--cc=conor.dooley@microchip.com \
--cc=lukma@denx.de \
--cc=padmarao.begari@microchip.com \
--cc=rick@andestech.com \
--cc=seanga2@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox