From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 556C6C433FE for ; Mon, 21 Nov 2022 14:50:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 709DD852D3; Mon, 21 Nov 2022 15:50:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=boundarydevices.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=boundarydevices.com header.i=@boundarydevices.com header.b="huZUTUCZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E19F1852C5; Mon, 21 Nov 2022 15:50:34 +0100 (CET) Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9034A85063 for ; Mon, 21 Nov 2022 15:50:32 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=boundarydevices.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=gary.bisson@boundarydevices.com Received: by mail-wm1-x32b.google.com with SMTP id 5so8640032wmo.1 for ; Mon, 21 Nov 2022 06:50:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boundarydevices.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8k8zHFrTa11iRavGfc/yiXbcZvez5OJxWB0rjoVEQt0=; b=huZUTUCZ4R2K4EQh6qvdRZl5LEhrbONGNfnkuHMkHcDI6GMEpa/VAa/ysdpH50gnIG NxRfffg/k7IFQzaqY5+/+CFcyDjjAuQmui0F5v6tidfrQTBgvZw0MMbQPSVdZQSr4H// K2Lb6YujFAw+4W5VDkbq1PngOtenXyn4hJEbs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8k8zHFrTa11iRavGfc/yiXbcZvez5OJxWB0rjoVEQt0=; b=pPhY1CbX8hNsFzriW94LYAl90J0HMSy49vERwxrPiUmkLwy1t3B70J/cKHzBMm2ZG9 1vRCoagjP+uRCGvrQQjeAXzpAQH+U8h9Qkzzw4/lea/mR2Lx7tZ3GiRXBqLHVdWMOpU+ acJSvkR8T3nSE7wB2ut9NAco8T2Fg4PtTtKKBgsI/08PYyxVDEVsoumrP1kkXtd3Govc DROO/ZUed9++kXkhgnt395t16sJpIiQ4xMNG7dQyBs1YMdfAYxHwb8WShsXsN3vTmUj5 XvYeC0wjNLOm7xpC0SHTcQJCfsYrbjwX3fnZqZA12+FHVsxvYIovcraXCTlZuTgISTRx euWQ== X-Gm-Message-State: ANoB5plwiDZRx/Om6zBevCE4guAHubFLdNSq+0G56SJBv7fEf265FeAg sfu6C9iMzkyLSD/kUGd7bn1dnQ== X-Google-Smtp-Source: AA0mqf4TLhP04eU+vhulUMYhDu+seEZez/avHo4TchacxLSwbCM/It6kxOv97d9n7X89OqgoZOaasQ== X-Received: by 2002:a05:600c:4e4c:b0:3cf:87c6:890b with SMTP id e12-20020a05600c4e4c00b003cf87c6890bmr13295315wmq.194.1669042231999; Mon, 21 Nov 2022 06:50:31 -0800 (PST) Received: from p1g2 (2a01cb000f892400bac0522898b75ff0.ipv6.abo.wanadoo.fr. [2a01:cb00:f89:2400:bac0:5228:98b7:5ff0]) by smtp.gmail.com with ESMTPSA id c9-20020a5d5289000000b00236545edc91sm11411802wrv.76.2022.11.21.06.50.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 06:50:31 -0800 (PST) Date: Mon, 21 Nov 2022 15:50:30 +0100 From: Gary Bisson To: Sean Anderson Cc: u-boot@lists.denx.de, qianfanguijin@163.com, Troy Kisky , Peng Fan , sjg@chromium.org Subject: Re: [PATCH] Revert "lib: sparse: Make CHUNK_TYPE_RAW buffer aligned" Message-ID: References: <20221118121323.4009193-1-gary.bisson@boundarydevices.com> <79465afa-3528-7e1b-9d15-1258ef327f74@seco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <79465afa-3528-7e1b-9d15-1258ef327f74@seco.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi, On Fri, Nov 18, 2022 at 10:36:58AM -0500, Sean Anderson wrote: > On 11/18/22 07:13, Gary Bisson wrote: > > This reverts commit 62649165cb02ab95b57360bb362886935f524f26. > > > > The patch decreased the write performance quite a bit. > > Here is an example on an i.MX 8M Quad platform. > > - Before the revert: > > Sending sparse 'vendor' 1/2 (516436 KB) OKAY [ 5.113s] > > Writing 'vendor' OKAY [128.335s] > > Sending sparse 'vendor' 2/2 (76100 KB) OKAY [ 0.802s] > > Writing 'vendor' OKAY [ 27.902s] > > - After the revert: > > Sending sparse 'vendor' 1/2 (516436 KB) OKAY [ 5.310s] > > Writing 'vendor' OKAY [ 18.041s] > > Sending sparse 'vendor' 2/2 (76100 KB) OKAY [ 1.244s] > > Writing 'vendor' OKAY [ 2.663s] > > > > Considering that the patch only moves buffer around to avoid a warning > > message about misaligned buffers, let's keep the best performances. > > So what is the point of this warning? Well the warning does say something true that the cache operation is not aligned. Better ask Simon as he's the one who changed the print from a debug to warn_non_spl one: bcc53bf0958 arm: Show cache warnings in U-Boot proper only BTW, in my case I couldn't see the misaligned messages, yet I saw the performance hit described above. Regards, Gary