From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34BCFC4332F for ; Tue, 29 Nov 2022 07:14:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8F47F8532D; Tue, 29 Nov 2022 08:14:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="vOjcJNB7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F051085331; Tue, 29 Nov 2022 08:14:46 +0100 (CET) Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EE5AF8532E for ; Tue, 29 Nov 2022 08:14:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ed1-x535.google.com with SMTP id z18so18512386edb.9 for ; Mon, 28 Nov 2022 23:14:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sLnC2xOA7vWlNscNARlIKll//BypKpnjLCBBXBv89Yw=; b=vOjcJNB7om4FsC6BL01/w+O4TXQoKQKUl/V0+WVWcUlURYylIFDZMqsHx6CKtIiuPC vNEJot29WrIPsIbhwveEfLjBYSUrthGOEx8HyOhiG/YpmOwmrVFH4hRUMcfBTq1w5qGd MJvQXvfMNpACsaQyqX0QQb3pN2jvXKyg3ZRcjzHx9okMPkZig/LTrZwXvEALBQZI90B7 QcIKN8s0R+TpnYxwsgqLtEzQ3D/jc2TuipkRKZePlZgHeacDmjuINM23W9Ja5Q+j2pHT 3QmSe3jObfB5I97iizhJKZMlwIOaTZWpwCFisaVKZcltxXC9FzGgLfs2O7BNXi3aWPdb oeHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sLnC2xOA7vWlNscNARlIKll//BypKpnjLCBBXBv89Yw=; b=cT7ssN1CoqBd+JnKGdOqHAT+iiCA/yR13UnPqKL1zaYgdoNORlQChXB1sq3hWpiT8e PSTyxwPk2FTz9HLbfrYYIEcwTAU94I2C9iWEx5377thdZ+c356SYeFzjdeRAgqy107rg 1hWpTHzLGD7z+EI7IuV8goKUP5MrllSAtr6dMw0tWC26k5RJB/0hWayA3lE8XwkTXZm7 ZzKByd6H91LcAFh8YidVT2oHjmr6h3oK6+2U4urPsghzxz0sQtj/tYLppBlzg77I7RcA TBaIJUdPM0gNIpmi3WNm8yYJysHZmOg0BWOmCQyyL3yaXPNLEXbZRdOvkQ+fWVi7iBhX oTGw== X-Gm-Message-State: ANoB5pmvdhHoCsbRQpb9tzknToCrXhP1UA8TIeP1QfB1jwMJNKDCuWeB 8C9chDFzhCud6CiWmLnqoqJZNg== X-Google-Smtp-Source: AA0mqf7fyTsa0386vV/2kr/aii06AYQtEvtIEVSb/Ayi+d4zXCF4Qtp+3Mij+nUGztqrfZZeChHY6g== X-Received: by 2002:a05:6402:43cf:b0:46b:56dd:4b2a with SMTP id p15-20020a05640243cf00b0046b56dd4b2amr5419106edc.411.1669706084616; Mon, 28 Nov 2022 23:14:44 -0800 (PST) Received: from hera (ppp078087234022.access.hol.gr. [78.87.234.22]) by smtp.gmail.com with ESMTPSA id lb25-20020a170907785900b007933047f923sm5786677ejc.118.2022.11.28.23.14.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 23:14:44 -0800 (PST) Date: Tue, 29 Nov 2022 09:14:42 +0200 From: Ilias Apalodimas To: Masahisa Kojima Cc: u-boot@lists.denx.de, Heinrich Schuchardt , Jerome Forissier Subject: Re: [PATCH v2 1/5] eficonfig: fix going one directory up issue Message-ID: References: <20221128124509.6939-1-masahisa.kojima@linaro.org> <20221128124509.6939-2-masahisa.kojima@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221128124509.6939-2-masahisa.kojima@linaro.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Mon, Nov 28, 2022 at 09:45:05PM +0900, Masahisa Kojima wrote: > The directory name in eficonfig menu entry contains the > '\' separator. strcmp() argument ".." is wrong and one directory > up handling does not work correctly. strcmp() argument must > include '\' separator. > > Signed-off-by: Masahisa Kojima > --- > No change since v1 > > cmd/eficonfig.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cmd/eficonfig.c b/cmd/eficonfig.c > index 97d35597a2..5529edc85e 100644 > --- a/cmd/eficonfig.c > +++ b/cmd/eficonfig.c > @@ -488,7 +488,7 @@ static efi_status_t eficonfig_file_selected(void *data) > if (!info) > return EFI_INVALID_PARAMETER; > > - if (!strcmp(info->file_name, "..")) { > + if (!strcmp(info->file_name, "..\\")) { > struct eficonfig_filepath_info *iter; > struct list_head *pos, *n; > int is_last; > -- > 2.17.1 > Reviewed-by: Ilias Apalodimas