From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63EFBC4332F for ; Thu, 22 Dec 2022 13:00:51 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9A42D83A08; Thu, 22 Dec 2022 14:00:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="c+klOBBD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 33D5A851D7; Thu, 22 Dec 2022 14:00:48 +0100 (CET) Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CFDBF817FB for ; Thu, 22 Dec 2022 14:00:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ej1-x629.google.com with SMTP id vv4so4764153ejc.2 for ; Thu, 22 Dec 2022 05:00:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lLyB0f9ngwFRQ8MQxYIz7z+42M6MOZ3aI6wR1tkidk8=; b=c+klOBBDO4S+o185cxlMyJL5J8mJK80RMeB6UL2fV6Dn8X1G65En9tJuBxldU5Ni4E nHIh/BYXjq472aaVl+9GTXQQcNJjlZV79rsMduN7qzbdRcJvEzGxHpkhHOFeiHAKuHDY QVDI5eCg9JzU1PVSJbkS65R7kbtvBp4obNv5RXEDfwGDLO6gbCZGDsqlRJ3qAjtrh4m2 6WdMgzXAkSBGaHyaSxKrd0ml6rK0WMQwpPo3dYajxk97MCVkg5/5GiwxvYB1MTT9/T5U 09X62ifyfmG52UhR2QLQAJ8Tp/11Yy3tgNBLg3ryk2dFgMiwhoqODlOktrlV8HZ46+No YZqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lLyB0f9ngwFRQ8MQxYIz7z+42M6MOZ3aI6wR1tkidk8=; b=2EQZyhowomMoutLT55PkSVDX3NO/mR3Gp/ISJbNB0DWldtc8GzcLPRKWLMhRJNcjqX DSeZIJ3Uy0K+Vuj0wqHdn7POGLB9inPpnJMM4MsmRCvF4Nd0r9n2mtu1JG+c7kpzTJmM L99S62tdYKWSECpE5N+mtjhgVwaFlZr6ZY7FjFaxvZ3wwBsh/53IkMCgIhwMmd9qZy5W GLH5dSB7hGUTGBWIzzGAoOe9B2GUmvIxSeT0Bk5YqZgo1tAAtYtBNmOguA05Yk8RRVOS 05oAUvIMwhlCDZw8tSbVLpdkUVMsLH3CyofollFMCguI8UUWQYYDT7FD5AoLpBshzt+A sLfg== X-Gm-Message-State: AFqh2kqzJltqNsgEf/vwBTX3q1IB0tomKPZDM873toARpldga5dYxtHD DoJBkQ6cY7SS6vCDhovt4oUo9Q== X-Google-Smtp-Source: AMrXdXsz+GX4i2uQWET1rxIghOTp4VG3Nu7Q4IU9IblLJyJj5rTwZI4NSBOephPgAAwwh0co0lZhfg== X-Received: by 2002:a17:906:dfcd:b0:7ff:7876:9c5d with SMTP id jt13-20020a170906dfcd00b007ff78769c5dmr4542446ejc.62.1671714045456; Thu, 22 Dec 2022 05:00:45 -0800 (PST) Received: from hera (ppp079167090036.access.hol.gr. [79.167.90.36]) by smtp.gmail.com with ESMTPSA id k12-20020a170906680c00b007c14d4c9633sm229934ejr.99.2022.12.22.05.00.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Dec 2022 05:00:45 -0800 (PST) Date: Thu, 22 Dec 2022 15:00:42 +0200 From: Ilias Apalodimas To: jassisinghbrar@gmail.com Cc: u-boot@lists.denx.de, sughosh.ganu@linaro.org, etienne.carriere@linaro.org, trini@konsulko.com, sjg@chromium.org, xypron.glpk@gmx.de, patrick.delaunay@foss.st.com, patrice.chotard@foss.st.com, Jassi Brar Subject: Re: [PATCHv2 5/4] fwu: rename fwu_get_verified_mdata to fwu_get_mdata Message-ID: References: <20221203031557.579632-1-jassisinghbrar@gmail.com> <20221203032813.580081-1-jassisinghbrar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221203032813.580081-1-jassisinghbrar@gmail.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Fri, Dec 02, 2022 at 09:28:13PM -0600, jassisinghbrar@gmail.com wrote: > From: Jassi Brar > > fwu_get_mdata() sounds more appropriate than fwu_get_verified_mdata() > > Signed-off-by: Jassi Brar > --- > Forgot to send this patch previously in v2 > cmd/fwu_mdata.c | 2 +- > include/fwu.h | 4 ++-- > lib/fwu_updates/fwu.c | 6 +++--- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/cmd/fwu_mdata.c b/cmd/fwu_mdata.c > index 9b70340368..5ecda455df 100644 > --- a/cmd/fwu_mdata.c > +++ b/cmd/fwu_mdata.c > @@ -46,7 +46,7 @@ int do_fwu_mdata_read(struct cmd_tbl *cmdtp, int flag, > int ret = CMD_RET_SUCCESS, res; > struct fwu_mdata mdata; > > - res = fwu_get_verified_mdata(&mdata); > + res = fwu_get_mdata(&mdata); > if (res < 0) { > log_err("Unable to get valid FWU metadata\n"); > ret = CMD_RET_FAILURE; > diff --git a/include/fwu.h b/include/fwu.h > index 23bd97fe86..ea25aca2cd 100644 > --- a/include/fwu.h > +++ b/include/fwu.h > @@ -80,7 +80,7 @@ int fwu_read_mdata(struct udevice *dev, struct fwu_mdata *mdata, bool primary); > int fwu_write_mdata(struct udevice *dev, struct fwu_mdata *mdata, bool primary); > > /** > - * fwu_get_verified_mdata() - Read, verify and return the FWU metadata > + * fwu_get_mdata() - Read, verify and return the FWU metadata > * > * Read both the metadata copies from the storage media, verify their checksum, > * and ascertain that both copies match. If one of the copies has gone bad, > @@ -88,7 +88,7 @@ int fwu_write_mdata(struct udevice *dev, struct fwu_mdata *mdata, bool primary); > * > * Return: 0 if OK, -ve on error > */ > -int fwu_get_verified_mdata(struct fwu_mdata *mdata); > +int fwu_get_mdata(struct fwu_mdata *mdata); > > /** > * fwu_get_active_index() - Get active_index from the FWU metadata > diff --git a/lib/fwu_updates/fwu.c b/lib/fwu_updates/fwu.c > index 3d11d92fb9..77444ba2de 100644 > --- a/lib/fwu_updates/fwu.c > +++ b/lib/fwu_updates/fwu.c > @@ -191,7 +191,7 @@ static inline int mdata_crc_check(struct fwu_mdata *mdata) > } > > /** > - * fwu_get_verified_mdata() - Read, verify and return the FWU metadata > + * fwu_get_mdata() - Read, verify and return the FWU metadata > * > * Read both the metadata copies from the storage media, verify their checksum, > * and ascertain that both copies match. If one of the copies has gone bad, > @@ -199,7 +199,7 @@ static inline int mdata_crc_check(struct fwu_mdata *mdata) > * > * Return: 0 if OK, -ve on error > */ > -int fwu_get_verified_mdata(struct fwu_mdata *mdata) > +int fwu_get_mdata(struct fwu_mdata *mdata) > { > int err; > bool pri_ok, sec_ok; > @@ -629,7 +629,7 @@ static int fwu_boottime_checks(void *ctx, struct event *event) > return ret; > } > > - ret = fwu_get_verified_mdata(NULL); > + ret = fwu_get_mdata(NULL); > if (ret) { > log_debug("Unable to read meta-data\n"); > return ret; > -- > 2.34.1 > Reviewed-by: Ilias Apalodimas