From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3ED2C4332F for ; Thu, 22 Dec 2022 12:59:54 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 124318532E; Thu, 22 Dec 2022 13:59:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="R1jQA6Gc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8DE3885353; Thu, 22 Dec 2022 13:59:51 +0100 (CET) Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 48189852E7 for ; Thu, 22 Dec 2022 13:59:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ej1-x62c.google.com with SMTP id jo4so4706889ejb.7 for ; Thu, 22 Dec 2022 04:59:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cNLtf8IoUpdNVYstfYiMBSZ4PP8UyVTizI9HI7+iC9c=; b=R1jQA6GcmID4javCcPQKg2RWgw42GfufDx0di/U0wXOK03B7ZZga2S5n4AwI6/snpP Hvnt6R7VCOCvRkGKIbImcWyRWzU8UXS1knvqiYSqFsIu/xACGti0QK1t1fdHWURhCRkl ywXmyzUVklcqFwJiGz0L2m1iSur+Auq9vFF8ZLyj01MIXIv+4ejsF0Cuzf16ZO9eZzB+ ZwCtgnDG8oGkTUgKKNS9ajoKEh8d1+E3S4r/xLjzjwUQG2MmIDkNlRTstUoUxQCZUQ4k D26mDu2ZYr/X+MneRbiATfP+iLooqWbFkZZKJhsLeKkQjYui5XpznopnbO3EpnskQqpY apuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cNLtf8IoUpdNVYstfYiMBSZ4PP8UyVTizI9HI7+iC9c=; b=4m1feX7w+nZunNImiAzdrQhycLIp6hm2e7gccaBo3U+fVgdd3CnvordU5zsk7dXWGt 01JBd4DLFPJMBMLdAgqhtY4oqbpyLJEmcNn8Jg6VkXovZgsGsE6geQaC5qCppYITzi4W x6oEdGR9MCWcGHj4aCKlJ8vdMxobQiVvdFfIIgMZ8A+Kp6APO7O9Z0TzGKPdhMqnqG/g zWgVxa7JSq3nSQ4URe8mKju0JtqWi1ME66kBmssboc4PUct8fYbW2jf3vvYmzkmfsjbC Si3OfwoVcUSy9Yi5u7naFua+YyaMTGtY2ybZsaN7Durpjx1Dzl8EVoWepYXo34qizuNp ykgA== X-Gm-Message-State: AFqh2kpLbpupZy2JxMrdFxb3blpCYEhmHGTY6GsWwtMxJYRmNRSXZH9/ ltha/DUkPm99Hvaqd7IQf7c6LA== X-Google-Smtp-Source: AMrXdXsuwqy/B78+1esvcsz+rEZyV+ESf6jUp8/HhhWwRAZJRCVNYq7lKxqhtGMbLMzhEOiRVhI/SQ== X-Received: by 2002:a17:906:8384:b0:838:9aba:6a06 with SMTP id p4-20020a170906838400b008389aba6a06mr4503046ejx.39.1671713988857; Thu, 22 Dec 2022 04:59:48 -0800 (PST) Received: from hera (ppp079167090036.access.hol.gr. [79.167.90.36]) by smtp.gmail.com with ESMTPSA id s8-20020a170906354800b007ad2da5668csm218858eja.112.2022.12.22.04.59.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Dec 2022 04:59:48 -0800 (PST) Date: Thu, 22 Dec 2022 14:59:46 +0200 From: Ilias Apalodimas To: jassisinghbrar@gmail.com Cc: u-boot@lists.denx.de, sughosh.ganu@linaro.org, etienne.carriere@linaro.org, trini@konsulko.com, sjg@chromium.org, xypron.glpk@gmx.de, patrick.delaunay@foss.st.com, patrice.chotard@foss.st.com, Jassi Brar Subject: Re: [PATCHv2 3/4] fwu: gpt: implement read_mdata and write_mdata callbacks Message-ID: References: <20221203031557.579632-1-jassisinghbrar@gmail.com> <20221203031712.579809-1-jassisinghbrar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221203031712.579809-1-jassisinghbrar@gmail.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Jassi, On Fri, Dec 02, 2022 at 09:17:12PM -0600, jassisinghbrar@gmail.com wrote: > From: Jassi Brar > > Moving towards using common code for meta-data management, > implement the read/write mdata hooks. > > Signed-off-by: Jassi Brar > --- > drivers/fwu-mdata/gpt_blk.c | 40 +++++++++++++++++++++++++++++++++++-- > 1 file changed, 38 insertions(+), 2 deletions(-) > > diff --git a/drivers/fwu-mdata/gpt_blk.c b/drivers/fwu-mdata/gpt_blk.c > index 28f5d23e1e..35239c0a4f 100644 > --- a/drivers/fwu-mdata/gpt_blk.c > +++ b/drivers/fwu-mdata/gpt_blk.c > @@ -222,7 +222,7 @@ static int fwu_gpt_read_mdata_partition(struct udevice *dev, > struct fwu_mdata_gpt_blk_priv *priv = dev_get_priv(dev); > > return gpt_read_write_mdata(dev_get_uclass_plat(priv->blk_dev), > - mdata, MDATA_READ, part_num); > + mdata, MDATA_READ, part_num); I assume this was by mistake? > } > > static int fwu_gpt_write_mdata_partition(struct udevice *dev, > @@ -231,7 +231,7 @@ static int fwu_gpt_write_mdata_partition(struct udevice *dev, > struct fwu_mdata_gpt_blk_priv *priv = dev_get_priv(dev); > > return gpt_read_write_mdata(dev_get_uclass_plat(priv->blk_dev), > - mdata, MDATA_WRITE, part_num); > + mdata, MDATA_WRITE, part_num); ditto > } > > static int fwu_get_mdata_device(struct udevice *dev, struct udevice **mdata_dev) > @@ -272,7 +272,43 @@ static int fwu_mdata_gpt_blk_probe(struct udevice *dev) > return 0; > } > > +static int fwu_gpt_read_mdata(struct udevice *dev, struct fwu_mdata *mdata, > + bool primary) > +{ > + struct fwu_mdata_gpt_blk_priv *priv = dev_get_priv(dev); > + struct blk_desc *desc = dev_get_uclass_plat(priv->blk_dev); > + int ret; > + > + ret = gpt_get_mdata_partitions(desc); > + if (ret < 0) { > + log_debug("Error getting the FWU metadata partitions\n"); > + return -ENOENT; > + } > + > + return gpt_read_write_mdata(desc, mdata, MDATA_READ, > + primary ? g_mdata_part[0] : g_mdata_part[1]); > +} > + > +static int fwu_gpt_write_mdata(struct udevice *dev, struct fwu_mdata *mdata, > + bool primary) > +{ > + struct fwu_mdata_gpt_blk_priv *priv = dev_get_priv(dev); > + struct blk_desc *desc = dev_get_uclass_plat(priv->blk_dev); > + int ret; > + > + ret = gpt_get_mdata_partitions(desc); > + if (ret < 0) { > + log_debug("Error getting the FWU metadata partitions\n"); > + return -ENOENT; > + } > + > + return gpt_read_write_mdata(desc, mdata, MDATA_WRITE, > + primary ? g_mdata_part[0] : g_mdata_part[1]); > +} > + > static const struct fwu_mdata_ops fwu_gpt_blk_ops = { > + .read_mdata = fwu_gpt_read_mdata, > + .write_mdata = fwu_gpt_write_mdata, > .get_mdata = fwu_gpt_get_mdata, > .update_mdata = fwu_gpt_update_mdata, > .get_mdata_part_num = fwu_gpt_get_mdata_partitions, > -- > 2.34.1 > Other than that Reviewed-by: Ilias Apalodimas