From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9125C46467 for ; Wed, 4 Jan 2023 10:12:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B7A1E8557C; Wed, 4 Jan 2023 11:12:32 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="ZJvBZFPl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1D4B28557E; Wed, 4 Jan 2023 11:12:31 +0100 (CET) Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6EE0685578 for ; Wed, 4 Jan 2023 11:12:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ed1-x530.google.com with SMTP id s5so47874907edc.12 for ; Wed, 04 Jan 2023 02:12:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=T6OjDYfyRvB4GgzPsOmgJ/wGTnP8o+bulyMcfYjBLw0=; b=ZJvBZFPlklN/78qLzawBjqT49tTqcc3ka68nw2igPWrCeYS6R4T7vyF9GvDFI0Gwoj j057nJgmiAQAV+xFk3xkKPMIx1tBzOA6pADqQzNA4Pu8pbQBHSOaJUBQXoRqibv8Iq2z gqwMqb8nG1jLq9Hymqiv+rln3RJvIWNiPNbpSPeEgWRI03QaIyqoXwenKSh5tj2Of1A4 LZPxBGzKqmxWmYIDdZIzWJrFwaXHElJrtSP2US7GvJs/6LWpIjGzIYGmQkUEtYDr8kqm zSnVYY7LFsp/WJBpa7D67sL3pTdmHYgiz8EO6UuYzTRZQztaGIuHI5mBuICRFbO5rNf6 3uQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T6OjDYfyRvB4GgzPsOmgJ/wGTnP8o+bulyMcfYjBLw0=; b=d1KXANFwKxmlcGRMLb2rx8hDkRt8j5NE1JjmfkJ0FG5Bv/fLujU6TRgRMwDYtkRbyq Y4+gDNgwRJXTAtLGxfOkOp1pJCCJqaauoPAZ7etYMIKuCiwvk5wBhOVJENp56KmRv0dj 3feKdIdB0cBC87XdaPajCVyBD6PZAvkreK4AZc74XDDBilsKLgGV9gGBhtMH7CXdIPFc RBueHigGBbh8iTsgWvl9QPohwEypFDlG/+Da/ay0Z6nsolj1+zaTw+EREzve2pixKmQE Fu+CQaoRWBTCS+kWyfsNmfoRrMpvjRJq/BIXcJEzj7jWLdi80mPoxDT3/s+4yQSDfgJN S19w== X-Gm-Message-State: AFqh2kpGw5MO0IWfi2czBzkMhVfQxU3n5bXoc0A3DtyUtricZyaeKs2v pZeIO+IFAD8vS9wZIIS5sVNmMw== X-Google-Smtp-Source: AMrXdXsFN6CUuz12W/ukiufnsGh/QuC9oGYUPWkV9+Dpzee0BOu0fr+Qdw5rGxIZv+rG4D6N4D2wlQ== X-Received: by 2002:aa7:da82:0:b0:482:3a35:bb3a with SMTP id q2-20020aa7da82000000b004823a35bb3amr33860127eds.14.1672827148130; Wed, 04 Jan 2023 02:12:28 -0800 (PST) Received: from hades (ppp079167090036.access.hol.gr. [79.167.90.36]) by smtp.gmail.com with ESMTPSA id co5-20020a0564020c0500b00483dd234ac6sm12303853edb.96.2023.01.04.02.12.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 02:12:27 -0800 (PST) Date: Wed, 4 Jan 2023 12:12:25 +0200 From: Ilias Apalodimas To: Heinrich Schuchardt Cc: u-boot@lists.denx.de Subject: Re: [PATCH 1/1] efi_loader: populate console handles in system table Message-ID: References: <20230104050446.144658-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230104050446.144658-1-heinrich.schuchardt@canonical.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Wed, Jan 04, 2023 at 06:04:46AM +0100, Heinrich Schuchardt wrote: > The fields ConsoleInHandle, ConsoleOutHandle, ConsoleErrHandle must point > to the handles with the respective console protocols. Failure to do so > leads to an error in the EFI Shell: > > No SimpleTextInputEx was found. CTRL-based features are not usable. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_boottime.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c > index 253f9f75ef..e65ca6a4cb 100644 > --- a/lib/efi_loader/efi_boottime.c > +++ b/lib/efi_loader/efi_boottime.c > @@ -3956,8 +3956,11 @@ efi_status_t efi_initialize_system_table(void) > * These entries will be set to NULL in ExitBootServices(). To avoid > * relocation in SetVirtualAddressMap(), set them dynamically. > */ > + systab.con_in_handle = efi_root; > systab.con_in = &efi_con_in; > + systab.con_out_handle = efi_root; > systab.con_out = &efi_con_out; > + systab.stderr_handle = efi_root; > systab.std_err = &efi_con_out; > systab.boottime = &efi_boot_services; > > -- > 2.37.2 > Reviewed-by: Ilias Apalodimas