From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F9A9C4332F for ; Wed, 4 Jan 2023 12:01:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9E7FC85117; Wed, 4 Jan 2023 13:01:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="lu/Gpzu8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0ED7485196; Wed, 4 Jan 2023 13:01:22 +0100 (CET) Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8C92983673 for ; Wed, 4 Jan 2023 13:01:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ed1-x529.google.com with SMTP id z11so32399855ede.1 for ; Wed, 04 Jan 2023 04:01:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fVbECxvz7GX2x0yrrL48Scn+WKNDOF7XE6pkbJVFnFg=; b=lu/Gpzu8vRUZO0cK5HAte+6Wnwuz/YY+8aFVX1Z68cT1qySfdZ6eTsWh1Hp4xFPah4 myt7g9pVlrmnILXaZHgNafL7hWBggjJ5lbcC2ak+1jrUlk9BVod+1blZzJAzgYeaPngN rg8BUxcXhMg0VJ7Sm/tqjuTXZRq0/TXqKIHWujbCophicPDbqYV+/lE8cdlUc8le3EAn krO9QQfzsotWswbtpeaXf4dQXMYym40pSv4HJbf5+AzAIOgLqADkPbnv7aZHrC/6oVQQ hFQzFtbd2aFET9MYUgrrD08YWddVLpV6Xo3Rgepfcl0UVyPuBsgftE1xiqjrg0cKcvj0 oOpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fVbECxvz7GX2x0yrrL48Scn+WKNDOF7XE6pkbJVFnFg=; b=4bRl7BewKkNHWF99+aoda7GES7t4jl7OKlJ2BpntJd4vWNmUNm4aRDAyRdT7KScCo/ byeSVZ6QVcESNYHPog4xQpKEAVpJazlQeE6xq+Aj2mhqFW8SZyvO/wMpqqeKl4j8CmwG yT0P1TXFm4gPp/Sr/CnAzc7JHZlM8Av52mDruAFkK71vOs01rO9VqWL8GMcY4cRAK9tD SIKxc4362pdv2Jb4kBR1DsTMgZX6k/LZWoID7TELz7Otc/YywRY6fGWBcWDZgQJ/Xm4v d/dx987JFqhGwam3zDVaz2neA9CXx6b1+HFO50XBi+uyIasMlbk4lnPxgDI74iVnFwEV fY6Q== X-Gm-Message-State: AFqh2kpJeUJIOhMhrrOkrTQdyEWrsfiwFrHQ4BmxgX5rW0F19zsOyTUH fmuEcRE8VvySHU3iLWqeyYa3LA== X-Google-Smtp-Source: AMrXdXvGYD7ehPyp1jxGBo6RAMDnRIFdZGE6FkB4zOCTX24wPA5KyLGI3mWFNp3Rd+13GSogTjV/ww== X-Received: by 2002:aa7:df92:0:b0:490:47c3:3d79 with SMTP id b18-20020aa7df92000000b0049047c33d79mr395892edy.28.1672833679015; Wed, 04 Jan 2023 04:01:19 -0800 (PST) Received: from hades (ppp079167090036.access.hol.gr. [79.167.90.36]) by smtp.gmail.com with ESMTPSA id x11-20020aa7cd8b000000b0048eba29c3a0sm2069733edv.51.2023.01.04.04.01.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 04:01:18 -0800 (PST) Date: Wed, 4 Jan 2023 14:01:16 +0200 From: Ilias Apalodimas To: Heinrich Schuchardt Cc: u-boot@lists.denx.de Subject: Re: [PATCH v2 2/2] efi_loader: fix building aarch64 EFI binaries Message-ID: References: <20230104114435.21738-1-heinrich.schuchardt@canonical.com> <20230104114435.21738-3-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230104114435.21738-3-heinrich.schuchardt@canonical.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Heinrich > + .short 0 /* NumberOfRelocations */ > + .short 0 /* NumberOfLineNumbers */ > + .long 0xc0000040 /* Characteristics (section flags) */ You probably forgot to remove this line > + /* Characteristics (section flags) */ > + .long (IMAGE_SCN_MEM_WRITE | \ > + IMAGE_SCN_MEM_READ | \ > + IMAGE_SCN_CNT_INITIALIZED_DATA) > > - .align 9 > + .align 12 > _start: > stp x29, x30, [sp, #-32]! > mov x29, sp > diff --git a/arch/arm/lib/elf_aarch64_efi.lds b/arch/arm/lib/elf_aarch64_efi.lds > index c0604dad46..ffc6f6e604 100644 > --- a/arch/arm/lib/elf_aarch64_efi.lds > +++ b/arch/arm/lib/elf_aarch64_efi.lds > @@ -18,11 +18,13 @@ SECTIONS > *(.gnu.linkonce.t.*) > *(.srodata) > *(.rodata*) > + . = ALIGN(16); > + *(.dynamic); > . = ALIGN(512); > } > _etext = .; > _text_size = . - _text; > - .dynamic : { *(.dynamic) } > + . = ALIGN(4096); > .data : { > _data = .; > *(.sdata) > @@ -48,11 +50,11 @@ SECTIONS > _bss_end = .; > _edata = .; > } > + _data_size = _edata - _data; > .rela.dyn : { *(.rela.dyn) } > .rela.plt : { *(.rela.plt) } > .rela.got : { *(.rela.got) } > .rela.data : { *(.rela.data) *(.rela.data*) } > - _data_size = . - _etext; > > . = ALIGN(4096); > .dynsym : { *(.dynsym) } > -- > 2.37.2 > with that fix Reviewed-by: Ilias Apalodimas