From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD6C2C25B4E for ; Tue, 24 Jan 2023 08:41:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6A5F485518; Tue, 24 Jan 2023 09:41:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=dolcini.it Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=mailserver.it header.i=@mailserver.it header.b="eUoT0Pxa"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EBE1E8557E; Tue, 24 Jan 2023 09:41:48 +0100 (CET) Received: from smtp-out-06.comm2000.it (smtp-out-06.comm2000.it [212.97.32.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 770F88539D for ; Tue, 24 Jan 2023 09:41:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=dolcini.it Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=francesco@dolcini.it Received: from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: francesco@dolcini.it) by smtp-out-06.comm2000.it (Postfix) with ESMTPSA id A6095562BC8; Tue, 24 Jan 2023 09:41:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailserver.it; s=mailsrv; t=1674549706; bh=kR7BaXHU+wnY37cKafti41b8P1PfU7Pryz9AuILmwEU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=eUoT0PxaIDi9B5slisnkIpWEBVFjN/zF41pdCU8uJGqYTi9Yg0gI7gUWl8t3oJYyw jfwq0kx3+UZDLB80hsWtfVxoEK0ckneSBxLTijne3BKl4zGD3m6Vu/Qti/Q94p6YI4 Q12cfIJqevTytlIhoDI3Ud7xrXFekMGfZ5u1ooTxCL0GhHmBFtbjDMwE4BE7Ntpcqs v6ZGQtGcpIiM9QpvMCuRsWvIdJ62rRAh2nhw2NhGuaUXOScxuiXpSaz2/nkxh124hz bUh477FA40XK2z9904eA4002QuRGUDt2Y4znML9Fr9rVCZJtoF0U6GH985i4E3A7zR CsoW56nv6nEwA== Date: Tue, 24 Jan 2023 09:41:41 +0100 From: Francesco Dolcini To: Miquel Raynal Cc: Marek Vasut , Francesco Dolcini , Simon Glass , u-boot@lists.denx.de, Marcel Ziswiler , Francesco Dolcini , linux-mtd@lists.infradead.org Subject: Re: [PATCH v1 1/3] fdt: validate/fix cells count on mtdpart fixup Message-ID: References: <20230113184547.487322-1-francesco@dolcini.it> <20230113184547.487322-2-francesco@dolcini.it> <9ed3b4e4-7336-baf3-5a5a-8e77543e210d@denx.de> <06279fe3-a3b3-f3c4-276f-7cd0d4773875@denx.de> <0584cc0e-eacb-ce71-0317-27d10264d3bf@denx.de> <20230123105610.38034a11@xps-13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230123105610.38034a11@xps-13> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hello Miquel, On Mon, Jan 23, 2023 at 10:56:10AM +0100, Miquel Raynal wrote: > marex@denx.de wrote on Tue, 17 Jan 2023 01:59:54 +0100: > > > On 1/16/23 19:00, Francesco Dolcini wrote: > > > On Mon, Jan 16, 2023 at 06:54:44PM +0100, Marek Vasut wrote: > > >> On 1/16/23 15:20, Francesco Dolcini wrote: > > >>> On Sun, Jan 15, 2023 at 03:35:25PM +0100, Marek Vasut wrote: > > >>>> On 1/13/23 19:45, Francesco Dolcini wrote: > > >>>>> From: Francesco Dolcini > > >>>>> > > >>>>> Fixup #size-cells value when updating the MTD partitions, this is > > >>>>> required to prevent issues in case the MTD parent set #size-cells to > > >>>>> zero. > > >>>>> This could happen for example in the legacy case in which the partitions > > >>>>> are created as direct child of the mtd node and that specific node has > > >>>>> no children. Recent clean-up on Linux device tree files created a boot > > >>>>> regression on colibri-imx7. > > >>>>> > > >>>>> This fixup has the limitation to assume 32-bit (#size-cells=1) > > >>>>> addressing, therefore it will not work with device bigger than 4GiB. > > >>>>> > > >>>>> This change also enforce #address-cells to be the same as #size-cells, > > >>>>> this was already silently enforced by fdt_node_set_part_info(), now this > > >>>>> is checked explicitly and partition fixup will just fail in such case. > > >>>>> > > >>>>> In general board should not generally need nor use this functionality > > >>>>> and should be just deprecated, passing mtdparts= in the kernel command > > >>>>> line is the preferred way according to Linux MTD subsystem maintainer. > > Just to be clear, I'm perfectly fine with the partitions being either > on the cmdline or in the DT without preference (well, the cmdline only > works with the simple generic parser, but whatever). What I really > meant is that tweaking the DT from U-Boot should be rare and in no case > the "right thing to add partitions". Miquel, should I send a v2 to clarify the commit message or you do not mind keeping it as it is? Francesco