From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE5A7C3DA78 for ; Tue, 17 Jan 2023 15:21:03 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1236F8559B; Tue, 17 Jan 2023 16:21:01 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=metanate.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=metanate.com header.i=@metanate.com header.b="QcoG3z8V"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 72E1A855BA; Tue, 17 Jan 2023 16:20:59 +0100 (CET) Received: from metanate.com (unknown [IPv6:2001:8b0:1628:5005::111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D291484D64 for ; Tue, 17 Jan 2023 16:20:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=metanate.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=john@metanate.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metanate.com; s=stronger; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-ID:Content-Description; bh=c2swQkz08xBPnHFoX+KimECIyDAwz14Ez4FL7HgGgWY=; b=QcoG3z8VjxxxUCRCAw0lhqqO4B nF1vSOvtMK0at96uGoIb3kQYP+Gp7jlPSBOx6wWb+9sUYrlyhcKjJ9rYUOUWlb//Mpymy+TZFiSLu 19v4zJeePR0CDxOYi077m+rZkxFQwo5v91no2XU3YjMsp4jIH3kBT6Br4KQNf6zieNYj/lmwUV6gd xPP1X546dGIsOF1RccC4JZl7zwfLyH9nHJQOhjvarvPJjx+OA5uFQs9bKd/IdpxuTEucyzA9SlONU QZEXGapiDP2JZZR/8ru7rXS7NEnRobij5yqQihXqxfCoDQ1rzVpB73eopTrhc4fc6lo8bqo9jcdtg rHnsqDnw==; Received: from [81.174.171.191] (helo=donbot) by email.metanate.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pHnlU-00075o-VX; Tue, 17 Jan 2023 15:20:45 +0000 Date: Tue, 17 Jan 2023 15:20:43 +0000 From: John Keeping To: Johan Jonker Cc: Quentin Schulz , kever.yang@rock-chips.com, sjg@chromium.org, philipp.tomsich@vrull.eu, u-boot@lists.denx.de, Heiko Stuebner , "open list:ARM/Rockchip SoC support" , Linus Walleij , Bartosz Golaszewski Subject: Re: [PATCH v1] arm: dts: rockchip: sync rk3066/rk3188 DT files from linux-next v6.2-rc4 Message-ID: References: <48680512-0312-6342-ba0a-f2411463099a@gmail.com> <31883268-dedf-6e3c-8647-0b7955c1ff16@theobroma-systems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Authenticated: YES X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Johan, On Tue, Jan 17, 2023 at 03:44:07PM +0100, Johan Jonker wrote: > On 1/17/23 10:46, Quentin Schulz wrote: > > On 1/16/23 20:45, Johan Jonker wrote: > >> Sync rk3066/rk3188 DT files from Linux. > >> This is the state as of linux-next v6.2-rc4. > >> New nfc node for MK808 rk3066a. > >> CRU nodes now have a clock property. > >> To prefend dtoc errors a fixed clock must also be > >> included for tpl/spl in the rk3xxx-u-boot.dtsi file. > >> > >> Signed-off-by: Johan Jonker > >> --- > > [..] > > >> @@ -223,7 +224,7 @@ > >>           #size-cells = <1>; > >>           ranges; > >> > >> -        gpio0: gpio0@2000a000 { > >> +        gpio0: gpio@2000a000 { > >>               compatible = "rockchip,rk3188-gpio-bank0"; > >>               reg = <0x2000a000 0x100>; > >>               interrupts = ; > >> @@ -236,7 +237,7 @@ > >>               #interrupt-cells = <2>; > >>           }; > >> > >> -        gpio1: gpio1@2003c000 { > > >> +        gpio1: gpio@2003c000 { > > Hi, > > LOL: I made that binding change on request from Linux DT maintainers. > Node names should generic. > > === > > My full u-boot is able to boot a Linux kernel for rk3066a. > Only when I give the command below it crashes: > > gpio status -a > > Could you confirm what other parts are effected? > > If it's boots then it's good enough for me and move forward, so please merge.(Kever) > > Driver fixes for u-boot depending on Linux DT changes is already very time consuming enough! This reminded me of a patch that I never followed up with: https://lore.kernel.org/u-boot/20220726162509.1304234-1-john@metanate.com/ Can you test if that fixes `gpio status -a` for you? John