From: Tom Rini <trini@konsulko.com>
To: seanedmond@linux.microsoft.com
Cc: u-boot@lists.denx.de, joe.hershberger@ni.com,
rfried.dev@gmail.com, seanedmond@microsoft.com
Subject: Re: [PATCH] net: tftp: Fix for DATA ACK for block count out of order
Date: Fri, 3 Feb 2023 13:20:25 -0500 [thread overview]
Message-ID: <Y91QaTP67p5PZuyE@bill-the-cat> (raw)
In-Reply-To: <20230105021626.7032-1-seanedmond@linux.microsoft.com>
[-- Attachment #1: Type: text/plain, Size: 700 bytes --]
On Wed, Jan 04, 2023 at 06:16:26PM -0800, seanedmond@linux.microsoft.com wrote:
> From: Sean Edmond <seanedmond@linux.microsoft.com>
>
> In rfc7440, if an ACK is not received by the server or if the
> last data block in a window is dropped, the server will timeout and
> retransmit the window. In this case, the block count received will be
> less than the internal block count. In this case, the client
> should not ACK. ACK should only be sent if the received block
> count is greater than the expected block count.
>
> Signed-off-by: Sean Edmond <seanedmond@linux.microsoft.com>
> Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-02-03 18:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 2:16 [PATCH] net: tftp: Fix for DATA ACK for block count out of order seanedmond
2023-01-10 17:10 ` Ramon Fried
2023-02-03 18:20 ` Tom Rini [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-01-05 0:45 seanedmond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y91QaTP67p5PZuyE@bill-the-cat \
--to=trini@konsulko.com \
--cc=joe.hershberger@ni.com \
--cc=rfried.dev@gmail.com \
--cc=seanedmond@linux.microsoft.com \
--cc=seanedmond@microsoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox